Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | converting some tests to assert_raises, and DRY'ing retrieve_variable changes | Tieg Zaharia | 2012-04-16 | 1 | -39/+17 |
| | |||||
* | catch nil.to_sym errors in partial_renderer, and raise ArgumentError instead | Tieg Zaharia | 2012-04-16 | 1 | -0/+9 |
| | |||||
* | Merge pull request #5746 from jmbejar/index_method_form_builder | Santiago Pastorino | 2012-04-11 | 1 | -0/+50 |
|\ | | | | | Add method FormBuilder#index | ||||
| * | Add index method to FormBuilder. Useful when you use field_for and need to ↵ | Jorge Bejar | 2012-04-11 | 1 | -0/+50 |
| | | | | | | | | know the index number into the iteration. | ||||
* | | Adding itemscope to list of boolean attributes. | Frankie Roberto | 2012-04-09 | 1 | -2/+2 |
| | | | | | | | | | | | | 'itemscope' is defined within HTML5 for use in microdata markup. See http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.ht ml#attr-itemscope | ||||
* | | default_url_options does not receive one argument anymore | Rafael Mendonça França | 2012-04-08 | 1 | -1/+1 |
| | | |||||
* | | Remove unnecessary in HTML 5 type attribute with default value | Andrey A.I. Sitnik | 2012-04-05 | 4 | -102/+102 |
|/ | |||||
* | add type option to atom feed entry builder | Sergey Nartimov | 2012-04-01 | 1 | -0/+31 |
| | | | | closes #5672 | ||||
* | Block version of label should wrapped in field_with_errors in case of error | Alexey Vakhov | 2012-04-01 | 1 | -0/+14 |
| | |||||
* | datetime_select should work with -/+ infinity dates | Joe Van Dyk | 2012-03-28 | 1 | -0/+12 |
| | |||||
* | Merge pull request #5621 from rafaelfranca/fix-2492-master | Jeremy Kemper | 2012-03-27 | 1 | -0/+34 |
|\ | | | | | Fix label_tag to merge the options hash with the object hash | ||||
| * | Check if the options hash already exists and merge it with the another | Rafael Mendonça França | 2012-03-27 | 1 | -6/+18 |
| | | | | | | | | | | | | hash. Closes #2492 and #5615 | ||||
| * | Fixing issue #2492 for master branch. ActionView::Base.field_error_proc ↵ | Andrey Samsonov | 2012-03-27 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | doesn't call for label. objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example | ||||
* | | Don't break Haml with textarea newline fix. | James Coleman | 2012-03-27 | 1 | -6/+6 |
|/ | | | | | | See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.) Also fix 6 more tests that didn't yet have the newline expectation. | ||||
* | change number_with_precision to not return negative zeros | Tim McEwan | 2012-03-27 | 1 | -0/+1 |
| | |||||
* | Don't ignore non Enumerable values passed to sanitize (closes #5585) | Piotr Sarnacki | 2012-03-27 | 1 | -0/+18 |
| | | | | | | | | | When someone accidentally passes a string to sanitize like: sanitize("<span>foo</span>", :tags => "b") there is no indication that it's the wrong way and span will not be removed. | ||||
* | Remove warning added by my own commit :fire: | Carlos Antonio da Silva | 2012-03-26 | 1 | -1/+1 |
| | | | | Commit: 7a0cf2f5294e8bcef547642435636b394340a3e4 | ||||
* | Merge pull request #5561 from carlosantoniodasilva/form-builder-block-arg | Aaron Patterson | 2012-03-26 | 1 | -0/+12 |
|\ | | | | | Properly deprecate the block argument in AV FormBuilder | ||||
| * | Properly deprecate the block argument in AV FormBuilder | Carlos Antonio da Silva | 2012-03-23 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | Commit 56089ca986c767763f29159c8de0aa1ebabfd4d2 introduced a backward incompatible change by changing the method signature of the FormBuilder. This brings back the same method signature warning in case someone gives a block to the builder. More info: https://github.com/rails/rails/commit/56089ca986c767763f29159c8de0aa1ebabfd4d2#commitcomment-1116166 | ||||
* | | apply form_for namespace option to date_select | Sergey Nartimov | 2012-03-26 | 1 | -0/+8 |
|/ | |||||
* | Fixes issue #5222: DateTimeSelector builds invalid dates on leap day when ↵ | Jey Balachandran | 2012-03-18 | 2 | -7/+21 |
| | | | | discarding both day and month. | ||||
* | time_tag support for blocks | Antonio Tapiador del Dujo | 2012-03-18 | 1 | -0/+4 |
| | |||||
* | Remove remaining sprockets tests | Guillermo Iguaran | 2012-03-13 | 1 | -28/+0 |
| | |||||
* | Remove tests and fixtures for Sprockets on ActionPack | Guillermo Iguaran | 2012-03-13 | 2 | -406/+0 |
| | |||||
* | add include_hidden option to checkbox tag | Sergey Nartimov | 2012-03-13 | 1 | -0/+5 |
| | |||||
* | add 'include_hidden' option to select tag, closes #5402 | Vasiliy Ermolovich | 2012-03-13 | 1 | -0/+8 |
| | |||||
* | Merge pull request #5375 from nertzy/assert_template_with_regexp | Aaron Patterson | 2012-03-12 | 1 | -0/+6 |
|\ | | | | | assert_template matches against Regexp | ||||
| * | assert_template matches against Regexp | Grant Hutchins | 2012-03-10 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows for more strict template assertions, while maintaining backward compatibility. For example, if you use assert_template("foo/bar") and "foo/bar/baz" was rendered, the test passes. But if you use assert_template(%r{\Afoo/bar\Z}), you will catch that a different template was rendered. Also, if you passed an unsupported argument to assert_template() in the past, it would silently succeed. Now it raises an ArgumentError. | ||||
* | | Merge pull request #5380 from benmmurphy/escape_unicode_paragraph_separator | Aaron Patterson | 2012-03-12 | 1 | -0/+2 |
|\ \ | | | | | | | ensure u2029 is escaped in escape_javascript helper | ||||
| * | | ensure u2029 is escaped in escape_javascript helper | benmmurphy | 2012-03-11 | 1 | -0/+2 |
| |/ | |||||
* / | Fixes #5324 by removing default size options from input:text and default ↵ | Philip Arndt | 2012-03-10 | 2 | -165/+165 |
|/ | | | | cols and rows options from textarea. | ||||
* | Merge pull request #5310 from Serabe/layout_for_partials_with_collections | José Valim | 2012-03-06 | 1 | -0/+4 |
|\ | | | | | Adds :layout option to render :partial when a collection is given. | ||||
| * | Adds :layout option to render :partial when a collection is given. | Sergio Arbeo | 2012-03-06 | 1 | -0/+4 |
| | | |||||
* | | Compute asset paths from the request if ENV["RAILS_RELATIVE_URL_ROOT"] is ↵ | Dwayne Litzenberger | 2012-03-05 | 2 | -0/+103 |
|/ | | | | | | | | | not set. This should fix the following issue: "Rails is not a Rack Application (SCRIPT_NAME vs. relative_url_root ?)" https://github.com/rails/rails/issues/910 | ||||
* | Merge pull request #5242 from rails/opt_routes | José Valim | 2012-03-02 | 1 | -2/+2 |
|\ | | | | | | | | | | | | | | | Optimize routes generation in simple cases. If you pass to the route helper the same amount of arguments as the required segments, route generation will be optimized as a string interpolation. After this commit, `post_path(post)` is about 6.5 times faster, `post_url(post)` is about 5 times. | ||||
| * | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 1 | -2/+2 |
| | | |||||
* | | Allow fieldsets to be created without a block. | Ben Pickles | 2012-03-01 | 1 | -0/+10 |
|/ | |||||
* | Merge branch 'master-security' | Aaron Patterson | 2012-03-01 | 1 | -1/+8 |
|\ | | | | | | | | | | | | | | | | | | | | | | | * master-security: Ensure [] respects the status of the buffer. delete vulnerable AS::SafeBuffer#[] use AS::SafeBuffer#clone_empty for flushing the output_buffer add AS::SafeBuffer#clone_empty fix output safety issue with select options Conflicts: actionpack/lib/action_view/helpers/tags/base.rb | ||||
| * | fix output safety issue with select options | Sergey Nartimov | 2012-02-20 | 1 | -1/+8 |
| | | |||||
* | | Add a new line after the textarea opening tag. | Rafael Mendonça França | 2012-02-27 | 2 | -37/+37 |
| | | | | | | | | Closes #393 | ||||
* | | Fix collection_check_boxes and collection_radio_buttons when using local | Rafael Mendonça França | 2012-02-26 | 1 | -0/+38 |
| | | | | | | | | variables in the form builder | ||||
* | | Move all the helpers to protected section | Rafael Mendonça França | 2012-02-26 | 1 | -31/+31 |
| | | |||||
* | | uses PATCH for the forms of persisted records, and routes PATCH and PUT to ↵ | Xavier Noria | 2012-02-24 | 1 | -69/+66 |
| | | | | | | | | the update action of resources | ||||
* | | correct fetching :name option in form fields | Vasiliy Ermolovich | 2012-02-23 | 1 | -0/+5 |
| | | |||||
* | | Merge pull request #5130 from dlee/revised_patch_verb | Xavier Noria | 2012-02-22 | 2 | -0/+15 |
|\ \ | | | | | | | Add config.default_method_for_update to support PATCH | ||||
| * | | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 2 | -0/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | ||||
* | | | format lookup for partials is derived from the format in which the template ↵ | Santiago Pastorino | 2012-02-22 | 2 | -4/+8 |
|/ / | | | | | | | | | | | is being rendered Closes #5025 part 2 | ||||
* | | Don't wrap the raise with ensure | Santiago Pastorino | 2012-02-21 | 1 | -1/+1 |
| | | |||||
* | | Restore lookup formats to the previous value after searching for the failing ↵ | Santiago Pastorino | 2012-02-21 | 1 | -1/+2 |
|/ | | | | view | ||||
* | Merge pull request #5102 from nashby/form-option-refactor | José Valim | 2012-02-20 | 1 | -16/+16 |
|\ | | | | | form option refactor |