Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Allow view helper's #initialize method to be called. [#5061 state:resolved] | Carl Lerche | 2010-09-13 | 1 | -0/+13 |
| | |||||
* | Start cleanup of deprecations in ActionView | Carlos Antonio da Silva | 2010-09-06 | 1 | -8/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'drogus/remove_deprecated_routes' | José Valim | 2010-09-05 | 4 | -7/+6 |
|\ | | | | | | | This merge removes the deprecated routes mapper from Rails and update its tests. | ||||
| * | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 4 | -7/+6 |
| | | |||||
* | | Make number_to_human and number_with_precision work with negatives | Santiago Pastorino | 2010-09-05 | 1 | -0/+2 |
| | | |||||
* | | Fix indentation errors | Santiago Pastorino | 2010-09-05 | 1 | -47/+47 |
| | | |||||
* | | Fix number_to_human(0) exception [#5532 state:resolved] | Ben Sharpe | 2010-09-05 | 1 | -0/+1 |
|/ | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove namespace for isolated namespaced models in forms | Piotr Sarnacki | 2010-09-03 | 1 | -0/+17 |
| | |||||
* | Added ability to set asset_path for engines | Piotr Sarnacki | 2010-09-03 | 1 | -0/+23 |
| | |||||
* | Extended url_for to handle specifying which router should be used. | Piotr Sarnacki | 2010-09-03 | 2 | -51/+41 |
| | | | | | | | A few examples: url_for Blog::Engine, :posts_path url_for Blog::Engine, @post url_for Blog::Engine, :action => "main", :controller => "index" | ||||
* | Removing unnecessary code from render_test | Thiago Pradi | 2010-09-02 | 1 | -2/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Removing unnecessary code | Thiago Pradi | 2010-09-02 | 1 | -7/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Added :format option for form_for helper and spec for this [#5226 ↵ | Alex Chrome | 2010-09-01 | 1 | -2/+18 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove NonConcattingString. | José Valim | 2010-08-29 | 1 | -2/+0 |
| | |||||
* | Remove deprecated support to <% form_for %> and several ↵ | José Valim | 2010-08-29 | 2 | -43/+10 |
| | | | | ActionController::Base methods. | ||||
* | password_field renders with nil value by default | Santiago Pastorino | 2010-08-28 | 1 | -1/+4 |
| | | | | | | | | This makes the use of passwords secure by default if you want to render the value of the password_field you have to do for instance f.password_field(:password, :value => @user.password) # => <input type=password id=user_password name=user[password] value=#{@user.password} /> | ||||
* | Make InstanceTagMethods#value_before_type_cast raise if the model don't ↵ | Santiago Pastorino | 2010-08-27 | 1 | -0/+13 |
| | | | | | | respond to attr_before_type_cast or attr method [#3374] [#5471 state:committed] | ||||
* | Move encoding settings for testing purposes to abstract_unit file | Santiago Pastorino | 2010-08-21 | 1 | -8/+1 |
| | |||||
* | Revert "It's snowing!" | wycats | 2010-08-18 | 2 | -2/+2 |
| | | | | This reverts commit e4283007d607454acf97301821ba1e1c417bdead. | ||||
* | code gardening: we have assert_(nil|blank|present), more concise, with ↵ | Xavier Noria | 2010-08-17 | 1 | -1/+1 |
| | | | | better default failure messages - let's use them | ||||
* | select tags coerce the :selected option, options to strings before ↵ | Subba Rao Pasupuleti | 2010-08-15 | 1 | -0/+62 |
| | | | | | | comparison [#5056 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Making time_zone_options_for_select return a html_safe string | Mikel Lindsaar | 2010-08-15 | 1 | -0/+4 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 16 | -104/+104 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | It's snowing! | Jeremy Kemper | 2010-08-12 | 2 | -2/+2 |
| | |||||
* | Replace snowman with utf8=✓ | wycats | 2010-08-11 | 2 | -2/+2 |
| | |||||
* | layout_for works again with objects as specified in the documentation and ↵ | José Valim & Carlos Antonio da Silva | 2010-08-11 | 1 | -0/+5 |
| | | | | Rails 2.3 [#5357 state:resolved] | ||||
* | rename _snowman to _e | wycats | 2010-08-09 | 2 | -2/+2 |
| | |||||
* | Fix label form helper to use I18n and html options, without the need of ↵ | Carlos Antonio da Silva | 2010-08-01 | 1 | -2/+9 |
| | | | | | | | | | | | 'nil' text param: Before: f.label :title, nil, :class => 'title' After : f.label :title, :class => 'title' [#5267 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Makes form_helper use overriden model accessors | Santiago Pastorino | 2010-08-01 | 1 | -0/+17 |
| | | | | [#3374 state:committed] | ||||
* | link_to_function now expects a piece of javascript code for the onclick ↵ | Rodrigo Dominguez | 2010-07-29 | 1 | -4/+5 |
| | | | | | | | | parameter [#5179] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Removed deprecated APIs in text and number helpers [#5156 state:resolved] | Łukasz Strzałkowski | 2010-07-26 | 1 | -27/+0 |
| | | | | | | They're deprecated since 2008. It's time to get rid of them. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add assertion to link_to_function test with block and capture, and more ↵ | Carlos Antonio da Silva | 2010-07-25 | 1 | -5/+4 |
| | | | | | | expressive test name [#5179 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Change returning with tap | Santiago Pastorino | 2010-07-25 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed output_buffer encoding problem [#5179] | Sebastian A. Espindola | 2010-07-25 | 1 | -0/+9 |
| | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | These tests are trusting in the order of the elements so use OrderedHash ↵ | Santiago Pastorino | 2010-07-21 | 1 | -13/+9 |
| | | | | instead of Hash | ||||
* | remote_function patch with more detailed test | Andrew Kaspick | 2010-07-21 | 1 | -0/+6 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | select :include_blank or :prompt should return escaped string [#5099 ↵ | Ivan Torres | 2010-07-18 | 1 | -0/+23 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | remove size attribute from tag generated by file_field helper [#5084 ↵ | Miles Egan | 2010-07-13 | 1 | -0/+5 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor recall parameter normalization [#5021 state:resolved] | Andrew White | 2010-07-03 | 1 | -2/+27 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | We are trying to test that & escapes here not that & is being escaped, ↵ | Santiago Pastorino | 2010-06-29 | 1 | -3/+2 |
| | | | | | | also added a cosmetic change to test_link_tag_with_query_and_no_name Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | s/escape_once/html_escape/, since html safety is the contract that now says ↵ | Xavier Noria | 2010-06-30 | 2 | -4/+4 |
| | | | | whether something has to be escaped | ||||
* | url_for no longer escapes HTML, the :escape option is also gone | Xavier Noria | 2010-06-30 | 1 | -16/+4 |
| | | | | Rationale: url_for is just a path/URL generator, it is the responsability of the caller to escape conveniently HTML needs it, JavaScript needs different escaping, a text mail needs no escaping at all, etc. | ||||
* | Rename _snowman_ to _snowman to be in sync with _method and _csrf_token. | José Valim | 2010-06-29 | 2 | -2/+2 |
| | |||||
* | Restores the escaping of urls generated from hashes. [#4765 state:resolved] | Andrew White | 2010-06-28 | 1 | -8/+4 |
| | | | | | | | | | | | | | | HTML specifications recommend the escaping of urls in web pages, which url_for does by default for string urls and consquently urls generated by path helpers as these return strings. Hashes passed to url_for are not escaped by default and this commit reverses this default so that they are escaped. Undoes the changes of this commit: http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944 Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Strip_tags never ending attribute should not raise a TypeError [#4870 ↵ | Bruno Michel | 2010-06-28 | 1 | -0/+4 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix several known web encoding issues: | wycats | 2010-06-27 | 4 | -194/+253 |
| | | | | | | | | | | | | | | | | | | | | | | | * Specify accept-charset on all forms. All recent browsers, as well as IE5+, will use the encoding specified for form parameters * Unfortunately, IE5+ will not look at accept-charset unless at least one character in the form's values is not in the page's charset. Since the user can override the default charset (which Rails sets to UTF-8), we provide a hidden input containing a unicode character, forcing IE to look at the accept-charset. * Now that the vast majority of web input is UTF-8, we set the inbound parameters to UTF-8. This will eliminate many cases of incompatible encodings between ASCII-8BIT and UTF-8. * You can safely ignore params[:_snowman_] TODO: * Validate inbound text to confirm it is UTF-8 * Combine the whole_form implementations in form_helper_test and form_tag_helper_test | ||||
* | Normalize recall params when the route is not a standard route otherwise ↵ | Andrew White | 2010-06-27 | 1 | -0/+22 |
| | | | | | | :controller and :action may appear in the generated url [#4326 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Change reference to Test::Unit::AssertionFailedError to the generic ↵ | David Trasbo | 2010-06-26 | 1 | -1/+1 |
| | | | | | | ActiveSupport::TestCase::Assertion [#4987 state:commited] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Do not wrap hidden fields with error proc [#4962 state:resolved] | Carlos Antonio da Silva | 2010-06-25 | 1 | -0/+7 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵ | José Valim | 2010-06-24 | 1 | -5/+5 |
| | | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] |