aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template
Commit message (Collapse)AuthorAgeFilesLines
* remove assigned but unused variable warningNihad Abbasov2013-02-211-2/+2
|
* Revert "Merge pull request #4803 from lucascaton/master"Santiago Pastorino2013-02-201-1/+1
| | | | | | | | | | | | | | | This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7. This was causing issues in one of our apps we just upgraded. ActionController::RoutingError: No route matches [GET] "/images/favicon.ico" favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned '/favicon.ico' Browsers by default look for favicon.ico in the root directory Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/asset_tag_helper.rb
* Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-191-0/+7
| | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* Improve img alt attribute for screen readersthenickcox2013-02-091-1/+2
| | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method
* partials inside directory work with `assert_template`Yves Senn2013-02-041-0/+12
| | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
* descriptive `assert_template` error when partial wasn't renderedYves Senn2013-02-041-0/+9
| | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error.
* Fix `content_tag_for` with array html option.Semyon Perepelitsa2013-01-311-0/+6
| | | | | | | | | | | | | | | | | It would embed array as string instead of joining it like `content_tag` does: content_tag(:td, class: ["foo", "bar"]){} #=> '<td class="foo bar"></td>' Before: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item [&quot;foo&quot;, &quot;bar&quot;]" id="item_1"></td>' After: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item foo bar" id="item_1"></td>'
* Make current_url? work with a HEAD methodMichiel Sikkes2013-01-281-0/+6
| | | | | | ActionDispatch::Head was removed in favor of Rack::Head. But Rack::Head does not convert GET requests to HEAD requests so we need to do checking for HEAD requests ourselves.
* Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-282-5/+5
|
* Stylistic pass at form_helper_testRafael Mendonça França2013-01-211-286/+362
|
* Capture block so content won't leak.José Mota2013-01-211-0/+57
| | | | | | | | | | | | | | The [following pull request](https://github.com/rails/rails/pull/8916) fixed the block being passed to the appropriate helper method. However, the content being passed into the block is generating repeated markup on the page due to some weird ERb evaluation. This commit tries to capture the block's generated output so the page isn't flooded with markup. [Rafael França + José Mota] Closes #8936
* Remove i18n symbol dependencyChris McGrath2013-01-171-3/+8
| | | | | | | | | date.order is the only key in rails i18n that is required to be a symbol. This patch allows for symbols or strings which means: * No requirement for symbol type in .yml files. A future YAML.safe_load wouldn't need to load symbols * Rails could actually use json rather than yml as the backend
* Fix date_select :selected option so you can pass it nilColin Burn-Murdoch2013-01-161-1/+64
|
* Merge pull request #8938 from colinbm/date_select_valueSteve Klabnik2013-01-141-2/+50
|\ | | | | Rename :value to :selected for date_select, and add missing tests/docs
| * Rename :value option to :selected, in line with other select helpersColin Burn-Murdoch2013-01-141-2/+50
| | | | | | | | | | Add tests for time & datetime. Add documentation.
* | Revert benchmark helper regression. Use a #capture within a #benchmarkJeremy Kemper2013-01-141-24/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | block. Breaks benchmark calls that return non-String values otherwise. Revert "add benchmark helper that works in erb" This reverts commit 904e544cc8f5846de7c31827bb5556c6a238c0de. Conflicts: actionpack/lib/action_view/helpers.rb actionpack/lib/action_view/helpers/benchmark_helper.rb actionpack/test/template/benchmark_helper_test.rb
* | Merge pull request #8916 from josemota/collection-with-blockRafael Mendonça França2013-01-131-0/+49
|\ \ | |/ |/| | | | | Collection radio buttons and collection check boxes through FormBuilder render the provided block. Closes #8897
| * Collection radio buttons and collection check boxes through FormBuilder renderJosé Mota2013-01-121-0/+49
| | | | | | | | | | | | | | | | the provided block. In the case of having a form_for method being called, the block for each collection would not be passed and thus the result expected was always the same. This patch passes the block to the original method like it would be assumed.
* | Allow value to be set on date_selectColin Burn-Murdoch2013-01-131-0/+21
| |
* | Associaton -> AssociationSteve Klabnik2013-01-131-2/+2
|/
* Merge pull request #8623 from virusman/form_helpers_collectionproxy_fixJon Leighton2013-01-111-0/+23
|\ | | | | Fixed nested fields bug when called with AssociationProxy
| * Test nested fields with AssociationProxy mockup & fix AssociationProxy ↵virusman2012-12-271-0/+23
| | | | | | | | support in form helper
* | view_cache_dependency APIJamis Buck2013-01-081-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | A declarative API for specifying dependencies that affect template cache digest computation. In your controller, specify any of said dependencies: view_cache_dependency { "phone" if using_phone? } When the block is evaluated, the resulting value is included in the cache digest calculation, allowing you to generate different digests for effectively the same template. (Mostly useful if you're mucking with template load paths.)
* | set 'alt' attribute for image_submit_tagNihad Abbasov2013-01-081-2/+2
| |
* | Do not generate local vars for partials without object or collectionCarlos Antonio da Silva2013-01-081-0/+7
| | | | | | | | | | | | | | | | | | Previously rendering a partial without giving :object or :collection would generate a local variable with the partial name by default. This was noticed due to warnings in Ruby 2.0 of not used variables, which turned out to be the generation of not used variables inside partials that do not contain objects related to them.
* | Do not call fields_for from form_for, to avoid instantiating two buildersCarlos Antonio da Silva2013-01-061-1/+13
| |
* | deprecate `assert_blank` and `assert_present`.Yves Senn2013-01-051-1/+1
| | | | | | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?`
* | No need to pass a empty block to content_tag_for anymoreRafael Mendonça França2013-01-021-11/+11
| |
* | Make content_tag_for work without blockRafael Mendonça França2013-01-021-0/+8
| | | | | | | | This is version of #8640 for master
* | Remove unneeded testsRafael Mendonça França2012-12-312-95/+0
| | | | | | | | These tests are needed only if we are using MiniTest::Spec
* | Fix collection_radio_buttons with the option `:checked` with value ofRafael Mendonça França2012-12-261-0/+6
|/ | | | `false`
* Digestor explicit dependency should not contain trailing whitespaceBrian Alexander2012-12-211-0/+6
| | | | test for rails/rails#8586
* Remove obfuscation support from mail_to helperNick Reed2012-12-181-56/+0
| | | | | | Removes support for :encode, :replace_at, and :replace_dot options from the mail_to helper. Support for these options has been extracted to the 'actionview-encoded_mail_to' gem.
* handle protocol option in stylesheet_link_tag and javascript_include_tagVasiliy Ermolovich2012-12-181-1/+23
| | | | closes #8388
* Override <%== to always behave as literal text rather than toggling based on ↵Jeremy Kemper2012-12-031-2/+2
| | | | whether escaping is enabled. Fixes that existing plaintext email templates using <%== unexpectedly flipped to *escaping* HTML when #8235 was merged.
* More descriptive error when rendering a partial with `:layout => true`Yves Senn2012-12-021-0/+5
|
* No sort Hash options in #grouped_options_for_selectSergey Kojin2012-11-271-1/+1
|
* Fix failing template testsCarlos Antonio da Silva2012-11-161-2/+2
| | | | Introduced in 4a4de567b45ff28035419bc2d92f9b206e3c0a66.
* Introduce `ActionView::Template::Handlers::ERB.escape_whitelist`.Joost Baaij2012-11-161-1/+15
| | | | | | | | | | | This is a list of mime types where template text is not html escaped by default. It prevents `Jack & Joe` from rendering as `Jack &amp; Joe` for the whitelisted mime types. The default whitelist contains text/plain. This follows a whitelist approach where plain text templates are not escaped, and all the others (json, xml) are. The mime type is assumed to be set by the abstract controller.
* Merge pull request #8222 from marcandre/avoid_slashRafael Mendonça França2012-11-141-0/+5
|\ | | | | Avoid using Integer#/, as it is redefined by the 'mathn' stdlib
| * Avoid using Integer#/, as it is redefined by the 'mathn' stdlibMarc-Andre Lafortune2012-11-141-0/+5
| |
* | Ruby 2.0.0 defaults source encoding to utf-8 so we need to specifically tag ↵Aaron Patterson2012-11-121-0/+1
|/ | | | this file with us-ascii
* Support :multiple option on input tags with :indexDaniel Fox, Grant Hutchins & Trace Wax2012-11-021-0/+13
| | | | | When you have an explicit index set, then when you build an input tag with :multiple => true, it doesn't add [] to the end of its name, although it should.
* Add test to ensure data attributes are properly escaped with tag helpersCarlos Antonio da Silva2012-11-011-2/+7
| | | | Closes #8091
* Fix failing tests and use new hash style in deprecation messagesCarlos Antonio da Silva2012-10-292-12/+12
|
* Improve the deprecation message of link_to_function andRafael Mendonça França2012-10-271-6/+6
| | | | | | button_to_function Point the the Unobtrusive JavaScript secion in the JavaScript guide
* cleanup, remove trailing whitespace within actionpackYves Senn2012-10-272-3/+3
|
* check_box value can be not only an object of Array classVasiliy Ermolovich2012-10-201-0/+6
| | | | there is a chance that `value` is a Set or an object that reponses to `include?` method so let's handle this case
* Add i18n scope to disance_of_time_in_words.Steve Klabnik2012-10-191-10/+19
| | | | This fixes #733.
* Merge pull request #7975 from butcher/extend_date_select_helper_functionalityRafael Mendonça França2012-10-181-0/+16
|\ | | | | | | | | | | | | Extend date_select helper functionality. Conflicts: actionpack/CHANGELOG.md
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 21:28:09 +0000