aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template
Commit message (Collapse)AuthorAgeFilesLines
* Significantly improved internal encoding heuristics and support.wycats2010-05-162-5/+133
| | | | | | | | | | | | | | | | | | | | | | | | | * Default Encoding.default_internal to UTF-8 * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file * Read templates as BINARY, use default_external or template-wide magic comments inside the Template to set the initial encoding * This means that template handlers in Ruby 1.9 will receive Strings encoded in default_internal (UTF-8 by default) * Create a better Exception for encoding issues, and use it when the template source has bytes that are not compatible with the specified encoding * Allow template handlers to opt-into handling BINARY. If they do so, they need to do some of their own manual encoding work * Added a "Configuration Gotchas" section to the intro Rails Guide instructing users to use UTF-8 for everything * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid $KCODE value is used Also: * Fixed a few tests that were assert() rather than assert_equal() and were caught by Minitest requiring a String for the message * Fixed a test where an assert_select was misformed, also caught by Minitest being more restrictive * Fixed a test where a Rack response was returning a String rather than an Enumerable
* Fixed 1 failure in ActionPack testsuite [#4613 state:resolved]Hussein Morsy2010-05-161-2/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* added support for html attributes in options_for_select [#2165]pleax2010-05-161-0/+56
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited]rohit2010-05-161-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Sending :id => nil to form helpers now properly omits the "id" html element ↵Jeff Dean2010-05-151-0/+107
| | | | | | [#4559 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Accept :alt => nil on image_tag [#4558 state:resolved]Marc-Andre Lafortune2010-05-151-1/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Improve previous patch a bit [#3645 state:resolved]José Valim2010-05-151-0/+5
|
* Let label helpers accept blocks.Stephen Celis2010-05-152-3/+16
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Use annoted source code in Template:Error to avoid special cases in the show ↵José Valim2010-05-091-0/+1
| | | | exceptions middleware.
* Favor %{} in all code instead of (deprecated) {{}} as interpolation syntax ↵Lawrence Pit2010-05-031-3/+3
| | | | | | for I18n Signed-off-by: José Valim <jose.valim@gmail.com>
* add NullResolverDavid Chelimsky2010-05-021-0/+12
| | | | | | [#4523 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* add tests for FixtureResolverDavid Chelimsky2010-05-021-0/+18
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge branch 'master' of github.com:rails/railswycats2010-04-301-21/+80
|\
| * Fix form builder and form helpers inconsistencies [#4432 state:resolved]Neeraj Singh2010-04-291-21/+80
| | | | | | | | | | | | | | | | * datetime_select and select_datetime should be consistent as much as possible * date_select and select_date should be consistent as much as possible * time_select and select_time should be consistent as much as possible Signed-off-by: José Valim <jose.valim@gmail.com>
* | Merge branch 'master' of github.com:rails/railswycats2010-04-263-7/+5
|\|
| * Explicit source encodingJeremy Kemper2010-04-241-0/+1
| |
| * Rename fieldWithErrors style to field_with_errors. Remove unused alert style.Jeremy Kemper2010-04-241-4/+4
| |
| * Clean up the config object in ActionPack. Create config_accessor which just ↵José Valim2010-04-221-3/+0
| | | | | | | | delegates to the config object, reducing the number of deprecations and add specific tests.
* | Allow :remote => false to be passed to link_toNicolas Sanguinetti2010-04-222-0/+20
|/ | | | | | | And add tests for `button_to` and `form_tag` which currently behave as expected, so we avoid a regression. Signed-off-by: wycats <wycats@gmail.com>
* params already has a setted controller and action hereSantiago Pastorino2010-04-211-1/+0
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* url_for now works with HashWithIndifferentAccess ht jay [#4391 state:committed]Santiago Pastorino2010-04-211-0/+10
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Merge branch 'master' of github.com:rails/railsCarl Lerche2010-04-181-2/+2
|\
| * fisting codes so it will parse [#4430 state:resolved]Aaron Patterson2010-04-171-2/+2
| | | | | | | | Signed-off-by: wycats <wycats@gmail.com>
* | mail_to with :encode => :javascript now outputs safe htmlSam Elliott2010-04-161-2/+6
|/ | | | Signed-off-by: Carl Lerche <carllerche@mac.com>
* Mark the result of grouped_options_for_select as HTML safe [#4322 ↵Kieran Pilkington2010-04-161-0/+4
| | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com>
* Changed translate helper so that it doesn’t mark every translation as safe ↵Craig Davey2010-04-131-1/+16
| | | | | | HTML. Only keys with a "_html" suffix and keys named "html" are considered to be safe HTML. All other translations are left untouched. Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
* Add a test that used to fail but is fixed now [#3417 state:resolved]wycats2010-04-121-0/+1
|
* fields_for returns block result when outside ERBRyan Bates2010-04-111-0/+5
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Remove input, form, error_messages_for and error_message_on from the ↵José Valim2010-04-103-363/+12
| | | | framework. If you think you will miss them, feel free to use the dynamic_form plugin available at http://github.com/rails/dynamic_form
* fix stack trace lines on class_evalSantiago Pastorino2010-04-091-2/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Expect an incompatible encoding exception when a template with a magic ↵Jeremy Kemper2010-04-081-2/+13
| | | | comment renders a partial without one and its source encoding doesn't match the default external encoding
* Expect an incompatible encoding exception when a template doesn't have a ↵Jeremy Kemper2010-04-081-25/+36
| | | | magic comment and its source encoding doesn't match the default external encoding
* adds #favicon_link_tag back, rdoc explains why it is useful, and how to get ↵Xavier Noria2010-04-081-0/+12
| | | | a link for Mobile Safari with it
* Consistently use lowercase instead of camelCase for all JS class names in RailsDavid Heinemeier Hansson2010-04-081-10/+10
|
* Revert "adds #favicon_link_tag and #apple_touch_icon_link_tag" -- these tags ↵David Heinemeier Hansson2010-04-081-20/+0
| | | | | | are too specific. This reverts commit 6891f46d10957f21f200fc4dc2b6076ff411b1da, ec8610cfdc32d0fe816fb22405e00ef1b6c90d73, and d18ff1b7efd96e7c08bc1a15137735be45f87e07.
* adds a default source to #apple_touch_icon_link_tagXavier Noria2010-04-071-0/+1
|
* new helpers #favicon_link_tag and #apple_touch_icon_link_tagXavier Noria2010-04-071-0/+19
|
* Rename search_field to test_search_field (ht: Piotr Usewicz)José Valim2010-04-061-1/+1
|
* Added all the new HTML5 form types as individual form tag methods (search, ↵David Heinemeier Hansson2010-04-052-0/+60
| | | | url, number, etc) (Closes #3646) [Stephen Celis]
* changed from :object_name to :as on form_for apiSantiago Pastorino2010-04-052-12/+8
|
* deprecate form_for(symbol_or_string, ...) in favor of :object_name optionSantiago Pastorino2010-04-051-212/+327
|
* Refactored url_for in AV to have its own instances of the helpers instead of ↵wycats2010-04-038-290/+265
| | | | proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win)
* Fix memory leak in dev modewycats2010-04-021-0/+8
|
* Fix error in number_with_precision with :significant option and zero value ↵Bernardo de Pádua2010-04-011-0/+9
| | | | | | [#4306 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* HTML safety: give a deprecation warning if an array of option tags is passed ↵Jeremy Kemper2010-03-311-0/+6
| | | | to select tag. Be sure to join the tag yourself and mark them .html_safe
* Consistent routing languageJoshua Peek2010-03-301-1/+1
|
* Updated asset_template_path to asset_path and have it also support a String ↵wycats2010-03-281-1/+8
| | | | [#4247 state:resolved]
* Allow customisation of asset path generation using a proc.Craig R Webster2010-03-281-0/+9
| | | | | | | | | | | | | | | | Set config.action_controller.asset_path_template to a proc that takes one argument - the direct, unchanged asset path - and returns a path to that asset using the scheme that your assets require. This is useful if you have a setup which scales by introducing new application servers where the mtime of the asset files may not be the same as those of the asset files on your previous servers, but it does require your web servers to have knowledge of the asset template paths that you rewrite to so it's not suitable for out-of-the-box use. An example of configuring asset path generation and rewriting these paths using Apache is included in actionpack/lib/action_view/helpers/asset_tag_helper.rb. Signed-off-by: wycats <wycats@gmail.com>
* html_tag option to wrap error_message_on text [#4283 state:resolved]Paco Guzman2010-03-281-0/+4
| | | Signed-off-by: wycats <wycats@gmail.com>
* Fixes a bug where error_messages_for was returning an empty div [#4048 ↵wycats2010-03-271-0/+4
| | | | state:resolved] (ht: Geoff Garside)