| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
escaped
|
| |\
| |
| | |
don't escape options in option_html_attributes method
|
| | |
| |
| |
| |
| |
| |
| |
| | |
we don't need to escape values in this method as we pass
these html attributes to `tag_options` method that handle escaping as
well.
it fixes the case when we want to pass html5 data options
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
|
| |
This applies to the following helpers:
`button_to`
`button_tag`
`image_submit_tag`
`link_to`
`submit_tag`
|
| |
|
|
| |
and PartialRenderer
|
| |
|
|
|
|
| |
When a select tag is created for a field with errors, then the inserted
options will errantly have a <div class="field_with_errors"> wrapping
them.
|
| |
|
|
|
| |
The extension was removed in 22bc12ec374b8bdeb3818ca0a3eb787dd3ce39d8,
making "test" an alias for minitest's "it".
|
| | |
|
| |
|
|
|
| |
They also make more sense here since all the related logic with I18n is
handled by AS::NumberHelper, and not by AV anymore.
|
| |
|
|
|
|
| |
Just make use of the returning exception from assert_raise, instead of
calling the method again with a rescue clause to test the saved
exception number.
|
| |\
| |
| | |
Make the Resolver template cache threadsafe
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
The Template cache in the Resolver can be accessed by multiple threads
similtaneously in multi-threaded environments. The cache is implemented
using a Hash, which isn't threadsafe in all VMs (notably JRuby).
This commit extracts the cache to a new Cache class and adds mutexes to
prevent concurrent access.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using compute_source_path to determine the full path of an
asset, if our source begins with '/', we don't want to include
the directory. Examples are illustrative:
> compute_source_path("foo", "stylesheets", "css")
=> "/Users/steve/src/my_app/public/stylesheets/foo.css"
> compute_source_path("/foo", "stylesheets", "css")
=> "/Users/steve/src/my_app/public/foo.css"
Before this patch, the second example would return the same as the
first.
Fixes #5680.
|
| | |
| |
| |
| |
| | |
Module#instance_methods returns an Array of Symbols in Ruby >= 1.9
So this was not actually testing anything
|
| | | |
|
| | |
| |
| |
| |
| | |
Similarly to 6525002, this allows to use routes helpers for mounted
helpers, but this time in ActionView::TestCase
|
| | |
| |
| |
| | |
Add some tests for link_to with blocks and escaping content.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make possible to use a block in button_to helper if button text is hard
to fit into the name parameter, e.g.:
<%= button_to [:make_happy, @user] do %>
Make happy <strong><%= @user.name %></strong>
<% end %>
# => "<form method="post" action="/users/1/make_happy" class="button_to">
# <div>
# <button type="submit">
# Make happy <strong>Name</strong>
# </button>
# </div>
# </form>"
|
| | | |
|
| | |
| |
| |
| | |
This options can be used to not escape the result by default.
|
| | |
| |
| |
| | |
Refactoring the truncate method to not do a sort-circuit return
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
rails helpers.
This way if my text is long I don't have to do something like this:
.text
= truncate(@text, :length => 27)
if @text.size >= 27
= link_to "continue", notes_path, ....."")
|
| | |
| |
| |
| | |
These tests check the values of 'min' and 'max' input attrs
|
| |\ \
| | |
| | | |
Add HTML5 color and date/time inputs
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The input types added are:
- input[type="month"]
- input[type="week"]
- input[type="datetime"]
- input[type="datetime-local"]
|
| | | | |
|
| | |/
|/|
| |
| |
| | |
* Added tests for 'else' case in ActionView::Helpers::TranslationHelper#wrap_translate_defaults
* Also updated the testing syntax of translation.html_safe? asserts to provide better output upon failure.
|
| | |
| |
| |
| |
| | |
This reverts commit 254c04286c5916ae7f91eb6e173b312e7a74e364, reversing
changes made to 513a0525c24c2944630acfa465b22cd2f4601adf.
|
| |\ \
| |/
|/| |
Resolver concurrency fix
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
The Template cache in the Resolver can be accessed by multiple threads
similtaneously in multi-threaded environments. The cache is implemented
using a Hash, which isn't threadsafe in all VMs (notably JRuby).
This commit extracts the cache to a new Cache class and adds mutexes to
prevent concurrent access.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make the method API more clear by explicitly showing the expected
arguments. This means that the options cannot be passed as second
argument because we are not relying on extract_options! anymore,
you are expected to give a selected key or `nil` if you want to pass
options, as it is the last argument.
Notice that this does not change the current method arguments contract
available in 3.2, it just brings back the same functionality with the
divider addition.
|
| |\ \
| | |
| | | |
Tidied and standardised text_helper implementations.
|
| | | | |
|
| | | | |
|
| |/ /
| |
| |
| | |
escaping of delimiters and separators
|
| |\ \
| | |
| | | |
Render img tag with empty src if empty string is passed to image_tag.
|
| | |/ |
|
| |/ |
|
| | |
|
| |\
| |
| | |
TagHelper creates invalid data attributes when value is a BigDecimal
|
| | | |
|
| |\ \
| |/
|/| |
Created a Raw handler for templates.
|
| | |
| |
| |
| | |
Fixes #2394
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Greenie0506/add_separator_to_grouped_options_for_select
Add separator option to grouped_options_for_select
|
| | | |
| | |
| | |
| | | |
Change prompt to options hash in grouped_options_for_select
|
