aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template
Commit message (Collapse)AuthorAgeFilesLines
* Do not mark strip_tags result as html_safeSantiago Pastorino2012-08-091-2/+2
| | | | | | Thanks to Marek Labos & Nethemba CVE-2012-3465
* Allow data attributes to be set as a first-level option for form_for, so you ↵David Heinemeier Hansson2012-08-081-0/+6
| | | | can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH*
* Deprecate `button_to_function` and `link_to_function` helpers.Rafael Mendonça França2012-08-071-0/+42
| | | | | | | | | | | | | | | | | | | | | | We recommend the use of Unobtrusive JavaScript instead. For example: link_to "Greeting", "#", :class => "nav_link" $(function() { $('.nav_link').click(function() { // Some complex code return false; }); }); or link_to "Greeting", '#', onclick: "alert('Hello world!'); return false", class: "nav_link" for simple cases. This reverts commit 3acdd652e9fe99481c879c84c5807a84eb9ad724.
* Revert "Merge pull request #7033 from kron4eg/master". Not a a fan at all of ↵David Heinemeier Hansson2012-08-071-54/+0
| | | | | | | what this makes ERB files look like. This reverts commit 46b8bceedd3e47169c50a04c93161424909c75fb, reversing changes made to 2f58795e783150f2e1b1f6c64e305703f0061129.
* Restoring the '%' trim mode for ERb templates, allowing for a leading ↵Artiom Di2012-08-071-0/+54
| | | | percent sign on a line to indicate non-inserted Ruby code.
* Do not include application.js if it doesn't existsPrem Sichanugrist2012-08-061-0/+9
| | | | | | Rails were including 'application.js' to the pack when using `javascript_include_tag :all` even there's no application.js in the public directory.
* Don't use `html_escape` to test the escapingRafael Mendonça França2012-08-054-4/+4
|
* removes usage of Object#in? from the code base (the method remains defined ↵Xavier Noria2012-08-064-4/+4
| | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case.
* Add test select_tag escapes promptSantiago Pastorino2012-08-031-0/+6
|
* load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-024-4/+0
|
* Improve error handling when using partial name with hyphen. Fix #7079kennyj2012-08-031-0/+7
|
* html_escape should escape single quotesSantiago Pastorino2012-07-316-22/+22
| | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215
* Replace the flush parameter with a Hash.Lucas Mazza2012-07-241-9/+9
|
* Add one more test case to make sure that data attributes are beingRafael Mendonça França2012-07-221-0/+7
| | | | escaped
* Merge pull request #7123 from nashby/data-in-optionsRafael Mendonça França2012-07-221-7/+14
|\ | | | | don't escape options in option_html_attributes method
| * don't escape options in option_html_attributes methodVasiliy Ermolovich2012-07-221-7/+14
| | | | | | | | | | | | | | | | we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options
* | Add back `:disable_with` and change deprecation horizon to 4.1Carlos Galdino + Rafael Mendonça França2012-07-212-2/+34
| |
* | Add back `:confirm` and change deprecation horizon to 4.1Carlos Galdino + Rafael Mendonça França2012-07-212-0/+86
|/
* Remove `:confirm` in favor of `:data => { :confirm => 'Text' }` optionCarlos Galdino2012-07-182-9/+16
| | | | | | | | | This applies to the following helpers: `button_to` `button_tag` `image_submit_tag` `link_to` `submit_tag`
* Common behavior with adding formats to lookup_context for TemplateRenderer ↵Dmitry Vorotilin2012-07-181-0/+10
| | | | and PartialRenderer
* Fixed bug creating invalid HTML in select optionsRusty Geldmacher2012-07-101-0/+14
| | | | | | When a select tag is created for a field with errors, then the inserted options will errantly have a <div class="field_with_errors"> wrapping them.
* Remove AS declarative extension from erb tag testCarlos Antonio da Silva2012-07-081-3/+0
| | | | | The extension was removed in 22bc12ec374b8bdeb3818ca0a3eb787dd3ce39d8, making "test" an alias for minitest's "it".
* Added support add_flash_typeskennyj2012-07-071-6/+6
|
* Move number helper i18n related tests to ASCarlos Antonio da Silva2012-06-241-122/+0
| | | | | They also make more sense here since all the related logic with I18n is handled by AS::NumberHelper, and not by AV anymore.
* Refactor AV number helper tests with invalid numbersCarlos Antonio da Silva2012-06-241-44/+14
| | | | | | Just make use of the returning exception from assert_raise, instead of calling the method again with a rescue clause to test the saved exception number.
* Merge pull request #6428 from pinetops/resolver_concurrency_fixYehuda Katz2012-06-211-4/+4
|\ | | | | Make the Resolver template cache threadsafe
| * Make the Resolver template cache threadsafe - closes #6404Tom Clarke2012-05-211-4/+4
| | | | | | | | | | | | | | | | | | The Template cache in the Resolver can be accessed by multiple threads similtaneously in multi-threaded environments. The cache is implemented using a Hash, which isn't threadsafe in all VMs (notably JRuby). This commit extracts the cache to a new Cache class and adds mutexes to prevent concurrent access.
* | stop subclassing stringAaron Patterson2012-06-211-1/+1
| |
* | Respect absolute paths in compute_source_path.Steve Klabnik2012-06-161-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using compute_source_path to determine the full path of an asset, if our source begins with '/', we don't want to include the directory. Examples are illustrative: > compute_source_path("foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/stylesheets/foo.css" > compute_source_path("/foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/foo.css" Before this patch, the second example would return the same as the first. Fixes #5680.
* | fix meaningless test caseAkira Matsuda2012-06-061-1/+1
| | | | | | | | | | Module#instance_methods returns an Array of Symbols in Ruby >= 1.9 So this was not actually testing anything
* | accept a block in button helper.Yuki Nishijima2012-06-051-1/+5
| |
* | Allow to use mounted helpers in ActionView::TestCasePiotr Sarnacki2012-06-011-0/+19
| | | | | | | | | | Similarly to 6525002, this allows to use routes helpers for mounted helpers, but this time in ActionView::TestCase
* | Simplify link_to using content_tagCarlos Antonio da Silva2012-05-311-0/+20
| | | | | | | | Add some tests for link_to with blocks and escaping content.
* | accept a block in button_to helperSergey Nartimov2012-05-301-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make possible to use a block in button_to helper if button text is hard to fit into the name parameter, e.g.: <%= button_to [:make_happy, @user] do %> Make happy <strong><%= @user.name %></strong> <% end %> # => "<form method="post" action="/users/1/make_happy" class="button_to"> # <div> # <button type="submit"> # Make happy <strong>Name</strong> # </button> # </div> # </form>"
* | Moving NumberHelpers from ActionView to ActiveSupportAndrew Mutz2012-05-271-0/+11
| |
* | Add `:escape` option for `truncate`Rafael Mendonça França2012-05-261-0/+19
| | | | | | | | This options can be used to not escape the result by default.
* | Test that the block used in truncate is escaped if it is not HTML safeRafael Mendonça França2012-05-261-12/+11
| | | | | | | | Refactoring the truncate method to not do a sort-circuit return
* | Truncate now has the ability to receive a html option that allows it to call ↵Li Ellis Gallardo2012-05-261-8/+29
| | | | | | | | | | | | | | | | | | | | | | | | rails helpers. This way if my text is long I don't have to do something like this: .text = truncate(@text, :length => 27) if @text.size >= 27 = link_to "continue", notes_path, ....."")
* | Add tests for time_field and date_field helpersCarlos Galdino2012-05-221-0/+18
| | | | | | | | These tests check the values of 'min' and 'max' input attrs
* | Merge pull request #6359 from carlosgaldino/add-html5-inputsJeremy Kemper2012-05-222-0/+178
|\ \ | | | | | | Add HTML5 color and date/time inputs
| * | Add several HTML5 input helpersCarlos Galdino2012-05-212-0/+160
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The input types added are: - input[type="month"] - input[type="week"] - input[type="datetime"] - input[type="datetime-local"]
| * | Add HTML5 input[type="color"] helperCarlos Galdino2012-05-212-0/+18
| | |
* | | Fixed typo new_defautls -> new_defaults.Philip Arndt2012-05-231-3/+13
| |/ |/| | | | | | | * Added tests for 'else' case in ActionView::Helpers::TranslationHelper#wrap_translate_defaults * Also updated the testing syntax of translation.html_safe? asserts to provide better output upon failure.
* | Revert "Merge pull request #6425 from pinetops/resolver_concurrency_fix"José Valim2012-05-211-4/+4
| | | | | | | | | | This reverts commit 254c04286c5916ae7f91eb6e173b312e7a74e364, reversing changes made to 513a0525c24c2944630acfa465b22cd2f4601adf.
* | Merge pull request #6425 from pinetops/resolver_concurrency_fixAaron Patterson2012-05-211-4/+4
|\ \ | |/ |/| Resolver concurrency fix
| * Make the Resolver template cache threadsafe - closes #6404Tom Clarke2012-05-211-4/+4
| | | | | | | | | | | | | | | | | | The Template cache in the Resolver can be accessed by multiple threads similtaneously in multi-threaded environments. The cache is implemented using a Hash, which isn't threadsafe in all VMs (notably JRuby). This commit extracts the cache to a new Cache class and adds mutexes to prevent concurrent access.
* | Clarify grouped_options_for_select method API, add changelog entryCarlos Antonio da Silva2012-05-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Make the method API more clear by explicitly showing the expected arguments. This means that the options cannot be passed as second argument because we are not relying on extract_options! anymore, you are expected to give a selected key or `nil` if you want to pass options, as it is the last argument. Notice that this does not change the current method arguments contract available in 3.2, it just brings back the same functionality with the divider addition.
* | Merge pull request #6384 from ihid/tidy_text_helpersJeremy Kemper2012-05-181-0/+42
|\ \ | | | | | | Tidied and standardised text_helper implementations.
| * | Tidied and standardised text_helper implementations.Jeremy Walker2012-05-191-0/+42
| | |
* | | Fix build: can't convert Regexp to Stringkennyj2012-05-191-1/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 18:37:48 +0000