Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix a wrong assertion on url_helper_test, and refactor `html_safe` test to ↵ | Prem Sichanugrist | 2011-07-17 | 1 | -2/+6 |
| | | | | be in its method | ||||
* | Adds a test to check link_to with method & rel options | Josh | 2011-06-21 | 1 | -0/+7 |
| | |||||
* | Define ActiveSupport#to_param as to_str - closes #1663 | Andrew White | 2011-06-12 | 1 | -0/+8 |
| | |||||
* | Prepare the context in URLHelperTest so that there are no required ↵ | wycats | 2011-05-22 | 1 | -0/+2 |
| | | | | uninitialized instance variables | ||||
* | Remove dependency from _template. | José Valim | 2011-05-01 | 1 | -1/+1 |
| | |||||
* | Be sure to javascript_escape the email address to prevent apostrophes ↵ | Michael Koziarski | 2011-02-08 | 1 | -4/+5 |
| | | | | | | inadvertently causing javascript errors. This fixes CVE-2011-0446 | ||||
* | add test to check class is being escaped in form_class | Santiago Pastorino | 2011-02-01 | 1 | -0/+4 |
| | |||||
* | Allow customization of form class for button_to | Andrei Bocan | 2011-02-01 | 1 | -0/+4 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Make sure capture's output gets html_escaped [#5545 state:resolved] | Jeff Kreeftmeijer | 2010-11-02 | 1 | -6/+1 |
| | | | | | | | Also remove a duplicate test_link_to_unless assertion and add .html_safe to the remaining one. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Allow generated url helpers to be overriden [#5243 state:resolved] | Andrew White | 2010-10-26 | 1 | -0/+18 |
| | |||||
* | data-disable-with in button_to helper | Paco Guzman | 2010-10-11 | 1 | -0/+21 |
| | | | | | | [#4993 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Clean up unused methods from AV::Base and pass in the template object on ↵ | José Valim | 2010-10-10 | 1 | -1/+1 |
| | | | | rendering. | ||||
* | delete repeated code | Aaron Patterson | 2010-10-01 | 1 | -18/+0 |
| | |||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -3/+2 |
| | |||||
* | Removing unnecessary code | Thiago Pradi | 2010-09-02 | 1 | -7/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -2/+2 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | These tests are trusting in the order of the elements so use OrderedHash ↵ | Santiago Pastorino | 2010-07-21 | 1 | -13/+9 |
| | | | | instead of Hash | ||||
* | Refactor recall parameter normalization [#5021 state:resolved] | Andrew White | 2010-07-03 | 1 | -2/+27 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | We are trying to test that & escapes here not that & is being escaped, ↵ | Santiago Pastorino | 2010-06-29 | 1 | -3/+2 |
| | | | | | | also added a cosmetic change to test_link_tag_with_query_and_no_name Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | s/escape_once/html_escape/, since html safety is the contract that now says ↵ | Xavier Noria | 2010-06-30 | 1 | -2/+2 |
| | | | | whether something has to be escaped | ||||
* | url_for no longer escapes HTML, the :escape option is also gone | Xavier Noria | 2010-06-30 | 1 | -16/+4 |
| | | | | Rationale: url_for is just a path/URL generator, it is the responsability of the caller to escape conveniently HTML needs it, JavaScript needs different escaping, a text mail needs no escaping at all, etc. | ||||
* | Restores the escaping of urls generated from hashes. [#4765 state:resolved] | Andrew White | 2010-06-28 | 1 | -8/+4 |
| | | | | | | | | | | | | | | HTML specifications recommend the escaping of urls in web pages, which url_for does by default for string urls and consquently urls generated by path helpers as these return strings. Hashes passed to url_for are not escaped by default and this commit reverses this default so that they are escaped. Undoes the changes of this commit: http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944 Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Normalize recall params when the route is not a standard route otherwise ↵ | Andrew White | 2010-06-27 | 1 | -0/+22 |
| | | | | | | :controller and :action may appear in the generated url [#4326 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Allow :remote => false to be passed to link_to | Nicolas Sanguinetti | 2010-04-22 | 1 | -0/+14 |
| | | | | | | | And add tests for `button_to` and `form_tag` which currently behave as expected, so we avoid a regression. Signed-off-by: wycats <wycats@gmail.com> | ||||
* | params already has a setted controller and action here | Santiago Pastorino | 2010-04-21 | 1 | -1/+0 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | url_for now works with HashWithIndifferentAccess ht jay [#4391 state:committed] | Santiago Pastorino | 2010-04-21 | 1 | -0/+10 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | mail_to with :encode => :javascript now outputs safe html | Sam Elliott | 2010-04-16 | 1 | -2/+6 |
| | | | | Signed-off-by: Carl Lerche <carllerche@mac.com> | ||||
* | Consistently use lowercase instead of camelCase for all JS class names in Rails | David Heinemeier Hansson | 2010-04-08 | 1 | -10/+10 |
| | |||||
* | Refactored url_for in AV to have its own instances of the helpers instead of ↵ | wycats | 2010-04-03 | 1 | -215/+204 |
| | | | | proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win) | ||||
* | Fix link_to with block | Jeremy Kemper | 2010-03-15 | 1 | -4/+1 |
| | |||||
* | Get rid of the instance-level URL rewriter | wycats | 2010-03-09 | 1 | -2/+0 |
| | |||||
* | Reinstate default_url_options and remove url_options= writer | Jeremy Kemper | 2010-03-08 | 1 | -1/+1 |
| | |||||
* | Start refactoring the method of configuring ActionView | Carlhuda | 2010-03-03 | 1 | -7/+2 |
| | |||||
* | Fix tests for the request refactor | Carl Lerche | 2010-03-03 | 1 | -18/+34 |
| | |||||
* | Tweak the semantic of various URL related methods of ActionDispatch::Request | Carlhuda | 2010-03-03 | 1 | -3/+0 |
| | |||||
* | Silence test deprecation warnings | Carlhuda | 2010-02-26 | 1 | -1/+1 |
| | |||||
* | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 1 | -18/+18 |
| | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | ||||
* | content_tag should escape its input | Bruno Michel | 2010-02-14 | 1 | -1/+1 |
| | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | data-remote needs to be on the form and not the submit when using button_to ↵ | Erik St. Martin | 2010-01-31 | 1 | -0/+7 |
| | | | | :remote=>true | ||||
* | Add rel=nofollow on non get remote links | Joshua Peek | 2010-01-30 | 1 | -2/+2 |
| | |||||
* | updating link_to and button_to to support :remote => true and other options ↵ | Erik St. Martin | 2010-01-30 | 1 | -9/+16 |
| | | | | | | such as :confirm in a unobtrusive manor Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Revert "Merge branch 'rails/master' into ujs" | Joshua Peek | 2010-01-30 | 1 | -9/+9 |
| | | | | | | | | | | | This reverts commit 3aa1ea1ae4baa4a03d03644e798eeb98a4745785, reversing changes made to 2c12a71378d2146c822acb389b00b866f6420ff5. Conflicts: actionpack/lib/action_view/helpers/javascript_helper.rb actionpack/lib/action_view/helpers/url_helper.rb actionpack/test/template/url_helper_test.rb | ||||
* | Deprecate link_to :popup | Joshua Peek | 2010-01-29 | 1 | -30/+0 |
| | |||||
* | modified helper that adds attributes for :method to include rel='nofollow' ↵ | Erik St. Martin | 2010-01-27 | 1 | -3/+3 |
| | | | | if :method => :delete, same as its remote_ equivalent | ||||
* | making non remote versions of link_to, button_to, submit_tag and ↵ | Erik St. Martin | 2010-01-27 | 1 | -14/+14 |
| | | | | image_submit_tag output data attributes for things like :confirm, :method, :popup, and :disable_with | ||||
* | Use new routing dsl in tests | Joshua Peek | 2009-12-08 | 1 | -4/+4 |
| | |||||
* | Privatize Routing.possible_controllers and fix brittle url helper | Joshua Peek | 2009-11-23 | 1 | -26/+19 |
| | | | | controller test loading. | ||||
* | Fix brittle query string comparisons | Joshua Peek | 2009-10-19 | 1 | -6/+13 |
| | |||||
* | Make sure non-escaped urls aren't considered safe | Michael Koziarski | 2009-10-15 | 1 | -0/+5 |
| | |||||
* | ActionView.url_for doesn't escape by default | Phil Darnowsky | 2009-10-15 | 1 | -3/+13 |
| | | | | | | | | | | | | | | | | | ActionView::Helpers::UrlHelper#url_for used to escape the URLs it generated by default. This was most commonly seen when generating a path with multiple query parameters, e.g. url_for(:controller => :foo, :action => :bar, :this => 123, :that => 456) would return http://example.com/foo/bar?that=456&this=123 escaping an ampersand that shouldn't be escaped. This is both wrong and inconsistent with the behavior of ActionController#url_for, and is changed. Signed-off-by: Michael Koziarski <michael@koziarski.com> |