Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't use `html_escape` to test the escaping | Rafael Mendonça França | 2012-08-05 | 1 | -1/+1 |
| | |||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | load active_support/core_ext/object/inclusion in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | html_escape should escape single quotes | Santiago Pastorino | 2012-07-31 | 1 | -1/+1 |
| | | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215 | ||||
* | Add one more test case to make sure that data attributes are being | Rafael Mendonça França | 2012-07-22 | 1 | -0/+7 |
| | | | | escaped | ||||
* | don't escape options in option_html_attributes method | Vasiliy Ermolovich | 2012-07-22 | 1 | -7/+14 |
| | | | | | | | | we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options | ||||
* | Clarify grouped_options_for_select method API, add changelog entry | Carlos Antonio da Silva | 2012-05-19 | 1 | -2/+2 |
| | | | | | | | | | | | | Make the method API more clear by explicitly showing the expected arguments. This means that the options cannot be passed as second argument because we are not relying on extract_options! anymore, you are expected to give a selected key or `nil` if you want to pass options, as it is the last argument. Notice that this does not change the current method arguments contract available in 3.2, it just brings back the same functionality with the divider addition. | ||||
* | Make :prompt work as documented | Rafael Mendonça França | 2012-05-16 | 1 | -0/+7 |
| | |||||
* | Test deprecation and fix the documentation of grouped_options_for_select | Rafael Mendonça França | 2012-05-16 | 1 | -2/+2 |
| | |||||
* | Add separator argument to grouped_options_for_select | Greenie0506 | 2012-05-15 | 1 | -2/+27 |
| | | | | Change prompt to options hash in grouped_options_for_select | ||||
* | Do not add `:include_blank` option if prompt is present | Rafael Mendonça França | 2012-05-13 | 1 | -0/+7 |
| | |||||
* | Only set `:include_blank` if the value of this options is not present | Rafael Mendonça França | 2012-05-13 | 1 | -0/+6 |
| | |||||
* | `:include_blank` should be true if the size option is nil | Rafael Mendonça França | 2012-05-13 | 1 | -14/+22 |
| | |||||
* | Always include the options :include_blank if the select has a required attribute | angelo giovanni capilleri | 2012-05-13 | 1 | -0/+21 |
| | | | | and display size 1 and not multiple attribute, Fixes #5908 | ||||
* | add 'include_hidden' option to select tag, closes #5402 | Vasiliy Ermolovich | 2012-03-13 | 1 | -0/+8 |
| | |||||
* | fix output safety issue with select options | Sergey Nartimov | 2012-02-20 | 1 | -1/+8 |
| | |||||
* | refactor options_for_select | Vasiliy Ermolovich | 2012-02-20 | 1 | -16/+16 |
| | |||||
* | add selected and disabled option to grouped select | Vasiliy Ermolovich | 2012-02-18 | 1 | -0/+18 |
| | |||||
* | Allow proc for value/text method in collection_select | Carlos Antonio da Silva | 2012-02-02 | 1 | -10/+42 |
| | | | | | | And options_from_collection_for_select as well. [Carlos Antonio da Silva + Rafael Mendonça França] | ||||
* | Fix inconsistent ability to use a range as choices for select_tag. | Jeremy Walker | 2012-01-21 | 1 | -0/+16 |
| | |||||
* | Ensure option for select helper responds to `#first` before comparison. | Brian Rose | 2011-12-20 | 1 | -0/+18 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | properly handle lists of lists. Thanks @adrianpike for reporting! | Aaron Patterson | 2011-10-25 | 1 | -0/+9 |
| | |||||
* | just check to see that the first item in the list is an array | Aaron Patterson | 2011-10-07 | 1 | -0/+9 |
| | |||||
* | Grouped select helper | Andrew Radev | 2011-07-11 | 1 | -0/+36 |
| | | | | FormBuilder#select now works with a nested data structure. | ||||
* | Fixed ActionView::FormOptionsHelper#select with :multiple => false | Bogdan Gusiev | 2011-06-30 | 1 | -0/+7 |
| | |||||
* | Fixing select[multiple] html specification problem. | Bogdan Gusiev | 2011-06-08 | 1 | -2/+18 |
| | | | | Generating hidden input with same name before each multiple select | ||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | added failing test for fields_for with a record object that inherits from Hash | Diego Carrion | 2011-03-06 | 1 | -0/+19 |
| | | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | ||||
* | Improve select helpers by allowing a selected value of false. This is ↵ | John Allison | 2011-01-09 | 1 | -8/+24 |
| | | | | useful when using a select helper with a boolean attribute, and the attribute is false. (e.g. f.select :allow_comments) | ||||
* | select tags coerce the :selected option, options to strings before ↵ | Subba Rao Pasupuleti | 2010-08-15 | 1 | -0/+62 |
| | | | | | | comparison [#5056 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Making time_zone_options_for_select return a html_safe string | Mikel Lindsaar | 2010-08-15 | 1 | -0/+4 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -6/+6 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | select :include_blank or :prompt should return escaped string [#5099 ↵ | Ivan Torres | 2010-07-18 | 1 | -0/+23 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | option_groups_from_collection_for_select should return HTML-safe string ↵ | Wincent Colaiuta | 2010-06-19 | 1 | -18/+12 |
| | | | | | | [#4879 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | added support for html attributes in options_for_select [#2165] | pleax | 2010-05-16 | 1 | -0/+56 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Mark the result of grouped_options_for_select as HTML safe [#4322 ↵ | Kieran Pilkington | 2010-04-16 | 1 | -0/+4 |
| | | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Make form helpers work with <%= | wycats | 2010-03-09 | 1 | -11/+11 |
| | |||||
* | Restore split between require-time and runtime load path mungery. Simplifies ↵ | Jeremy Kemper | 2009-09-24 | 1 | -1/+1 |
| | | | | vendor requires. | ||||
* | Rollback AS bundler work and improve activation of vendored dependencies | Joshua Peek | 2009-09-13 | 1 | -1/+1 |
| | |||||
* | Introduce grouped_collection_select helper. | codeape | 2009-08-09 | 1 | -0/+34 |
| | | | | | | [#1249 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Allow strings to be sent as collection to select. | José Valim | 2009-05-15 | 1 | -0/+22 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Enhanced form option helpers to add support for disabled option tags and use ↵ | Tekin Suleyman | 2009-02-14 | 1 | -0/+84 |
| | | | | | | of anonymous functions for specifying selected and disabled values from collections. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | DRY up form option helper tests | Tekin Suleyman | 2009-02-14 | 1 | -78/+19 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha. | Jeremy Kemper | 2009-02-03 | 1 | -600/+598 |
| | |||||
* | Added grouped_options_for_select helper method for wrapping option tags in ↵ | Jon Crawford | 2009-01-29 | 1 | -0/+26 |
| | | | | | | optgroups. [#977 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure selected option is not ignored for collection_select. [#1037 ↵ | Daniel Rodríguez Troitiño | 2009-01-28 | 1 | -0/+16 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix dangling tzinfo dependency | Jeremy Kemper | 2008-11-23 | 1 | -1/+2 |
| | |||||
* | moving country helpers from form_options_helper to form_country_helper again | Sven Fuchs | 2008-07-16 | 1 | -1539/+0 |
| |