Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #9616 from exviva/multiple_select_name_double_square_brackets | Carlos Antonio da Silva | 2013-03-12 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | Fix incorrectly appended square brackets to a multiple select box Before: select(:category, [], {}, {:multiple => true, :name => "post[category][]"}) # => <select name="post[category][][]" ...> After: select(:category, [], {}, {:multiple => true, :name => "post[category][]"}) # => <select name="post[category][]" ...> Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/tags/base.rb actionpack/test/template/form_options_helper_test.rb | ||||
* | html_escape should escape single quotes | Santiago Pastorino | 2012-08-02 | 1 | -3/+3 |
| | | | | | | | | | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215 Conflicts: actionpack/test/template/erb_util_test.rb actionpack/test/template/form_tag_helper_test.rb actionpack/test/template/text_helper_test.rb actionpack/test/template/url_helper_test.rb activesupport/lib/active_support/core_ext/string/output_safety.rb | ||||
* | Build fix for ruby1.8.7-358 | Arun Agrawal | 2012-03-19 | 1 | -8/+6 |
| | |||||
* | fix output safety issue with select options | Sergey Nartimov | 2012-02-20 | 1 | -1/+8 |
| | |||||
* | Allow form.select to accept ranges. | Jeremy Walker | 2012-01-22 | 1 | -0/+16 |
| | |||||
* | Ensure option for select helper responds to `#first` before comparison. | Brian Rose | 2011-12-20 | 1 | -0/+18 |
| | |||||
* | properly handle lists of lists. Thanks @adrianpike for reporting! | Aaron Patterson | 2011-10-25 | 1 | -0/+9 |
| | |||||
* | just check to see that the first item in the list is an array | Aaron Patterson | 2011-10-07 | 1 | -0/+9 |
| | |||||
* | Grouped select helper | Andrew Radev | 2011-07-11 | 1 | -0/+36 |
| | | | | FormBuilder#select now works with a nested data structure. | ||||
* | Fixed ActionView::FormOptionsHelper#select with :multiple => false | Bogdan Gusiev | 2011-06-30 | 1 | -0/+7 |
| | |||||
* | Fixing select[multiple] html specification problem. | Bogdan Gusiev | 2011-06-08 | 1 | -2/+18 |
| | | | | Generating hidden input with same name before each multiple select | ||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | added failing test for fields_for with a record object that inherits from Hash | Diego Carrion | 2011-03-06 | 1 | -0/+19 |
| | | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | ||||
* | Improve select helpers by allowing a selected value of false. This is ↵ | John Allison | 2011-01-09 | 1 | -8/+24 |
| | | | | useful when using a select helper with a boolean attribute, and the attribute is false. (e.g. f.select :allow_comments) | ||||
* | select tags coerce the :selected option, options to strings before ↵ | Subba Rao Pasupuleti | 2010-08-15 | 1 | -0/+62 |
| | | | | | | comparison [#5056 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Making time_zone_options_for_select return a html_safe string | Mikel Lindsaar | 2010-08-15 | 1 | -0/+4 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -6/+6 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | select :include_blank or :prompt should return escaped string [#5099 ↵ | Ivan Torres | 2010-07-18 | 1 | -0/+23 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | option_groups_from_collection_for_select should return HTML-safe string ↵ | Wincent Colaiuta | 2010-06-19 | 1 | -18/+12 |
| | | | | | | [#4879 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | added support for html attributes in options_for_select [#2165] | pleax | 2010-05-16 | 1 | -0/+56 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Mark the result of grouped_options_for_select as HTML safe [#4322 ↵ | Kieran Pilkington | 2010-04-16 | 1 | -0/+4 |
| | | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Make form helpers work with <%= | wycats | 2010-03-09 | 1 | -11/+11 |
| | |||||
* | Restore split between require-time and runtime load path mungery. Simplifies ↵ | Jeremy Kemper | 2009-09-24 | 1 | -1/+1 |
| | | | | vendor requires. | ||||
* | Rollback AS bundler work and improve activation of vendored dependencies | Joshua Peek | 2009-09-13 | 1 | -1/+1 |
| | |||||
* | Introduce grouped_collection_select helper. | codeape | 2009-08-09 | 1 | -0/+34 |
| | | | | | | [#1249 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Allow strings to be sent as collection to select. | José Valim | 2009-05-15 | 1 | -0/+22 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Enhanced form option helpers to add support for disabled option tags and use ↵ | Tekin Suleyman | 2009-02-14 | 1 | -0/+84 |
| | | | | | | of anonymous functions for specifying selected and disabled values from collections. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | DRY up form option helper tests | Tekin Suleyman | 2009-02-14 | 1 | -78/+19 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha. | Jeremy Kemper | 2009-02-03 | 1 | -600/+598 |
| | |||||
* | Added grouped_options_for_select helper method for wrapping option tags in ↵ | Jon Crawford | 2009-01-29 | 1 | -0/+26 |
| | | | | | | optgroups. [#977 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure selected option is not ignored for collection_select. [#1037 ↵ | Daniel Rodríguez Troitiño | 2009-01-28 | 1 | -0/+16 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix dangling tzinfo dependency | Jeremy Kemper | 2008-11-23 | 1 | -1/+2 |
| | |||||
* | moving country helpers from form_options_helper to form_country_helper again | Sven Fuchs | 2008-07-16 | 1 | -1539/+0 |
| | |||||
* | Ensure :index works with fields_for select methods. [#518 state:resolved] | rsl | 2008-07-14 | 1 | -0/+885 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | use mocha for TimeZone mocking in Form Options helper tests | rick | 2008-07-02 | 1 | -504/+495 |
| | |||||
* | Added support for regexp matching of priority zones in time_zone_select ↵ | Ernie Miller | 2008-06-29 | 1 | -0/+18 |
| | | | | [#195 state:resolved] | ||||
* | Silence TimeZone warning | Pratik Naik | 2008-06-11 | 1 | -2/+2 |
| | |||||
* | Fix FormOptionsHelper tests. | Jan De Poorter | 2008-06-11 | 1 | -5/+5 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Use output_buffer reader and writer methods exclusively instead of hitting ↵ | Jeremy Kemper | 2008-06-08 | 1 | -15/+9 |
| | | | | the instance variable so others can override the methods. | ||||
* | Work with @output_buffer instead of _erbout | Jeremy Kemper | 2008-06-02 | 1 | -9/+9 |
| | |||||
* | Introduce ActionView::TestCase for testing view helpers. | Joshua Peek | 2008-04-19 | 1 | -3/+2 |
| | |||||
* | Docfixes (closes #11356, #11172, #10523) | David Heinemeier Hansson | 2008-03-20 | 1 | -0/+13 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ruby 1.9 compat: account for hash ordering | Jeremy Kemper | 2008-01-07 | 1 | -4/+3 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | require abstract_unit directly since test is in load path | Jeremy Kemper | 2008-01-05 | 1 | -1/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Add :default option to time_zone_select. Closes #10590. | Jeremy Kemper | 2007-12-21 | 1 | -0/+28 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ruby 1.9 compat: note failing form options helper test, probably in html-scanner | Jeremy Kemper | 2007-12-21 | 1 | -0/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Remove Great Britain from the Country select helper to ensure consistency ↵ | Michael Koziarski | 2007-12-05 | 1 | -3/+0 |
| | | | | | | with iso 3166's long_names. Closes #6872 [Koz] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Add 'disabled' attribute to <OPTION> separators used in time zone and ↵ | Rick Olson | 2007-12-04 | 1 | -6/+6 |
| | | | | | | country selects. Closes #10354 [hasmanyjosh] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |