aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template/form_options_helper_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Revert grep to select since they are not the sameBrian McManus2013-03-271-3/+2
| | | | | | | | | | | | | | | | | A previous commit swapped out a call to select for a call to grep in time_zone_options_for_select. This behavior actually causes the regexp priority option to stop working. ActiveSupport::TimeZone overrides the =~ operator which is what the select block was using previously. Enumerable#grep checks pattern === element and in this case that would be /US/ === ActiveSupport::TimeZone which does not work because ActiveSupport::TimeZone does not supply an implicit converting to_str method, only an explicit to_s method. It would be impossible to provide a to_str method that behaves identically to the =~ method provided on ActiveSupport::TimeZone so the only option is to revert back to using select with =~.
* Fix incorrectly appended square brackets to a multiple select boxOlek Janiszewski2013-03-081-0/+8
| | | | | | | | | | | | | | If an explicit name has been given and it already ends with "[]" Before: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][][]" ...> After: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][]" ...>
* Use #grep to filter priority zones when a regexp is givenCarlos Antonio da Silva2013-02-211-2/+4
|
* Fix test name and refactor fake timezones creation in form options testCarlos Antonio da Silva2013-02-211-3/+3
|
* remove assigned but unused variable warningNihad Abbasov2013-02-211-2/+2
|
* Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-191-0/+7
| | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* No sort Hash options in #grouped_options_for_selectSergey Kojin2012-11-271-1/+1
|
* &#39 dates back to SGML when &#x27 was introduced in HTML 4.0Kalys Osmonov2012-09-091-1/+1
|
* Ensure option_html_attributes does not modify the given option hashesCarlos Antonio da Silva2012-08-111-0/+9
| | | | We can avoid creating extra hashes with #merge, and use #merge! instead.
* Simplify html attributes generation for options_for_selectCarlos Antonio da Silva2012-08-111-5/+6
| | | | | | | Further simplify the option_html_attributes method after the changes introduced in dacbcbe55745aa9e5484b10b11f65ccca7db1c54 to not escape the html options here (since they're going to be escaped down the chain in content tag).
* Don't use `html_escape` to test the escapingRafael Mendonça França2012-08-051-1/+1
|
* removes usage of Object#in? from the code base (the method remains defined ↵Xavier Noria2012-08-061-1/+1
| | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case.
* load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-021-1/+0
|
* html_escape should escape single quotesSantiago Pastorino2012-07-311-1/+1
| | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215
* Add one more test case to make sure that data attributes are beingRafael Mendonça França2012-07-221-0/+7
| | | | escaped
* don't escape options in option_html_attributes methodVasiliy Ermolovich2012-07-221-7/+14
| | | | | | | | we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options
* Clarify grouped_options_for_select method API, add changelog entryCarlos Antonio da Silva2012-05-191-2/+2
| | | | | | | | | | | | Make the method API more clear by explicitly showing the expected arguments. This means that the options cannot be passed as second argument because we are not relying on extract_options! anymore, you are expected to give a selected key or `nil` if you want to pass options, as it is the last argument. Notice that this does not change the current method arguments contract available in 3.2, it just brings back the same functionality with the divider addition.
* Make :prompt work as documentedRafael Mendonça França2012-05-161-0/+7
|
* Test deprecation and fix the documentation of grouped_options_for_selectRafael Mendonça França2012-05-161-2/+2
|
* Add separator argument to grouped_options_for_selectGreenie05062012-05-151-2/+27
| | | | Change prompt to options hash in grouped_options_for_select
* Do not add `:include_blank` option if prompt is presentRafael Mendonça França2012-05-131-0/+7
|
* Only set `:include_blank` if the value of this options is not presentRafael Mendonça França2012-05-131-0/+6
|
* `:include_blank` should be true if the size option is nilRafael Mendonça França2012-05-131-14/+22
|
* Always include the options :include_blank if the select has a required attributeangelo giovanni capilleri2012-05-131-0/+21
| | | | and display size 1 and not multiple attribute, Fixes #5908
* add 'include_hidden' option to select tag, closes #5402Vasiliy Ermolovich2012-03-131-0/+8
|
* fix output safety issue with select optionsSergey Nartimov2012-02-201-1/+8
|
* refactor options_for_selectVasiliy Ermolovich2012-02-201-16/+16
|
* add selected and disabled option to grouped selectVasiliy Ermolovich2012-02-181-0/+18
|
* Allow proc for value/text method in collection_selectCarlos Antonio da Silva2012-02-021-10/+42
| | | | | | And options_from_collection_for_select as well. [Carlos Antonio da Silva + Rafael Mendonça França]
* Fix inconsistent ability to use a range as choices for select_tag.Jeremy Walker2012-01-211-0/+16
|
* Ensure option for select helper responds to `#first` before comparison.Brian Rose2011-12-201-0/+18
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* properly handle lists of lists. Thanks @adrianpike for reporting!Aaron Patterson2011-10-251-0/+9
|
* just check to see that the first item in the list is an arrayAaron Patterson2011-10-071-0/+9
|
* Grouped select helperAndrew Radev2011-07-111-0/+36
| | | | FormBuilder#select now works with a nested data structure.
* Fixed ActionView::FormOptionsHelper#select with :multiple => falseBogdan Gusiev2011-06-301-0/+7
|
* Fixing select[multiple] html specification problem.Bogdan Gusiev2011-06-081-2/+18
| | | | Generating hidden input with same name before each multiple select
* Remove `#among?` from Active SupportPrem Sichanugrist2011-04-131-1/+1
| | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
* Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵David Heinemeier Hansson2011-04-121-1/+1
| | | | suggestion!
* Using Object#in? and Object#either? in various placesPrem Sichanugrist2011-04-111-1/+2
| | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
* added failing test for fields_for with a record object that inherits from HashDiego Carrion2011-03-061-0/+19
| | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
* Improve select helpers by allowing a selected value of false. This is ↵John Allison2011-01-091-8/+24
| | | | useful when using a select helper with a boolean attribute, and the attribute is false. (e.g. f.select :allow_comments)
* select tags coerce the :selected option, options to strings before ↵Subba Rao Pasupuleti2010-08-151-0/+62
| | | | | | comparison [#5056 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Making time_zone_options_for_select return a html_safe stringMikel Lindsaar2010-08-151-0/+4
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-6/+6
| | | | 's/[ \t]*$//' -i {} \;)
* select :include_blank or :prompt should return escaped string [#5099 ↵Ivan Torres2010-07-181-0/+23
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* option_groups_from_collection_for_select should return HTML-safe string ↵Wincent Colaiuta2010-06-191-18/+12
| | | | | | [#4879 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com>
* added support for html attributes in options_for_select [#2165]pleax2010-05-161-0/+56
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Mark the result of grouped_options_for_select as HTML safe [#4322 ↵Kieran Pilkington2010-04-161-0/+4
| | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com>
* Make form helpers work with <%= wycats2010-03-091-11/+11
|
* Restore split between require-time and runtime load path mungery. Simplifies ↵Jeremy Kemper2009-09-241-1/+1
| | | | vendor requires.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 22:02:19 +0000