aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template/form_helper_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* No need to use </form> here. It's already in whole_form blockArun Agrawal2011-09-101-2/+1
|
* Rename new method to_path to to_partial_path to avoid conflicts with ↵José Valim2011-08-011-1/+1
| | | | File#to_path and similar.
* Merge pull request #2034 from Casecommons/to_pathJosé Valim2011-07-281-0/+11
|\ | | | | Allow ActiveModel-compatible instances to define their own partial paths
| * Let ActiveModel instances define partial paths.Grant Hutchins & Peter Jaros2011-07-251-0/+11
| | | | | | | | | | | | Deprecate ActiveModel::Name#partial_path. Now you should call #to_path directly on ActiveModel instances.
* | added test case for fix to issue #2094Dan Gebhardt2011-07-161-0/+17
|/
* Revert "Add method fields_for_with_index to FormHelper"José Valim2011-07-011-125/+0
| | | | | | | | This reverts commit 7c562d5e460d97b18e4f3367b3cfb13401732920. Conflicts: actionpack/lib/action_view/helpers/form_helper.rb
* Use real hash model in nested fields_for with hash model testSam Pohlenz2011-06-221-4/+2
|
* Test for extractable_options? within nested fields_for.Sam Pohlenz2011-06-201-0/+18
| | | | | This fixes an error when a record object that is a subclass of Hash is passed to fields_for, which is incorrectly interpreted as field options.
* There are no snowmen hereDavid Lee2011-06-111-2/+2
|
* Added missing assert to test checking form with namespaced isolated model ↵Piotr Sarnacki2011-06-071-5/+5
| | | | and fixed helpers to work correctly in such case
* Add method fields_for_with_index to FormHelperJorge Bejar2011-05-211-0/+125
|
* Refactor fields_for to make the api more clear, and fix usage with non ↵Carlos Antonio da Silva2011-05-141-0/+14
| | | | nested attributes and without object
* Allow a label with the value option to have value-specific translations.Jason Garber2011-04-271-1/+11
|
* Remove `#among?` from Active SupportPrem Sichanugrist2011-04-131-1/+1
| | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
* Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵David Heinemeier Hansson2011-04-121-1/+1
| | | | suggestion!
* Using Object#in? and Object#either? in various placesPrem Sichanugrist2011-04-111-1/+2
| | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
* Allow FormHelper#form_for to specify the :method as a direct option instead ↵David Heinemeier Hansson2011-03-261-2/+19
| | | | of through the :html hash [DHH]
* Add an option to FormBuilder to omit hidden field with idAlexander Uvarov2011-03-041-0/+135
| | | | | | [#4551 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove duplicated action pack tests added to fix issue with fields_for, ↵Carlos Antonio da Silva2011-02-121-42/+0
| | | | | | nested attributes and erb Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add tests showing the LH issue #6381: fields_for with inline blocks and ↵Carlos Antonio da Silva2011-02-081-1/+85
| | | | | | nested attributes already persisted Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* removing generation of id in submit helperFranco Brusatti2011-02-031-6/+6
| | | | | | [#6369 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Revert "Remove deprecated form_for with strings or symbols"José Valim2010-11-181-0/+33
| | | | | | | | | | | | | | | | This code was not deprecated. What was deprecated is the following: form_for(:foo, @foo) Which now should be rewritten as: form_for(@foo, :as => :foo) The following format is valid: form_for(:foo) This reverts commit be797750e6ce866ea08307f63bf35304a965c8d4.
* Remove deprecated form_for with strings or symbolsLeonardo Capillera2010-11-181-33/+0
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* fields_for should treat ActiveRecord::Relation as an arrayNeeraj Singh2010-11-111-0/+21
| | | | | | [#5795 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix test helpers to ensure get method forms are properly tested [#5753 ↵Aditya Sanghi2010-10-121-6/+9
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Make InstanceTagMethods#value_before_type_cast raise if the model ↵Santiago Pastorino2010-10-101-30/+0
| | | | | | | | don't respond to attr_before_type_cast or attr method" And "Makes form_helper use overriden model accessors" This reverts commit 3ba8e3100548f10fce0c9784981a4589531476dd and fb0bd8c1092db51888ec4bb72af6c595e13c31fa.
* added test for form_for with search_fieldAditya Sanghi2010-10-021-0/+15
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Rename duplicated test, and give it a correct name. Remove nonsense line.Emilio Tagua2010-09-281-2/+1
|
* Remove last tests with deprecated form_for and cleanup form_for helperCarlos Antonio da Silva2010-09-261-63/+49
| | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before.
* Review most of the form_for deprecated tests, missing tests with index like []Carlos Antonio da Silva2010-09-261-405/+321
|
* file_field propagates up multipart property even inside of fields_forSantiago Pastorino2010-09-201-0/+21
|
* argument error is done for usAaron Patterson2010-09-181-0/+6
|
* file_field makes the enclosing form multipartSantiago Pastorino2010-09-181-0/+18
|
* Remove namespace for isolated namespaced models in formsPiotr Sarnacki2010-09-031-0/+17
|
* Extended url_for to handle specifying which router should be used.Piotr Sarnacki2010-09-031-50/+40
| | | | | | | A few examples: url_for Blog::Engine, :posts_path url_for Blog::Engine, @post url_for Blog::Engine, :action => "main", :controller => "index"
* Added :format option for form_for helper and spec for this [#5226 ↵Alex Chrome2010-09-011-2/+18
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* password_field renders with nil value by defaultSantiago Pastorino2010-08-281-1/+4
| | | | | | | | This makes the use of passwords secure by default if you want to render the value of the password_field you have to do for instance f.password_field(:password, :value => @user.password) # => <input type=password id=user_password name=user[password] value=#{@user.password} />
* Make InstanceTagMethods#value_before_type_cast raise if the model don't ↵Santiago Pastorino2010-08-271-0/+13
| | | | | | respond to attr_before_type_cast or attr method [#3374] [#5471 state:committed]
* Revert "It's snowing!"wycats2010-08-181-1/+1
| | | | This reverts commit e4283007d607454acf97301821ba1e1c417bdead.
* It's snowing!Jeremy Kemper2010-08-121-1/+1
|
* Replace snowman with utf8=✓wycats2010-08-111-1/+1
|
* rename _snowman to _ewycats2010-08-091-1/+1
|
* Fix label form helper to use I18n and html options, without the need of ↵Carlos Antonio da Silva2010-08-011-2/+9
| | | | | | | | | | | 'nil' text param: Before: f.label :title, nil, :class => 'title' After : f.label :title, :class => 'title' [#5267 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Makes form_helper use overriden model accessorsSantiago Pastorino2010-08-011-0/+17
| | | | [#3374 state:committed]
* remove size attribute from tag generated by file_field helper [#5084 ↵Miles Egan2010-07-131-0/+5
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Rename _snowman_ to _snowman to be in sync with _method and _csrf_token.José Valim2010-06-291-1/+1
|
* Fix several known web encoding issues:wycats2010-06-271-181/+204
| | | | | | | | | | | | | | | | | | | | | | | * Specify accept-charset on all forms. All recent browsers, as well as IE5+, will use the encoding specified for form parameters * Unfortunately, IE5+ will not look at accept-charset unless at least one character in the form's values is not in the page's charset. Since the user can override the default charset (which Rails sets to UTF-8), we provide a hidden input containing a unicode character, forcing IE to look at the accept-charset. * Now that the vast majority of web input is UTF-8, we set the inbound parameters to UTF-8. This will eliminate many cases of incompatible encodings between ASCII-8BIT and UTF-8. * You can safely ignore params[:_snowman_] TODO: * Validate inbound text to confirm it is UTF-8 * Combine the whole_form implementations in form_helper_test and form_tag_helper_test
* make text_field and hidden_field omit the value attribute if the developer ↵Jeff Dean2010-06-231-0/+10
| | | | | | explicitly passes in :value => nil [#4839 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com>
* test for #4862Neeraj Singh2010-06-221-0/+5
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* form_for without :html and with :remote should not errorDavid Genord II2010-06-181-0/+20
| | | | | | [#4902 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>