| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
When you have an explicit index set, then when you build an input tag
with :multiple => true, it doesn't add [] to the end of its name, although
it should.
|
|
|
|
| |
there is a chance that `value` is a Set or an object that reponses to `include?` method so let's handle this case
|
|
|
|
|
| |
Instead of building a Blog::Post instance for every test in form helper
tests, just build it in the test that uses it.
|
|
|
|
| |
if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem.
|
|
|
|
| |
can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH*
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by Active Support)
Selecting which key extensions to include in active_support/rails
made apparent the systematic usage of Object#in? in the code base.
After some discussion in
https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d
we decided to remove it and use plain Ruby, which seems enough
for this particular idiom.
In this commit the refactor has been made case by case. Sometimes
include? is the natural alternative, others a simple || is the
way you actually spell the condition in your head, others a case
statement seems more appropriate. I have chosen the one I liked
the most in each case.
|
| |
|
|
|
|
|
| |
Module#instance_methods returns an Array of Symbols in Ruby >= 1.9
So this was not actually testing anything
|
| |
|
|
|
|
| |
These tests check the values of 'min' and 'max' input attrs
|
|
|
|
|
|
|
|
|
|
|
|
| |
The input types added are:
- input[type="month"]
- input[type="week"]
- input[type="datetime"]
- input[type="datetime-local"]
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This fixes:
* Boolean with inverted logic
* Integer with inverted logic
* BigDecimal with inverted logic
Fixes #3995
|
|
|
|
| |
closes #3341
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the current router DSL, using the +match+ DSL
method will match all verbs for the path to the
specified endpoint.
In the vast majority of cases, people are
currently using +match+ when they actually mean
+get+. This introduces security implications.
This commit disallows calling +match+ without
an HTTP verb constraint by default. To explicitly
match all verbs, this commit also adds a
:via => :all option to +match+.
Closes #5964
|
|
|
|
| |
know the index number into the iteration.
|
| |
|
|
|
|
|
|
| |
hash.
Closes #2492 and #5615
|
|
|
|
|
|
|
|
| |
doesn't call for label.
objectify_options method should be applied to the proper options arg.
See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example
|
|
|
|
| |
Commit: 7a0cf2f5294e8bcef547642435636b394340a3e4
|
|\
| |
| | |
Properly deprecate the block argument in AV FormBuilder
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Commit 56089ca986c767763f29159c8de0aa1ebabfd4d2 introduced a backward
incompatible change by changing the method signature of the FormBuilder.
This brings back the same method signature warning in case someone gives
a block to the builder.
More info: https://github.com/rails/rails/commit/56089ca986c767763f29159c8de0aa1ebabfd4d2#commitcomment-1116166
|
|/ |
|
| |
|
|
|
|
| |
cols and rows options from textarea.
|
|
|
|
| |
Closes #393
|
|
|
|
| |
variables in the form builder
|
| |
|
|
|
|
| |
the update action of resources
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PATCH is the correct HTML verb to map to the #update action. The
semantics for PATCH allows for partial updates, whereas PUT requires a
complete replacement.
Changes:
* adds config.default_method_for_update you can set to :patch
* optionally use PATCH instead of PUT in resource routes and forms
* adds the #patch verb to routes to detect PATCH requests
* adds #patch? to Request
* changes documentation and comments to indicate support for PATCH
This change maintains complete backwards compatibility by keeping :put
as the default for config.default_method_for_update.
|
| |
|
|
|
|
|
| |
When the new html5 attribute :form is given to the check_box helper, it
should be replicated to the hidden field as well. Closes #4848
|
|
|
|
| |
[Carlos Antonio da Silva + Rafael Mendonça França]
|
| |
|
|
|
|
| |
ActionView::Helpers::Tags::Base child and do not implement the render method
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Fixed failing tests
This reverts commit 8350ce97f2065eed9638c595d3938a573d6fa343.
|
|
|
|
| |
fixes #1953
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This support is near-identical to the existing submit_tag support.
Example:
<%= form_for @post do |f| %>
<%= f.button %>
<% end %>
|
| |
|
| |
|
|
|
|
|
| |
You can provide a namespace for your form to ensure uniqueness of id attributes on form elements.
The namespace attribute will be prefixed with underscore on the generate HTML id
|
| |
|