aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template/form_helper_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Allow explicit placement of hidden id element for nested models.Will Read2009-11-151-11/+55
| | | | | | [#3259 state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
* Switch to on-by-default XSS escaping for rails.Michael Koziarski2009-10-081-1/+1
| | | | | | | | | | | | This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration.
* Moved shared form helper models into fake_modelsJoshua Peek2009-10-031-99/+1
|
* Allow fields_for on a nested_attributes association to accept an explicit ↵Andrew France2009-09-121-0/+36
| | | | | | collection to be used. [#2648 state:resolved] Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
* Fixed to_label_tag to accept id attribute without changing for attribute ↵Matt Duncan2009-08-091-0/+16
| | | | | | [#2660 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Allow radio buttons to work with booleans.José Valim2009-08-081-0/+10
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* AMo conversion helperJoshua Peek2009-07-211-5/+10
|
* Finish convert_to_object updatesYehuda Katz2009-07-201-0/+6
|
* Update some tests and add a to_model to form helpersYehuda Katz2009-07-201-5/+5
|
* Move default_form_builder to ActionView so it'll work in environments not ↵Yehuda Katz2009-07-191-3/+3
| | | | using ActionView::Base
* My suggestion to fix ticket 2401 [#2401 state:resolved]Jarl Friis2009-07-021-0/+92
| | | | Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
* Fixes a number of tests that inexplicably didn't fail when we committed the ↵Yehuda Katz + Carl Lerche2009-07-021-5/+5
| | | | original patch
* Use errors[field] instead of errors.on(field)Jeremy Kemper2009-06-171-2/+2
|
* Made label target radio button tags with values. Radio button now respects ↵David Stevenson2009-06-091-0/+19
| | | | | | inherited :index options when generating id. Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-131-43/+242
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * Pass a custom form builder on to nested fields_for calls. [#2023 ↵Eloy Duran2009-02-271-0/+41
| | | | | | | | | | | | status:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
| * Changed API of NestedAttributes to take an array, or hash with index keys, ↵Lance Ivy2009-02-131-8/+30
| | | | | | | | | | | | | | | | of hashes that have the id on the inside of the attributes hash and updated the FormBuilder to produce such hashes. Also fixed NestedAttributes with composite ids. Signed-off-by: Michael Koziarski <michael@koziarski.com> Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com> [#1892 state:committed]
| * Move checkbox hidden field before the actual checkbox so the actual value ↵Joshua Peek2009-02-101-38/+34
| | | | | | | | doesn't get clobbered [#1863 state:resolved]
| * Allowing an object to be passed explicitly to a fields_for with ↵Pascal Ehlert2009-02-061-0/+9
| | | | | | | | | | | | | | nested_attributes on one-to-one associations Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1849 state:committed]
| * Add support for nested object forms to ActiveRecord and the helpers in ↵Eloy Duran2009-02-011-5/+136
| | | | | | | | | | | | | | | | ActionPack Signed-Off-By: Michael Koziarski <michael@koziarski.com> [#1202 state:committed]
* | Temporarily modifies setup to call super directly. This can support more ↵Yehuda Katz and Carl Lerche2009-04-081-0/+1
|/ | | | T::U runners.
* Fix duplicate test name [#1058 state:resolved] [Dave Rothlisberger, Pratik Naik]Pratik Naik2008-12-201-1/+1
|
* Fixed index and auto index for nested fields_for [#327 state:resolved]Kevin Glowacz2008-07-191-3/+113
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Use output_buffer reader and writer methods exclusively instead of hitting ↵Jeremy Kemper2008-06-081-151/+100
| | | | the instance variable so others can override the methods.
* Work with @output_buffer instead of _erboutJeremy Kemper2008-06-021-130/+130
|
* Improve check_box_checked? to use include? for Array values. [#193 ↵Erkki Eilonen2008-05-211-0/+11
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixed form helper's name attribute for question methodsAndrew Vit2008-05-061-0/+9
|
* Fixed that TextHelper#text_field would corrypt when raw HTML was used as the ↵David Heinemeier Hansson2008-05-011-0/+16
| | | | value (mchenryc, Kevin Glowacz) [#80 state:resolved]
* Fixed labels that have a bracketed name and an index [#68 state:resolved]Kevin Glowacz2008-04-301-0/+12
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* FormHelper#label_tag accepts :for option [encoded] [#38 state:resolved]Joshua Peek2008-04-301-54/+62
|
* Introduce ActionView::TestCase for testing view helpers.Joshua Peek2008-04-191-9/+2
|
* Fixed that FormHelper#radio_button would produce invalid ids (closes #11298) ↵David Heinemeier Hansson2008-03-241-0/+3
| | | | | | [harlancrystal] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Introduce the :index option for form_for and fields_for to simplify ↵Jeremy Kemper2008-02-021-2/+76
| | | | | | multi-model forms (see http://railscasts.com/episodes/75). Closes #9883. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-051-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Deal with nested fields_for too [DHH]David Heinemeier Hansson2007-12-021-0/+22
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added the same record identification guessing rules to fields_for as ↵David Heinemeier Hansson2007-12-021-0/+17
| | | | | | form_for has [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Tested FormHelper#label. Closes #9850 [jarkko]Jeremy Kemper2007-10-271-1/+9
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* FormHelper's auto_index should use #to_param instead of ↵Rick Olson2007-10-261-1/+2
| | | | | | #id_before_type_cast. Closes #9994 [mattly] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Disabled checkboxes don't submit a form value. Closes #9301.Jeremy Kemper2007-10-231-0/+7
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* error_messages_for and friends also work with local variables. Closes #9699.Jeremy Kemper2007-10-071-0/+19
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allow ability to disable request forgery protection, disable it in test mode ↵Rick Olson2007-09-281-3/+3
| | | | | | by default. Closes #9693 [lifofifo] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Merge csrf_killer plugin into rails. Adds RequestForgeryProtection model ↵Rick Olson2007-09-231-0/+4
| | | | | | that verifies session-specific _tokens for non-GET requests. [Rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added FormHelper#label (closes #8641) [jcoglan]David Heinemeier Hansson2007-09-221-0/+15
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* * url_for now accepts a series of symbols representing the namespace of the ↵Tobias Lütke2007-07-191-0/+29
| | | | | | record [Josh Knowles]. Closes #8640 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improve helper test coverage. Closes #7215, #7233, #7234, #7235, #7236, ↵Jeremy Kemper2007-06-131-13/+29
| | | | | | #7237, #7238. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* More nested polymorphic url helper fixes. Closes #6432, references #8601.Jeremy Kemper2007-06-071-23/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix incomplete work from [6951] that was hidden by test stubs. Closes #6432.Jeremy Kemper2007-06-061-10/+18
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Resources: url_for([parent, child]) generates /parents/1/children/2 for the ↵Jeremy Kemper2007-06-051-4/+53
| | | | | | nested resource. Likewise with the other simply helpful methods like form_for and link_to. Closes #6432. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Remove junk form helper test. Closes #8416 [eric_oconnell]Jeremy Kemper2007-06-051-7/+0
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added option to suppress :size when using :maxlength for ↵David Heinemeier Hansson2007-05-241-0/+6
| | | | | | FormTagHelper#text_field #3112 [rails@tpope.info] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 06:09:11 +0000