Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Create variable only in the test that uses it | Carlos Antonio da Silva | 2012-08-25 | 1 | -3/+3 |
| | | | | | Instead of building a Blog::Post instance for every test in form helper tests, just build it in the test that uses it. | ||||
* | check for nil or empty record in form_for | schneems | 2012-08-10 | 1 | -0/+14 |
| | | | | if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem. | ||||
* | Allow data attributes to be set as a first-level option for form_for, so you ↵ | David Heinemeier Hansson | 2012-08-08 | 1 | -0/+6 |
| | | | | can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH* | ||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | load active_support/core_ext/object/inclusion in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | fix meaningless test case | Akira Matsuda | 2012-06-06 | 1 | -1/+1 |
| | | | | | Module#instance_methods returns an Array of Symbols in Ruby >= 1.9 So this was not actually testing anything | ||||
* | accept a block in button helper. | Yuki Nishijima | 2012-06-05 | 1 | -1/+5 |
| | |||||
* | Add tests for time_field and date_field helpers | Carlos Galdino | 2012-05-22 | 1 | -0/+18 |
| | | | | These tests check the values of 'min' and 'max' input attrs | ||||
* | Add several HTML5 input helpers | Carlos Galdino | 2012-05-21 | 1 | -0/+140 |
| | | | | | | | | | | | | The input types added are: - input[type="month"] - input[type="week"] - input[type="datetime"] - input[type="datetime-local"] | ||||
* | Add HTML5 input[type="color"] helper | Carlos Galdino | 2012-05-21 | 1 | -0/+13 |
| | |||||
* | Add HTML5 input[type="time"] helper | Alex Soulim | 2012-05-18 | 1 | -0/+26 |
| | |||||
* | Change check_box to work inverting the checked and unchecked value | Rafael Mendonça França | 2012-04-29 | 1 | -2/+98 |
| | | | | | | | | | | This fixes: * Boolean with inverted logic * Integer with inverted logic * BigDecimal with inverted logic Fixes #3995 | ||||
* | Lazy load `default_form_builder` if it's passed as a string | Piotr Sarnacki | 2012-04-28 | 1 | -0/+17 |
| | | | | closes #3341 | ||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Add index method to FormBuilder. Useful when you use field_for and need to ↵ | Jorge Bejar | 2012-04-11 | 1 | -0/+50 |
| | | | | know the index number into the iteration. | ||||
* | Block version of label should wrapped in field_with_errors in case of error | Alexey Vakhov | 2012-04-01 | 1 | -0/+14 |
| | |||||
* | Check if the options hash already exists and merge it with the another | Rafael Mendonça França | 2012-03-27 | 1 | -6/+18 |
| | | | | | | hash. Closes #2492 and #5615 | ||||
* | Fixing issue #2492 for master branch. ActionView::Base.field_error_proc ↵ | Andrey Samsonov | 2012-03-27 | 1 | -0/+22 |
| | | | | | | | | doesn't call for label. objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example | ||||
* | Remove warning added by my own commit :fire: | Carlos Antonio da Silva | 2012-03-26 | 1 | -1/+1 |
| | | | | Commit: 7a0cf2f5294e8bcef547642435636b394340a3e4 | ||||
* | Merge pull request #5561 from carlosantoniodasilva/form-builder-block-arg | Aaron Patterson | 2012-03-26 | 1 | -0/+12 |
|\ | | | | | Properly deprecate the block argument in AV FormBuilder | ||||
| * | Properly deprecate the block argument in AV FormBuilder | Carlos Antonio da Silva | 2012-03-23 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | Commit 56089ca986c767763f29159c8de0aa1ebabfd4d2 introduced a backward incompatible change by changing the method signature of the FormBuilder. This brings back the same method signature warning in case someone gives a block to the builder. More info: https://github.com/rails/rails/commit/56089ca986c767763f29159c8de0aa1ebabfd4d2#commitcomment-1116166 | ||||
* | | apply form_for namespace option to date_select | Sergey Nartimov | 2012-03-26 | 1 | -0/+8 |
|/ | |||||
* | add include_hidden option to checkbox tag | Sergey Nartimov | 2012-03-13 | 1 | -0/+5 |
| | |||||
* | Fixes #5324 by removing default size options from input:text and default ↵ | Philip Arndt | 2012-03-10 | 1 | -162/+162 |
| | | | | cols and rows options from textarea. | ||||
* | Add a new line after the textarea opening tag. | Rafael Mendonça França | 2012-02-27 | 1 | -36/+36 |
| | | | | Closes #393 | ||||
* | Fix collection_check_boxes and collection_radio_buttons when using local | Rafael Mendonça França | 2012-02-26 | 1 | -0/+38 |
| | | | | variables in the form builder | ||||
* | Move all the helpers to protected section | Rafael Mendonça França | 2012-02-26 | 1 | -31/+31 |
| | |||||
* | uses PATCH for the forms of persisted records, and routes PATCH and PUT to ↵ | Xavier Noria | 2012-02-24 | 1 | -69/+66 |
| | | | | the update action of resources | ||||
* | correct fetching :name option in form fields | Vasiliy Ermolovich | 2012-02-23 | 1 | -0/+5 |
| | |||||
* | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | ||||
* | Add HTML5 input[type="date"] helper | Olek Janiszewski | 2012-02-12 | 1 | -0/+26 |
| | |||||
* | Replicate :form html5 attribute to hidden field for check_box | Carlos Antonio da Silva | 2012-02-02 | 1 | -3/+10 |
| | | | | | When the new html5 attribute :form is given to the check_box helper, it should be replicated to the hidden field as well. Closes #4848 | ||||
* | check_box with nil as unchecked value should be HTML safe | Rafael Mendonça França | 2012-01-31 | 1 | -0/+4 |
| | | | | [Carlos Antonio da Silva + Rafael Mendonça França] | ||||
* | Do not generate label for attribute when giving nil | Carlos Antonio da Silva | 2012-01-26 | 1 | -0/+4 |
| | |||||
* | Raise a better error if anyone wants to create your own ↵ | Rafael Mendonça França | 2012-01-23 | 1 | -0/+8 |
| | | | | ActionView::Helpers::Tags::Base child and do not implement the render method | ||||
* | Adding one test case for label with block | Rafael Mendonça França | 2012-01-17 | 1 | -0/+4 |
| | |||||
* | use stub instead of redefining method to suppress warnings | Sergey Nartimov | 2012-01-07 | 1 | -2/+2 |
| | |||||
* | don't set the hidden checkbox value if it's nil | Damien Mathieu | 2012-01-06 | 1 | -0/+8 |
| | |||||
* | Do not stub id here | Santiago Pastorino | 2012-01-06 | 1 | -6/+6 |
| | |||||
* | Revert "Revert "More 1.9 way"" | Santiago Pastorino | 2012-01-06 | 1 | -0/+2 |
| | | | | | Fixed failing tests This reverts commit 8350ce97f2065eed9638c595d3938a573d6fa343. | ||||
* | check_box helper with :disabled => true generates disabled hidden field. ↵ | Tadas Tamošauskas | 2012-01-05 | 1 | -4/+3 |
| | | | | fixes #1953 | ||||
* | Make sure that check_box helper return a safe buffer | Rafael Mendonça França | 2012-01-04 | 1 | -0/+1 |
| | |||||
* | Add button_tag support to ActionView::Helpers::FormBuilder. | Will Farrington | 2011-12-11 | 1 | -1/+3 |
| | | | | | | | | | | This support is near-identical to the existing submit_tag support. Example: <%= form_for @post do |f| %> <%= f.button %> <% end %> | ||||
* | form_for with +:as+ option uses "action_as" as css class and id | Vasiliy Ermolovich | 2011-12-04 | 1 | -11/+11 |
| | |||||
* | test helpers in erb using erb | lest | 2011-11-30 | 1 | -3/+2 |
| | |||||
* | add namespace options to form_for | Vasiliy Ermolovich | 2011-11-27 | 1 | -0/+76 |
| | | | | | You can provide a namespace for your form to ensure uniqueness of id attributes on form elements. The namespace attribute will be prefixed with underscore on the generate HTML id | ||||
* | fix label with block in erb | lest | 2011-11-27 | 1 | -0/+7 |
| | |||||
* | Rely on a public contract between railties instead of accessing railtie ↵ | José Valim | 2011-11-23 | 1 | -1/+1 |
| | | | | methods directly. | ||||
* | Fix impractical I18n lookup in nested fields_for | Alexander Uvarov | 2011-11-17 | 1 | -0/+46 |
| | |||||
* | add tests for the case where size is explicitly passed to number_field helper | Vijay Dev | 2011-11-04 | 1 | -0/+4 |
| |