aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template/asset_tag_helper_test.rb
Commit message (Collapse)AuthorAgeFilesLines
...
* javascript_include_tag shouldn't raise if you register an expansion key with ↵Santiago Pastorino2011-02-281-2/+10
| | | | nil value
* Add tests for register expansion methods with key = []Santiago Pastorino2011-02-281-2/+12
|
* Applied changes to stylesheet_link_tag from javascript_include_tag which ↵Josh Kalderimis2011-02-131-0/+23
| | | | corrects issues with ordering and duplicates.
* This corrects two issues with javascript_include_tag, the order at which ↵Josh Kalderimis2011-02-131-1/+24
| | | | | | | | they are expanded, and removing duplicates. When individual js assets are specified, they will override the order of the same asset specified in an expansion. [#5938 state:resolved]
* Allow registering javascript/stylesheet_expansions to existing symbolsSantiago Pastorino2010-12-221-0/+19
|
* Do not use the same hash instance for expansions [#6114 state:resolved]Piotr Sarnacki2010-12-221-0/+8
| | | | | Using the same hash instance makes using the same expansions for both javascripts and stylesheets.
* Fix AssetIncludeTag ensuring that files are in the wrong directory [#6015 ↵Henning Koch2010-11-191-0/+44
| | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* incorporated most of the feedback from JoséJosh Kalderimis2010-11-161-2/+2
|
* removed an assert from a test as it was testing a private methodJosh Kalderimis2010-11-161-1/+0
|
* provide better error message if path is uri [#5914 state:resolved]Neeraj Singh2010-11-111-0/+11
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Use parentheses when using assert_match followed by a regexp to avoid warnings.Emilio Tagua2010-09-271-1/+1
|
* application.js should be the last file on javascript_include_tag(:all)Santiago Pastorino2010-09-191-8/+8
|
* Added ability to set asset_path for enginesPiotr Sarnacki2010-09-031-0/+23
|
* Tidy up asset tag a bit and make railties tests green again.José Valim2010-06-231-2/+2
|
* refactored the javascript asset tag helpers and moved the default scripts ↵Josh Kalderimis2010-06-231-15/+7
| | | | | | setup within the railtie Signed-off-by: José Valim <jose.valim@gmail.com>
* Updating image_tag to support cid:content_id "URLs"Mikel Lindsaar2010-06-071-0/+9
|
* Accept :alt => nil on image_tag [#4558 state:resolved]Marc-Andre Lafortune2010-05-151-1/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* adds #favicon_link_tag back, rdoc explains why it is useful, and how to get ↵Xavier Noria2010-04-081-0/+12
| | | | a link for Mobile Safari with it
* Revert "adds #favicon_link_tag and #apple_touch_icon_link_tag" -- these tags ↵David Heinemeier Hansson2010-04-081-20/+0
| | | | | | are too specific. This reverts commit 6891f46d10957f21f200fc4dc2b6076ff411b1da, ec8610cfdc32d0fe816fb22405e00ef1b6c90d73, and d18ff1b7efd96e7c08bc1a15137735be45f87e07.
* adds a default source to #apple_touch_icon_link_tagXavier Noria2010-04-071-0/+1
|
* new helpers #favicon_link_tag and #apple_touch_icon_link_tagXavier Noria2010-04-071-0/+19
|
* Refactored url_for in AV to have its own instances of the helpers instead of ↵wycats2010-04-031-15/+11
| | | | proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win)
* Updated asset_template_path to asset_path and have it also support a String ↵wycats2010-03-281-1/+8
| | | | [#4247 state:resolved]
* Allow customisation of asset path generation using a proc.Craig R Webster2010-03-281-0/+9
| | | | | | | | | | | | | | | | Set config.action_controller.asset_path_template to a proc that takes one argument - the direct, unchanged asset path - and returns a path to that asset using the scheme that your assets require. This is useful if you have a setup which scales by introducing new application servers where the mtime of the asset files may not be the same as those of the asset files on your previous servers, but it does require your web servers to have knowledge of the asset template paths that you rewrite to so it's not suitable for out-of-the-box use. An example of configuring asset path generation and rewriting these paths using Apache is included in actionpack/lib/action_view/helpers/asset_tag_helper.rb. Signed-off-by: wycats <wycats@gmail.com>
* There's a Ruby issue with File.basename different versions returns different ↵Santiago Pastorino2010-03-141-1/+0
| | | | things, so we shouldn't test that
* Made asset_tag_helper use config.perform_caching instead of ↵Denis Odorcic2010-03-121-18/+18
| | | | | | ActionController::Base.perform_caching Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix testJeremy Kemper2010-03-111-1/+1
|
* simplify alt tag generation for imagesEaden McKee2010-03-111-1/+4
| | | | | | [#2837 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Move stuff from compatibility.rb to deprecated.rbCarlhuda2010-03-041-1/+0
|
* Fix a bunch of failing AP / AM specs created from the previous ↵Carl Lerche2010-03-041-27/+15
| | | | AbstractController configuration refactor.
* Move the original config method onto AbstractControllerCarl Lerche2010-03-031-1/+1
|
* Start refactoring the method of configuring ActionViewCarlhuda2010-03-031-12/+2
|
* Work on deprecating ActionController::Base.relative_url_rootCarlhuda2010-03-031-20/+18
|
* Include prototype ujs adapter with new appsJoshua Peek2010-01-301-8/+7
|
* Revert "fixed tests to also look for rails.js when using ↵Joshua Peek2010-01-301-7/+7
| | | | | | javascript_include_tag :defaults" This reverts commit 7f181e475080924164b3fa0071ee4898bd66cbb8.
* fixed tests to also look for rails.js when using javascript_include_tag ↵Erik St. Martin2010-01-291-7/+7
| | | | :defaults
* Start adding configuration to ActionView instead of using constants.Yehuda Katz2009-10-141-0/+10
| | | | | | | By using config rather than hardcoded constants, we can evolve the configuration system over time (we'd just need to update the config method with more robust capabilities and all consumers would get the capabilities with no code changes)
* Switch to on-by-default XSS escaping for rails.Michael Koziarski2009-10-081-0/+12
| | | | | | | | | | | | This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration.
* Don't raise exceptions for missing javascript_include_tag or ↵Sam Pohlenz2009-09-031-4/+58
| | | | | | stylesheet_link_tag sources unless the :cache or :concat options are given. [#2738 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" ↵Matthew Rudy Jacobs2009-08-051-2/+6
| | | | | | or ".css" onto external urls [#1664 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix tag helpers so that all HTML element boolean attributes render according ↵Marc Love2009-07-301-4/+4
| | | | | | to the specs. Added all boolean attributes listed in the XHTML 1.0 specs (http://www.w3.org/TR/xhtml1/guidelines.html) and HTML 5 specs (http://www.whatwg.org/specs/web-apps/current-work). HTML 5 boolean attribute rendering was broken in commit 1e2d7229602f467cfdc0ef606b5ef8a5566a1501 / [#2864 state:resolved]. Signed-off-by: Yehuda Katz <wycats@gmail.com>
* Adds a audio_tag helper for the HTML5 audio tag. Fixed video_path docs. HTML ↵Emilio Tagua2009-07-071-4/+36
| | | | | | attributes values should be true or false not attribute's name. [#2864 state:resolved] Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local>
* Adds a video_tag helper for the HTML5 video tag (similar to how the ↵Tieg Zaharia2009-07-021-2/+41
| | | | | | image_tag works) (tests included); removes a duplicate test line for image_tag; adds boolean attributes for video tag to tag()'s boolean attributes Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
* Handle missing javascript/stylesheets assets by raising an exceptionChristos Zisopoulos2009-06-261-30/+88
| | | | | | | | | | | | An exception will be raised if a local javascript/stylesheet file included by the stylesheet_link_tag or javascript_include_tag can not be found. When caching is enabled, we use atomic_write to ensure that the cache file is not created with zero length. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2738 state:committed]
* Add :concat option to asset tag helpers to force concatenation.Joshua Peek2009-06-151-0/+30
| | | | | This is useful for working around IE's stylesheet limit. stylesheet_link_tag :all, :concat => true
* allow absolute paths for the asset cachesAndrew Kaspick2009-06-111-0/+16
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-131-14/+12
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha.Jeremy Kemper2009-02-031-14/+12
| |
| * Revert to the good old days when AssetTag didn't cause anyone problemsJoshua Peek2009-01-021-2/+0
| |
| * Fixed the AssetTagHelper cache to use the computed asset host as part of the ↵David Heinemeier Hansson2009-01-011-0/+20
| | | | | | | | cache key instead of just assuming the its a string [#1299 state:committed]