aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/template/active_record_helper_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Ported the new ActionView::TestCase from 2-3-stable to master [#3260Erik Ostrom2009-09-281-1/+1
| | | | | | | | | | | | | | | | | state:resolved] The test case now mimicks the template environment more closely, so it's possible to use render, load helper dependencies. This also fixes assert_select, and similar assertions. Because view tests and helpers generally don't render full templates assert_select looks first in rendered and then in output_buffer to find the rendered output. Additional `master'-only changes: Made the Action Pack Rakefile run the ActionView::TestCase tests, and made ActionView::Rendering#_render_text always return a string. Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Add support for error_messages_for(@obj)Yehuda Katz2009-07-281-0/+10
|
* AMo conversion helperJoshua Peek2009-07-211-3/+6
|
* Rename ActiveRecordHelper to ActiveModelHelperYehuda Katz2009-07-201-1/+1
|
* Define ActiveModel API ComplianceYehuda Katz2009-07-201-9/+7
| | | | | | - Define to_model on AR - Define to_model on ActiveModel::APICompliant - Update test fixtures to be API Compliant - Start using to_model in AP
* Fixes a number of tests that inexplicably didn't fail when we committed the ↵Yehuda Katz + Carl Lerche2009-07-021-1/+1
| | | | original patch
* Use errors[field] instead of errors.on(field)Jeremy Kemper2009-06-171-7/+7
|
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-131-0/+34
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * Ensure Active Record error related view helpers escape the message [#1280 ↵Dan Barry2009-03-071-0/+34
| | | | | | | | | | | | state:resolved] [Inge Jørgensen, Dan Barry] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Temporarily modifies setup to call super directly. This can support more ↵Yehuda Katz and Carl Lerche2009-04-081-0/+1
|/ | | | T::U runners.
* error_message_on takes an options hash instead of ordered parameters [#704 ↵Clemens Kofler2008-07-271-24/+24
| | | | | | state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Introduce ActionView::TestCase for testing view helpers.Joshua Peek2008-04-191-7/+2
|
* Fixed ActionView::Helpers::ActiveRecordHelper::form for when ↵David Heinemeier Hansson2008-01-111-0/+22
| | | | | | protect_from_forgery is used (closes #10739) [jeremyevans] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-051-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added tests for options to ActiveRecordHelper#form. Closes #7213 ↵Marcel Molina2007-10-231-0/+9
| | | | | | [richcollins, mikong, mislav] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* error_messages_for also takes :message and :header_message options which ↵Jeremy Kemper2007-10-141-0/+8
| | | | | | defaults to the old "There were problems with the following fields:" and "<count> errors prohibited this <object_name> from being saved". Closes #8270. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* error_messages_for and friends also work with local variables. Closes #9699.Jeremy Kemper2007-10-071-1/+22
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improve UrlRewriter tests. Improve helper test coverage. Closes #7207, ↵Jeremy Kemper2007-06-131-11/+27
| | | | | | #7208, #7212. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Removed deprecated parameters_for_method_reference concept (legacy from ↵David Heinemeier Hansson2007-05-121-1/+1
| | | | | | before named routes) [DHH] Added record identification with polymorphic routes for ActionController::Base#url_for and ActionView::Base#url_for [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use a consistent load path to avoid double requires. Fix some scattered Ruby ↵Jeremy Kemper2007-01-281-8/+1
| | | | | | warnings. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix no method error with error_messages_on. Closes #6935 [nik.wakelin Koz]Michael Koziarski2007-01-071-1/+5
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make error_message_on handle nil objects. [dan]Michael Koziarski2006-12-271-0/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5799 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Bob's raining patches: fixes date_helper bugs and usability issues. ↵Jeremy Kemper2006-12-061-3/+3
| | | | | | References #3811. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r4487@asus: jeremy | 2006-04-29 12:21:39 -0700Jeremy Kemper2006-07-081-9/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check whether @flash is defined? for warnings-safety. r4488@asus: jeremy | 2006-04-29 12:23:15 -0700 Check whether @flash is defined? for warnings-safety. Obviates nil? check. r4489@asus: jeremy | 2006-04-29 12:45:18 -0700 Check whether @session is defined? for warnings-safety. r4490@asus: jeremy | 2006-04-29 12:50:41 -0700 Check whether @rendering_runtime is defined? for warnings-safety. r4491@asus: jeremy | 2006-04-29 12:55:01 -0700 Check whether @_cycles is defined? for warnings-safety. r4492@asus: jeremy | 2006-04-29 12:59:19 -0700 Check whether instance variables are defined? for warnings-safety. r4493@asus: jeremy | 2006-04-29 13:14:09 -0700 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning. r4494@asus: jeremy | 2006-04-29 13:31:34 -0700 Check whether @auto_index defined? for warnings-safety. r4495@asus: jeremy | 2006-04-29 13:32:24 -0700 Wrap content_columns redefinitions with silence_warnings. r4496@asus: jeremy | 2006-04-29 13:35:28 -0700 Wrap more redefinitions with silence_warnings. r4829@asus: jeremy | 2006-07-08 10:59:20 -0700 abstract unit, fix warnings r4830@asus: jeremy | 2006-07-08 11:06:12 -0700 Use parens to silence warning. r4831@asus: jeremy | 2006-07-08 11:06:48 -0700 Use parens to silence warning. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Pass :id => nil or :class => nil to error_messages_for to supress that html ↵Jeremy Kemper2006-07-081-0/+2
| | | | | | attribute. Closes #3586. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allow error_messages_for to report errors for multiple objects, as well as ↵Marcel Molina2006-04-261-1/+51
| | | | | | support for customizing the name of the object in the error summary header. Closes #4186. [andrew@redlinesoftware.com, Marcel Molina Jr.] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* make error_messages_for return "" for nil objectsMichael Koziarski2006-01-191-0/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Optimized tag_options to not sort keys, which is no longer necessary when ↵David Heinemeier Hansson2005-09-201-9/+9
| | | | | | assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added :multipart option to ActiveRecordHelper#form to make it possible to ↵David Heinemeier Hansson2005-09-111-0/+7
| | | | | | add file input fields #2034 [jstirk@oobleyboo.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r2822@asus: jeremy | 2005-07-04 21:14:30 -0700Jeremy Kemper2005-07-041-6/+8
| | | | | | | silence warnings re. class redefinitions git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added that UrlHelper#mail_to will now also encode the default link title ↵David Heinemeier Hansson2005-07-021-3/+3
| | | | | | #749 [f.svehla@gmail.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added option to pass in parameters to CaptureHelper#capture, so you can ↵David Heinemeier Hansson2005-06-211-4/+4
| | | | | | create more advanced view helper methods #1466 [duane.johnson@gmail.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700Jeremy Kemper2005-06-121-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Branch to have scaffold use new render methods r2496@sedna: jeremy | 2005-05-28 10:50:51 -0700 axe unused process_request method r2497@sedna: jeremy | 2005-05-28 10:51:58 -0700 sanity assertions in process method check that @controller, @request, @response are set r2498@sedna: jeremy | 2005-05-28 10:53:42 -0700 clean up escaping. use instance_variable_get instead of instance_eval. put id in form action instead of hidden input (like the generated scaffolding) r2499@sedna: jeremy | 2005-05-28 10:54:46 -0700 clean up interpolation, remove tabs from stylesheet r2500@sedna: jeremy | 2005-05-28 10:56:40 -0700 modernize dynamic scaffolding. use params[:id] instead of @params[id]. use consolidated render method instead of render_action, render_file, etc. use builtin inflections rather than module methods. r2501@sedna: jeremy | 2005-05-28 11:00:26 -0700 modernize generated scaffolding. use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_* r2542@sedna: jeremy | 2005-06-12 02:24:06 -0700 use :id => model instead of :id => model.id. clean up the form helper method. use flash[:notice] instead of flash['notice']. r2543@sedna: jeremy | 2005-06-12 02:33:22 -0700 whitespace r2544@sedna: jeremy | 2005-06-12 02:56:57 -0700 update changelogs r2545@sedna: jeremy | 2005-06-12 03:26:23 -0700 test dynamic form help when @post is not a new record r2546@sedna: jeremy | 2005-06-12 03:44:14 -0700 touch up TestCase#process sanity assertions git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed DateHelper to return values on the option tags such that they'll work ↵David Heinemeier Hansson2005-04-171-2/+2
| | | | | | properly in IE with form_remote_tag #1024 [rscottmace@gmail.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that form helpers would treat string and symbol keys differently in ↵David Heinemeier Hansson2005-03-061-1/+1
| | | | | | html_options (and possibly create duplicate entries) #112 [bitsweat] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added respondence to *_before_type_cast for all attributes to return their ↵David Heinemeier Hansson2004-12-191-0/+5
| | | | | | string-state before they were type casted by the column type. Added use of *_before_type_cast for all input and text fields. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Updated unit tests to reflect lowercase post as method in form tagsDavid Heinemeier Hansson2004-12-131-3/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed all helpers so that they use XHTML compliant double quotes for values ↵David Heinemeier Hansson2004-12-121-8/+8
| | | | | | instead of single quotes [htonl/bitsweat] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use lower-case post instead of POST as form method for XHTML compliance #290 ↵David Heinemeier Hansson2004-12-121-4/+4
| | | | | | [Scott Baron] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Trick tests on url_forDavid Heinemeier Hansson2004-12-071-0/+9
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@66 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added options to tailor header tag, div id, and div class on ↵David Heinemeier Hansson2004-12-011-1/+18
| | | | | | ActiveRecordHelper#error_messages_for [josh] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@41 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* InitialDavid Heinemeier Hansson2004-11-241-0/+76
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de