aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/lib
Commit message (Collapse)AuthorAgeFilesLines
* Removing unused fake modelsThiago Pradi2014-09-071-45/+0
|
* Eliminate `JSON.{parse,load,generate,dump}` and `def to_json`Godfrey Chan2013-11-051-2/+2
| | | | | | | | | | | | | | | JSON.{dump,generate} offered by the JSON gem is not compatiable with Rails at the moment and can cause a lot of subtle bugs when passed certain data structures. This changed all direct usage of the JSON gem in internal Rails code to always go through AS::JSON.{decode,encode}. We also shouldn't be implementing `to_json` most of the time, and these occurances are replaced with an equivilent `as_json` implementation to avoid problems down the road. See [1] for all the juicy details. [1]: intridea/multi_json#138 (comment)
* Removing unused fake models from actionpack testsThiago Pradi2013-10-161-95/+0
|
* Remove unused fixtures and models from AP testsŁukasz Strzałkowski2013-08-251-6/+0
|
* Add HTML5 input[type="color"] helperCarlos Galdino2012-05-211-0/+3
|
* Removing old Controller testThiago Pradi2012-02-121-1/+0
|
* Cleaning Route generation testsThiago Pradi2012-02-121-28/+2
|
* Fix override API response bug in respond_withPrem Sichanugrist2012-02-031-0/+10
| | | | | | | | | | Default responder was only using the given respond block when user requested for HTML format, or JSON/XML format with valid resource. This fix the responder so that it will use the given block regardless of the validity of the resource. Note that in this case you'll have to check for object's validity by yourself in the controller. Fixes #4796
* 'with_kcode' removed. Arun Agrawal2011-12-211-15/+0
| | | | Testing Sandbox removed.
* Rely on a public contract between railties instead of accessing railtie ↵José Valim2011-11-231-2/+2
| | | | methods directly.
* Silence Ruby warnings about uninitialized instance variable.Mike Gehard2011-09-091-9/+2
|
* Use real hash model in nested fields_for with hash model testSam Pohlenz2011-06-221-0/+11
|
* Fix tests on 1.9.2.José Valim2010-11-281-1/+1
|
* If a user wants json output then try best to render json output. In such ↵Neeraj Singh2010-11-241-0/+6
| | | | | | | | cases prefer kind_of(String) over respond_to?(to_str) [#5841 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* fields_for should treat ActiveRecord::Relation as an arrayNeeraj Singh2010-11-111-0/+10
| | | | | | [#5795 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* fixing a few test warningsAaron Patterson2010-10-041-0/+5
|
* moving fake model to the correct fileAaron Patterson2010-10-031-0/+14
|
* Review most of the form_for deprecated tests, missing tests with index like []Carlos Antonio da Silva2010-09-261-0/+1
|
* Remove namespace for isolated namespaced models in formsPiotr Sarnacki2010-09-031-0/+15
|
* to_param shoul return a stringPiotr Sarnacki2010-09-031-1/+1
|
* move FixtureResolver to a file that is accessible outside Rails' own testsDavid Chelimsky2010-05-021-29/+0
| | | | | | [#4522 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Improve performance of the rendering stack by freezing formats as a sign ↵José Valim2010-03-191-2/+2
| | | | that they shouldn't be further modified.
* Sending the partial as info is no longer required.José Valim2010-03-181-2/+2
|
* Move more normalization up to the lookup context, so it does not have to ↵José Valim2010-03-161-1/+1
| | | | repeat in every resolver.
* Make all AP tests pass for Ruby 1.9.1.José Valim2010-03-121-2/+3
|
* Add tests for lookup context.José Valim2010-03-111-0/+2
|
* Clean up the API required from ActionView::Template.José Valim2010-03-091-3/+5
|
* First take on ViewPaths clean up.José Valim2010-03-071-2/+2
|
* Require persisted? in ActiveModel::Lint and remove new_record? and ↵José Valim2010-02-211-28/+12
| | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
* AMo #key is now #to_key and CI is probably happysnusnu2010-02-201-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
* Adds #key and #to_param to the AMo interfacesnusnu2010-02-191-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces two new methods that every AMo compliant object must implement. Below are the default implementations along with the implied interface contract. # Returns an Enumerable of all (primary) key # attributes or nil if new_record? is true def key new_record? ? nil : [1] end # Returns a string representing the object's key # suitable for use in URLs, or nil if new_record? # is true def to_param key ? key.first.to_s : nil end 1) The #key method Previously rails' record_identifier code, which is used in the #dom_id helper, relied on calling #id on the record to provide a reasonable DOM id. Now with rails3 being all ORM agnostic, it's not safe anymore to assume that every record ever will have an #id as its primary key attribute. Having a #key method available on every AMo object means that #dom_id can be implemented using record.to_model.key # instead of record.id Using this we're able to take composite primary keys into account (e.g. available in datamapper) by implementing #dom_id using a newly added record_key_for_dom_id(record) method. The user can overwrite this method to provide customized versions of the object's key used in #dom_id. Also, dealing with more complex keys that can contain arbitrary strings, means that we need to make sure that we only provide DOM ids that are valid according to the spec. For this reason, this patch sends the key provided through a newly added sanitize_dom_id(candidate_id) method, that makes sure we only produce valid HTML The reason to not just add #dom_id to the AMo interface was that it feels like providing a DOM id should not be a model concern. Adding #dom_id to the AMo interface would force these concern on the model, while it's better left to be implemented in a helper. Now one could say the same is true for #to_param, and actually I think that it doesn't really fit into the model either, but it's used in AR and it's a main part of integrating into the rails router. This is different from #dom_id which is only used in view helpers and can be implemented on top of a semantically more meaningful method like #key. 2) The #to_param method Since the rails router relies on #to_param to be present, AR::Base implements it and returns the id by default, allowing the user to overwrite the method if desired. Now with different ORMs integrating into rails, every ORM railtie needs to implement it's own #to_param implementation while already providing code to be AMo compliant. Since the whole point of AMo compliance seems to be to integrate any ORM seamlessly into rails, it seems fair that all we really need to do as another ORM, is to be AMo compliant. By including #to_param into the official interface, we can make sure that this code can be centralized in the various AMo compliance layers, and not be added separately by every ORM railtie. 3) All specs pass
* Ensure render :text => resource first tries to invoke :to_text on itJosé Valim2010-02-161-0/+1
|
* Make check boxes accept :multiple as option so they can handle collections ↵José Valim2010-01-141-1/+1
| | | | (such as HABTM).
* I18n label helper [#745 status:resolved]Carsten Gehling2010-01-021-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Make recognize try to constantize controller to see if it existsJoshua Peek2009-12-011-1/+12
|
* Donate tests I wrote for rackmount rails integrationJoshua Peek2009-10-201-1/+4
|
* Add define another "stuff" controller to support routing testsJoshua Peek2009-10-101-0/+1
|
* Add define a "stuff" controller in fixtures to support routing testsJoshua Peek2009-10-101-0/+1
|
* Redraw default routes on all internal integration tests. We don't need ↵Joshua Peek2009-10-031-5/+0
| | | | SimpleRouteCase anymore
* Avoid creating new controller constants during test runtime. All routable ↵Joshua Peek2009-10-031-9/+18
| | | | controllers should be defined beforehand.
* Moved shared form helper models into fake_modelsJoshua Peek2009-10-031-0/+96
|
* Add custom "with_routing" to internal tests to fix reseting session after usingJoshua Peek2009-10-031-0/+1
| | | | with_routing. This only affects our internal AP tests.
* Define weblog controller for url helper testJoshua Peek2009-09-131-0/+1
|
* Merge abstract_controller/test_helper and new_base/test_helper since they ↵Joshua Peek2009-09-131-104/+0
| | | | are expected to run in the same testing sandbox
* Add fake controllers for url rewriter testsJoshua Peek2009-09-061-0/+5
|
* Cleanup hacky routing with controller_path in url helper tests. This doesn't ↵Joshua Peek2009-09-061-1/+1
| | | | work in real life anyway.
* Fix isolated running of AddressesTestJoshua Peek2009-09-061-0/+1
|
* Fix isolated running of ActionPackAssertionTestJoshua Peek2009-09-061-1/+1
|
* Remove a useless method in the fixture template classYehuda Katz + Carl Lerche2009-09-031-4/+0
|
* Refactor ActionView::ResolverYehuda Katz + Carl Lerche2009-09-031-54/+12
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 17:39:11 +0000