Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 7 | -13/+13 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 4 | -65/+65 |
| | |||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 2 | -25/+21 |
| | |||||
* | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 3 | -79/+79 |
| | |||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 12 | -354/+354 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Deprecate :controller and :action path parameters | Andrew White | 2016-03-01 | 1 | -61/+69 |
| | | | | | | | | Allowing :controller and :action values to be specified via the path in config/routes.rb has been an underlying cause of a number of issues in Rails that have resulted in security releases. In light of this it's better that controllers and actions are explicitly whitelisted rather than trying to blacklist or sanitize 'bad' values. | ||||
* | Remove TestRouter#add_routes | akihiro17 | 2015-09-29 | 1 | -11/+0 |
| | | | | | | Now, we use the mapper to build the routing table related to https://github.com/rails/rails/commit/703275ba70efbefb3358052b6ba750443eff1a28 | ||||
* | File encoding is defaulted to utf-8 in Ruby >= 2.1 | Akira Matsuda | 2015-09-18 | 1 | -1/+0 |
| | |||||
* | symbols will always be constructed with strings. :bomb: | Aaron Patterson | 2015-08-18 | 1 | -1/+1 |
| | |||||
* | routes are always constructed with a hash for the conditions | Aaron Patterson | 2015-08-17 | 1 | -1/+1 |
| | |||||
* | introduce an alternate constructor for Route objects | Aaron Patterson | 2015-08-17 | 1 | -12/+12 |
| | | | | | I want to change the real constructor to take a particular parameter for matching the request method | ||||
* | default pattern to use a joined string | Aaron Patterson | 2015-08-17 | 2 | -13/+15 |
| | | | | | The string we create is almost always the same, so rather than joining all the time, lets join once, then reuse that string everywhere. | ||||
* | use the mapper to build the routing table | Aaron Patterson | 2015-08-15 | 2 | -231/+103 |
| | | | | | | We should build the routes using the user facing API which is `Mapper`. This frees up the library internals to change as we see fit. IOW we shouldn't be testing internals. | ||||
* | only keep one hash of named routes | Aaron Patterson | 2015-08-14 | 2 | -13/+14 |
| | | | | | The outer router object already keeps a hash of named routes, so we should just use that. | ||||
* | rm add_route2 | Aaron Patterson | 2015-08-14 | 2 | -41/+51 |
| | | | | | refactor the tests with a backwards compatible method call so we can rm add_route2 from the journey router | ||||
* | use predicate methods instead of hard coding verb strings | Aaron Patterson | 2015-08-14 | 1 | -5/+4 |
| | | | | | also change the feeler to subclass AD::Request so that it has all the methods that Request has | ||||
* | remove Strexp | Aaron Patterson | 2015-08-13 | 4 | -74/+61 |
| | | | | | This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object. | ||||
* | pass anchor directly to `Pattern` | Aaron Patterson | 2015-08-13 | 4 | -39/+38 |
| | | | | | the caller already has it, there is no reason to pack it in to an object and just throw that object away. | ||||
* | Revert "Merge pull request #20584 from arthurnn/fix_url" | Arthur Neves | 2015-06-17 | 1 | -7/+0 |
| | | | | | | | | This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b. As pointed out on the PR, this will hide development mistakes too, which is not ideal. | ||||
* | Catch InvalidURIError on bad paths on redirect. | Arthur Neves | 2015-06-16 | 1 | -0/+7 |
| | | | | | Handle URI::InvalidURIError errors on the redirect route method, so it wont raise a 500 if a bad path is given. | ||||
* | extract required_defaults from the conditions hash before constructing the route | Aaron Patterson | 2015-06-08 | 3 | -48/+48 |
| | | | | | this way we can remove the strange "respond_to?" conditional in the `matches?` loop | ||||
* | Prefer assert_not over refute | Rafael Mendonça França | 2015-05-18 | 1 | -1/+1 |
| | |||||
* | ActionDispatch::Journey::Routes#empty? test cases | Valentine Valyaeff | 2015-05-19 | 1 | -0/+2 |
| | |||||
* | Silence ambiguous first argument warning | Prem Sichanugrist | 2015-05-04 | 1 | -1/+1 |
| | | | | | | | This silences: actionpack/test/journey/route_test.rb:33: warning: ambiguous first argument; put parentheses or a space even after `/' operator | ||||
* | Merge pull request #18392 from brainopia/fix_route_requirements | Arthur Nogueira Neves | 2015-04-27 | 1 | -0/+8 |
|\ | | | | | Correct route requirements by overriding defaultls | ||||
| * | Correct route requirements by overriding defaultls (fixes #18373) | brainopia | 2015-01-08 | 1 | -0/+8 |
| | | |||||
* | | sort_by instead of sort | Yang Bo | 2015-04-08 | 1 | -0/+27 |
| | | | | | | | | | | | | it is avoid sort errot within different and mixed keys. used `sort_by` + `block` to list parameter by keys. keep minimum changes | ||||
* | | Merge pull request #15806 from tgxworld/partition_routes_during_setup | Aaron Patterson | 2015-03-02 | 1 | -0/+21 |
|\ \ | | | | | | | Partition routes during setup. | ||||
| * | | Partition routes during setup. | Guo Xiang Tan | 2015-02-26 | 1 | -0/+21 |
| | | | | | | | | | | | | | | | | | | | | | Partitioning of all the routes is currently being done during the first request. Since there is no need to clear the cache for `partitioned_routes` when adding a new route. We can move the partitioning of the routes during setup time. | ||||
* | | | Remove unneeded comment. [ci skip] | Zoltan Kiss | 2015-03-02 | 1 | -1/+0 |
|/ / | |||||
* / | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 1 | -1/+0 |
|/ | | | | onwards. | ||||
* | make OR in journey patterns compile to a valid regular expression | Konstantin Haase | 2014-11-29 | 1 | -0/+2 |
| | |||||
* | Fix cases where the wrong name is passed to `Formatter#generate` | Godfrey Chan | 2014-11-23 | 1 | -1/+1 |
| | | | | | These are currently working "by accident" because `match_route` does not check that the name is valid. | ||||
* | fix url generation error message | Accessd | 2014-10-21 | 1 | -0/+10 |
| | |||||
* | Improve Journey compliance to RFC 3986 | Nicolas Cavigneaux | 2014-10-14 | 1 | -6/+19 |
| | | | | | | | | | | The scanner in Journey fails to recognize routes that use literals from the sub-delims section of RFC 3986. This commit enhance the compatibility of Journey with the RFC by adding support of authorized delimiters to the scanner. Fix #17212 | ||||
* | Improve router test. | Guo Xiang Tan | 2014-08-21 | 1 | -6/+11 |
| | | | | | We should assert that routes will not be recognized if the verbs do not match. | ||||
* | Avoid duplicating routes for HEAD requests. | Guo Xiang Tan | 2014-08-21 | 1 | -1/+20 |
| | | | | | | | | Follow up to rails#15321 Instead of duplicating the routes, we will first match the HEAD request to HEAD routes. If no match is found, we will then map the HEAD request to GET routes. | ||||
* | Force encoding of US-ASCII to UTF-8 in unescape_uri. | Karl Entwistle | 2014-07-10 | 1 | -0/+5 |
| | | | | | | | | | Because URI paths may contain non US-ASCII characters we need to force the encoding of any unescaped URIs to UTF-8 if they are US-ASCII. This essentially replicates the functionality of the monkey patch to URI.parser.unescape in active_support/core_ext/uri.rb. Fixes #16104. | ||||
* | remove warnings | Kuldeep Aggarwal | 2014-06-12 | 1 | -2/+0 |
| | | | | warning: assigned but unused variable - scope_called, path and strexp | ||||
* | no more is_a checks on instantiation | Aaron Patterson | 2014-05-29 | 1 | -4/+0 |
| | |||||
* | Path::Pattern is instantiated internally, so make the contructor require a ↵ | Aaron Patterson | 2014-05-29 | 4 | -39/+43 |
| | | | | strexp object | ||||
* | Strexp#names is only used in a test, so rm | Aaron Patterson | 2014-05-29 | 1 | -32/+0 |
| | |||||
* | add an alternate constructor to Strexp that takes a string | Aaron Patterson | 2014-05-29 | 4 | -31/+31 |
| | |||||
* | Remove TODO. | Guo Xiang Tan | 2014-05-28 | 1 | -11/+1 |
| | |||||
* | pass the request object to the application | Aaron Patterson | 2014-05-25 | 1 | -2/+5 |
| | |||||
* | push is_a?(Dispatcher) check in to one place | Aaron Patterson | 2014-05-24 | 1 | -0/+1 |
| | |||||
* | glob_param is never used, so rm | Aaron Patterson | 2014-05-23 | 1 | -1/+5 |
| | | | | | | this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff). | ||||
* | decouple the router object from the request class | Aaron Patterson | 2014-05-23 | 1 | -14/+6 |
| | |||||
* | pass the correct custom request to the recognize method | Aaron Patterson | 2014-05-23 | 1 | -13/+10 |
| | |||||
* | switch to the `serve` method so we can remove the request class (eventually) | Aaron Patterson | 2014-05-23 | 1 | -2/+6 |
| |