Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use assert_empty and assert_not_empty | Daniel Colson | 2018-01-25 | 1 | -3/+3 |
| | |||||
* | Use assert_predicate and assert_not_predicate | Daniel Colson | 2018-01-25 | 1 | -1/+1 |
| | |||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 1 | -10/+10 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | use the mapper to build the routing table | Aaron Patterson | 2015-08-15 | 1 | -31/+14 |
| | | | | | | We should build the routes using the user facing API which is `Mapper`. This frees up the library internals to change as we see fit. IOW we shouldn't be testing internals. | ||||
* | only keep one hash of named routes | Aaron Patterson | 2015-08-14 | 1 | -8/+8 |
| | | | | | The outer router object already keeps a hash of named routes, so we should just use that. | ||||
* | rm add_route2 | Aaron Patterson | 2015-08-14 | 1 | -15/+19 |
| | | | | | refactor the tests with a backwards compatible method call so we can rm add_route2 from the journey router | ||||
* | remove Strexp | Aaron Patterson | 2015-08-13 | 1 | -5/+3 |
| | | | | | This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object. | ||||
* | pass anchor directly to `Pattern` | Aaron Patterson | 2015-08-13 | 1 | -2/+2 |
| | | | | | the caller already has it, there is no reason to pack it in to an object and just throw that object away. | ||||
* | extract required_defaults from the conditions hash before constructing the route | Aaron Patterson | 2015-06-08 | 1 | -9/+9 |
| | | | | | this way we can remove the strange "respond_to?" conditional in the `matches?` loop | ||||
* | Prefer assert_not over refute | Rafael Mendonça França | 2015-05-18 | 1 | -1/+1 |
| | |||||
* | ActionDispatch::Journey::Routes#empty? test cases | Valentine Valyaeff | 2015-05-19 | 1 | -0/+2 |
| | |||||
* | Merge pull request #15806 from tgxworld/partition_routes_during_setup | Aaron Patterson | 2015-03-02 | 1 | -0/+21 |
|\ | | | | | Partition routes during setup. | ||||
| * | Partition routes during setup. | Guo Xiang Tan | 2015-02-26 | 1 | -0/+21 |
| | | | | | | | | | | | | | | Partitioning of all the routes is currently being done during the first request. Since there is no need to clear the cache for `partitioned_routes` when adding a new route. We can move the partitioning of the routes during setup time. | ||||
* | | Remove unneeded comment. [ci skip] | Zoltan Kiss | 2015-03-02 | 1 | -1/+0 |
|/ | |||||
* | Path::Pattern is instantiated internally, so make the contructor require a ↵ | Aaron Patterson | 2014-05-29 | 1 | -4/+4 |
| | | | | strexp object | ||||
* | add an alternate constructor to Strexp that takes a string | Aaron Patterson | 2014-05-29 | 1 | -1/+1 |
| | |||||
* | Use ActiveSupport::TestCase in the journey tests | Rafael Mendonça França | 2012-12-31 | 1 | -1/+1 |
| | |||||
* | Alias refute methods to assert_not and perfer assert_not on tests | Rafael Mendonça França | 2012-12-31 | 1 | -2/+2 |
| | |||||
* | Integrate Journey into Action Dispatch | Andrew White | 2012-12-19 | 1 | -0/+53 |
Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49. |