Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make URL escaping more consistent | Andrew White | 2014-04-20 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | 1. Escape '%' characters in URLs - only unescaped data should be passed to URL helpers 2. Add an `escape_segment` helper to `Router::Utils` that escapes '/' characters 3. Use `escape_segment` rather than `escape_fragment` in optimized URL generation 4. Use `escape_segment` rather than `escape_path` in URL generation For point 4 there are two exceptions. Firstly, when a route uses wildcard segments (e.g. *foo) then we use `escape_path` as the value may contain '/' characters. This means that wildcard routes can't be optimized. Secondly, if a `:controller` segment is used in the path then this uses `escape_path` as the controller may be namespaced. Fixes #14629, #14636 and #14070. | ||||
* | Always escape string passed to url helper. | edogawaconan | 2014-04-20 | 1 | -2/+2 |
| | | | | | | | | | | Makes it clear that anything passed with the helper must not be percent encoded. Fixes previous behavior which tricks people into believing passing non-percent-encoded will generate a proper percent-encoded path while in reality it doesn't ('%' isn't escaped). The intention is nice but the heuristic is broken. | ||||
* | Correct error in Utils.normalize_path that changed paths improperly | Josh Symonds | 2013-10-23 | 1 | -0/+8 |
| | |||||
* | Use ActiveSupport::TestCase in the journey tests | Rafael Mendonça França | 2012-12-31 | 2 | -2/+2 |
| | |||||
* | Integrate Journey into Action Dispatch | Andrew White | 2012-12-19 | 2 | -0/+53 |
Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49. |