aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/journey/route_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Remove Route#build as it wasn't usedAlberto Almagro2019-05-221-21/+20
| | | | | | After @kamipo CR feedback we realized `Route#build` wasn't used. As it is also private API being able to create Routes both with `#new` and `#build` was redundant.
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Optimize Journey::Route#scoreBen Hughes2016-12-281-1/+1
| | | | | | | | Scoring routes based on constraints repeated many type conversions that could be performed in the outer loop. Determinations of score and fitness also used Array operations that required allocations. Against my benchmark with a large routeset, this reduced object allocations by over 30x and wall time by over 3x.
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-1/+1
|
* Add three new rubocop rulesRafael Mendonça França2016-08-161-7/+7
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* Fix broken alignments caused by auto-correct commit 411ccbdRyuta Kamizono2016-08-101-2/+4
| | | | Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
* remove redundant curlies from hash argumentsXavier Noria2016-08-061-18/+14
|
* modernizes hash syntax in actionpackXavier Noria2016-08-061-18/+18
|
* applies new string literal convention in actionpack/testXavier Noria2016-08-061-31/+31
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* routes are always constructed with a hash for the conditionsAaron Patterson2015-08-171-1/+1
|
* introduce an alternate constructor for Route objectsAaron Patterson2015-08-171-12/+12
| | | | | I want to change the real constructor to take a particular parameter for matching the request method
* default pattern to use a joined stringAaron Patterson2015-08-171-1/+1
| | | | | The string we create is almost always the same, so rather than joining all the time, lets join once, then reuse that string everywhere.
* remove StrexpAaron Patterson2015-08-131-2/+1
| | | | | This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object.
* pass anchor directly to `Pattern`Aaron Patterson2015-08-131-1/+1
| | | | | the caller already has it, there is no reason to pack it in to an object and just throw that object away.
* extract required_defaults from the conditions hash before constructing the routeAaron Patterson2015-06-081-13/+13
| | | | | this way we can remove the strange "respond_to?" conditional in the `matches?` loop
* Silence ambiguous first argument warningPrem Sichanugrist2015-05-041-1/+1
| | | | | | | This silences: actionpack/test/journey/route_test.rb:33: warning: ambiguous first argument; put parentheses or a space even after `/' operator
* Correct route requirements by overriding defaultls (fixes #18373)brainopia2015-01-081-0/+8
|
* Path::Pattern is instantiated internally, so make the contructor require a ↵Aaron Patterson2014-05-291-11/+11
| | | | strexp object
* Change the behavior of route defaultsAndrew White2013-01-151-5/+8
| | | | | | | | | | | | | | | | | | | This commit changes route defaults so that explicit defaults are no longer required where the key is not part of the path. For example: resources :posts, bucket_type: 'posts' will be required whenever constructing the url from a hash such as a functional test or using url_for directly. However using the explicit form alters the behavior so it's not required: resources :projects, defaults: { bucket_type: 'projects' } This changes existing behavior slightly in that any routes which only differ in their defaults will match the first route rather than the closest match. Closes #8814
* Use ActiveSupport::TestCase in the journey testsRafael Mendonça França2012-12-311-1/+1
|
* Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-311-1/+1
|
* Integrate Journey into Action DispatchAndrew White2012-12-191-0/+103
Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 16:12:53 +0000