aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/fixtures
Commit message (Collapse)AuthorAgeFilesLines
* Ensure LookupContext in Digestor selects correct variantPiotr Chmolowski2014-03-091-0/+3
| | | | | | | | | | Related to: #14242 #14243 14293 Variants passed to LookupContext#find() seem to be ignored, so I've used the setter instead: `finder.variants = [ variant ]`. I've also added some more test cases for variants. Hopefully this time passing tests will mean it actually works.
* Merge pull request #13470 from strzalek/variants-all-anyDavid Heinemeier Hansson2013-12-312-0/+2
|\ | | | | Add any/all support for variants
| * Add any/all support for variantsŁukasz Strzałkowski2013-12-262-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Like `format.any`, you can do the same with variants. It works for both inline: respond_to do |format| format.html.any { render text: "any" } format.html.phone { render text: "phone" } end and block syntax: respond_to do |format| format.html do |variant| variant.any(:tablet, :phablet){ render text: "any" } variant.phone { render text: "phone" } end end
* | Fix Encoding::CompatibilityError when public path is UTF-8Andrew White2013-12-295-0/+7
|/ | | | | | | | | | | | | | In #5337 we forced the path encoding to ASCII-8BIT to prevent static file handling from blowing up before an application has had chance to deal with possibly invalid urls. However this has a negative side effect of making it an incompatible encoding if the application's public path has UTF-8 characters in it. To work around the problem we check to see if the path has a valid encoding once it has been unescaped. If it is not valid then we can return early since it will not match any file anyway. Fixes #13518
* Inline variants syntaxŁukasz Strzałkowski2013-12-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | In most cases, when setting variant specific code, you're not sharing any code within format. Inline syntax can vastly simplify defining variants in those situations: respond_to do |format| format.js { render "trash" } format.html do |variant| variant.phone { redirect_to progress_path } variant.none { render "trash" } end end Becomes: respond_to do |format| format.js { render "trash" } format.html.phone { redirect_to progress_path } format.html.none { render "trash" } end
* Variants can be declared without a block to signify their presence in the ↵David Heinemeier Hansson2013-12-071-0/+1
| | | | controller
* Action Pack VariantsŁukasz Strzałkowski2013-12-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, variants in the templates will be picked up if a variant is set and there's a match. The format will be: app/views/projects/show.html.erb app/views/projects/show.html+tablet.erb app/views/projects/show.html+phone.erb If request.variant = :tablet is set, we'll automatically be rendering the html+tablet template. In the controller, we can also tailer to the variants with this syntax: class ProjectsController < ActionController::Base def show respond_to do |format| format.html do |html| @stars = @project.stars html.tablet { @notifications = @project.notifications } html.phone { @chat_heads = @project.chat_heads } end format.js format.atom end end end The variant itself is nil by default, but can be set in before filters, like so: class ApplicationController < ActionController::Base before_action do if request.user_agent =~ /iPad/ request.variant = :tablet end end end This is modeled loosely on custom mime types, but it's specifically not intended to be used together. If you're going to make a custom mime type, you don't need a variant. Variants are for variations on a single mime types.
* Fix header Content-Type: #<Mime::NullType:...> in localized templateAngelo capilleri2013-12-031-0/+1
| | | | | | | | This PR fixes #13064 regression bug introduced by the #8085 Now in _process_format when the format is a Mime::NullType nothing is written in self.content_type. In this way the method Response#assign_default_content_type_and_charset can write the the default mime_type.
* Fixing repond_with working directly on the options hashBlueHotDog2013-10-091-0/+0
| | | | | | | | This fixes an issue where the respond_with worked directly with the given options hash, so that if a user relied on it after calling respond_with, the hash wouldn't be the same. Fixes #12029
* Remove HelperyTestHelper not used in any testclaudiob2013-09-141-5/+0
| | | | | | HelperyTestHelper was introduced in 66ef922 by @josevalim to pair with HelperyTestController. This test controller was later removed in e10a253 by @strzalek, leaving HelperyTestHelper unused
* Remove helper fixtures not used in any testclaudiob2013-09-091-2/+0
| | | | | | The fixture for module AbcHelper defines three functions bare_a, bare_b and bare_c, but only bare_a is used in the code that tests helper functions.
* Move abstract's controller tests to AVŁukasz Strzałkowski2013-08-251-5/+0
| | | | The ones that were actually testing AV functionality and should belong in there
* Move remaining layouts tests to AVŁukasz Strzałkowski2013-08-259-8/+0
|
* Remove unused fixtures and models from AP testsŁukasz Strzałkowski2013-08-256-6/+0
|
* Move view_paths from AP to AVŁukasz Strzałkowski2013-08-252-2/+0
|
* Show real LoadError on helpers requirePiotr Niełacny2013-07-101-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing
* Remove digestor fixtures from APŁukasz Strzałkowski2013-06-2012-25/+0
| | | | They were moved to actionview/ and are not used in actionpack
* Remove unneeded test fixtures in AVPiotr Sarnacki2013-06-20108-281/+0
|
* Remove unneeded filesPiotr Sarnacki2013-06-201-49/+0
|
* Allow numbers in partial name for digestingBryan Ricker2013-05-061-1/+2
| | | | | | | | | | Add failing test for template with number at the end Use \w for RENDER_DEPENDENCY regex Spacing Add CHANGELOG entry
* Merge pull request #9857 from yyyc514/bad_params_should_400Aaron Patterson2013-04-301-0/+1
|\ | | | | failure to parse params should trigger a 400 Bad Request
| * failure to parse params should trigger a 400 Bad RequestJosh Goebel2013-03-211-0/+1
| |
* | Fix typo in view nameCarlos Antonio da Silva2013-04-031-0/+0
| | | | | | | | Introduced in 2c22376fe04b89e8f34620139720b85a85ce3428
* | Getting rid of a few other vestiges of rails.png.Steve Klabnik2013-04-021-0/+0
|/ | | | | | | | | | We don't actually need a rails.png in the AP fixtures, the tests that use it don't actually try to load the file. We also don't need to get rid of it with the dummy reset either. Finally, it's not needed in the sample application that's included with the Rails Guides.
* UTF-8 encode all keys and values in nested params hash.Teo Hui Ming2013-03-152-0/+10
|
* fix respond_to without blocks not working if one of the blocks is allgrosser2013-02-241-0/+1
|
* partials inside directory work with `assert_template`Yves Senn2013-02-042-0/+2
| | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
* Added AR integration tests for form helpersvirusman2013-01-211-0/+1
|
* Do not generate local vars for partials without object or collectionCarlos Antonio da Silva2013-01-081-0/+1
| | | | | | | | | Previously rendering a partial without giving :object or :collection would generate a local variable with the partial name by default. This was noticed due to warnings in Ruby 2.0 of not used variables, which turned out to be the generation of not used variables inside partials that do not contain objects related to them.
* Digestor explicit dependency should not contain trailing whitespaceBrian Alexander2012-12-211-1/+5
| | | | test for rails/rails#8586
* Add explicit opt-out for fragment cache digestingDrew Ulmer2012-11-251-0/+3
| | | | | | | | | This add support for sending an explicit opt-out of the "Russian-doll" cache digest feature on a case-by-case basis. This is useful when cache- expiration needs to be performed manually and it would be otherwise difficult to know the exact name of a digested cache key. More information: https://github.com/rails/cache_digests/pull/16
* Allow for deep directory path for view templates.Andy Shipman2012-10-112-0/+1
|
* recognizes when a partial was rendered twice. Closes #3675Yves Senn2012-10-111-0/+2
|
* `assert_template` no more passing with what ever string that matches.Hugo Roque2012-09-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing
* Merge pull request #7251 from rails/integrate-strong_parametersDavid Heinemeier Hansson2012-09-181-1/+0
|\ | | | | Integrate strong_parameters in Rails 4
| * Remove integration between attr_accessible/protected and ↵Guillermo Iguaran2012-09-161-1/+0
| | | | | | | | AC::Metal::ParamsWrapper
* | Rename .rb template handler to .ruby to avoid conflicts with mustache views ↵Guillermo Iguaran2012-09-171-0/+0
|/ | | | classes
* warning removed.Arun Agrawal2012-09-121-1/+0
| | | | | 1. Unused variable 2. possibly useless use of a variable in void context
* Add .rb template handlerGuillermo Iguaran2012-09-111-0/+3
| | | | This handler simply allows arbitrary Ruby code as a template
* `Digestor` can now parse old style hash syntax for `render`Christos Zisopoulos2012-08-301-0/+1
|
* `Digestor` ignores most whitespace when parsing `render` invocationsChristos Zisopoulos2012-08-302-0/+4
|
* Add automatic template digests to all CacheHelper#cache calls (originally ↵David Heinemeier Hansson2012-08-298-0/+14
| | | | spiked in the cache_digests plugin) *DHH*
* Indentation should consider line number character count.Lucas Uyezu2012-08-131-0/+13
|
* Remove deprecation warning, since scoped waas deprecatedRafael Mendonça França2012-07-291-1/+1
|
* Remove deprecation warningsCarlos Galdino + Rafael Mendonça França2012-07-212-2/+2
|
* Common behavior with adding formats to lookup_context for TemplateRenderer ↵Dmitry Vorotilin2012-07-187-0/+7
| | | | and PartialRenderer
* Remove more tests related to draw external routes filesRafael Mendonça França2012-06-292-2/+0
| | | | Related with 5e7d6bba79393de0279917f93b82f3b7b176f4b5
* Respect absolute paths in compute_source_path.Steve Klabnik2012-06-161-0/+3
| | | | | | | | | | | | | | | | When using compute_source_path to determine the full path of an asset, if our source begins with '/', we don't want to include the directory. Examples are illustrative: > compute_source_path("foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/stylesheets/foo.css" > compute_source_path("/foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/foo.css" Before this patch, the second example would return the same as the first. Fixes #5680.
* Fix sorting of helpers from different pathsPiotr Sarnacki2012-05-282-0/+10
| | | | | | | | | | | | | | | | When more than one directory for helpers is provided to a controller, it should preserver the order of directories. Given 2 paths: MyController.helpers_paths = ["dir1/helpers", "dir2/helpers"] helpers from dir1 should be loaded first. Before this commit, all helpers were mixed and then sorted alphabetically, which essentially would require to rename helpers to get desired order. This is a problem especially for engines, where you would like to be able to predict accurately which engine helpers will load first. (closes #6496)
* Merge pull request #6309 from steveklabnik/fix-2394José Valim2012-05-172-0/+2
|\ | | | | Created a Raw handler for templates.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 04:50:30 +0000