| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| | |
Update Rails::Railtie::Configuration and ActionDispatch::Response#respond_to? to accept include_private argument
|
| | |
| |
| |
| | |
ActionDispatch::Response#respond_to? to accept include_private argument
|
| |/ |
|
| |
|
|
|
|
|
| |
Allow REMOTE_ADDR, HTTP_HOST and HTTP_USER_AGENT to be overridden from
the environment passed into `ActionDispatch::TestRequest.new`.
Fixes #11590
|
| |
|
|
|
|
|
|
|
|
| |
When generating an unnamed url (i.e. using `url_for` with an options
hash) we should skip anything other than standard Rails routes otherwise
it will match the first mounted application or redirect and generate a
url with query parameters rather than raising an error if the options
hash doesn't match any defined routes.
Fixes #8018
|
| |
|
|
|
|
|
|
| |
In order to get raw_post to be not empty after
ParamsParser#parse_formatted_parameters,
added rewinding of body stream input on parsing json params.
Closes #11345
|
| |\
| |
| | |
Cleanup ul_encoded_params_parsing_test
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| |\
| |
| | |
Flag cookies as secure with ignore case in ActionDispatch::SSL
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously when app was mounted as following:
class Foo
def call(env)
[200, {}, [env['PATH_INFO']]]
end
end
RackMountRailsBug::Application.routes.draw do
mount RackTest.new => "/foo"
end
trailing slash was removed from PATH_INFO. For example requesting
GET /foo/bar/
on routes defined above would result in a response containing "/foo/bar"
instead of "/foo/bar/".
This commit fixes the issue.
(closes #3215)
|
| |
|
|
|
|
| |
We are setting this header to chrome=1 for Chrome Frame and this will be
retired soon. Check http://blog.chromium.org/2013/06/retiring-chrome-frame.html for
details
|
| |
|
|
| |
were deprecated.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When named route that is nested is used in 3.2.13
Example `routes.rb`:
```
resources :nested do
resources :builder, :controller => 'nested/builder'
end
```
In 3.2.12 and 3.2.12 this named route would work:
```
nested_builder_path(:last_step, :nested_id => "foo")
```
Generating a url that looks like `/nested/foo/builder/last_step`. This PR fixes the regression when building urls via the optimized helper. Any explicit keys set in the options are removed from the list of implicitly mapped keys.
Not sure if this is exactly how the original version worked, but this fixes this use case regression.
|
| | |
|
| | |
|
| |\
| |
| | |
failure to parse params should trigger a 400 Bad Request
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Add support for extracting the port from the :host option and for
removing the subdomain by using nil, false or ''.
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
leading .)
Adding a boolean route constraint checks for presence/absence of request property
|
| |\ \
| | |
| | |
| | |
| | | |
trevorturk/remove-fixme-comments-about-legacy-key-generator
Remove comments about removing LegacyKeyGenerator in 4.1
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
routing bugfixes when matching multiple paths
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #9913.
We need to expand the match shorthand syntax for every path.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This problem was introduced with:
https://github.com/rails/rails/commit/d03aa104e069be4e301efa8cefb90a2a785a7bff
|
| | |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
Closes #10071
`#normalize_path!` depends on the options so we need to call
`#normalize_options!` first to make sure everything is set correctly.
|
| |\ \ \
| | | |
| | | | |
Rename DummyKeyGenerator -> LegacyKeyGenerator
|
| | | | | |
|
| |/ / / |
|
| | | | |
|
| |/ /
| |
| |
| | |
Automatically configure cookie-based sessions to use the best cookie jar given the app's config
|
| | | |
|
| | |
| |
| |
| |
| | |
* Fix named route collision in mount test fixture
* Update controller named route precedence test
|
| | |
| |
| |
| | |
signed cookies generated by Rails 3 to avoid invalidating them when upgrading to Rails 4
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the host in `default_url_options` is accidentally set with a protocol such as
```
host: "http://example.com"
```
then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention.
This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host.
I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted.
This is based off of work in #7415 cc/ @pixeltrix
ATP Action Mailer and Action Pack
|
| |\
| |
| | |
multipart POST - utf8 param name not encoded
|
| | | |
|
| |/
|
|
|
|
|
|
|
| |
The env hash passed to `Http::Headers#new` must be in env format.
Also be aware that the passed hash is modified directly.
docs and test-cases for setting headers/env in functional tests.
Follow up to #9700.
|
| | |
|
| |
|
|
| |
Closes #6513.
|
