Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Replace multi_json with json | Erik Michaels-Ober | 2013-05-11 | 1 | -1/+1 |
| | |||||
* | Fix failing AP test | Carlos Antonio da Silva | 2013-05-01 | 1 | -1/+1 |
| | |||||
* | Merge pull request #9857 from yyyc514/bad_params_should_400 | Aaron Patterson | 2013-04-30 | 1 | -0/+6 |
|\ | | | | | failure to parse params should trigger a 400 Bad Request | ||||
| * | failure to parse params should trigger a 400 Bad Request | Josh Goebel | 2013-03-21 | 1 | -0/+6 |
| | | |||||
* | | Add test for `format: false` with resources - closes #10323 | Andrew White | 2013-04-24 | 1 | -0/+29 |
| | | |||||
* | | Return a 405 response for unknown HTTP methods | Lewis Marshall | 2013-04-22 | 2 | -0/+12 |
| | | |||||
* | | Refactor ActionDispatch::Http::URL.build_host_url | Andrew White | 2013-04-18 | 1 | -0/+41 |
| | | | | | | | | | | Add support for extracting the port from the :host option and for removing the subdomain by using nil, false or ''. | ||||
* | | Add url generation tests for #10185 | Andrew White | 2013-04-18 | 1 | -0/+2 |
| | | |||||
* | | Passing subdomain: '' to url_for removes the subdomain (instead of adding a ↵ | Derek Watson | 2013-04-18 | 1 | -0/+20 |
| | | | | | | | | | | | | leading .) Adding a boolean route constraint checks for presence/absence of request property | ||||
* | | Merge pull request #10074 from ↵ | Rafael Mendonça França | 2013-04-03 | 2 | -2/+0 |
|\ \ | | | | | | | | | | | | | trevorturk/remove-fixme-comments-about-legacy-key-generator Remove comments about removing LegacyKeyGenerator in 4.1 | ||||
| * | | Remove comments about removing LegacyKeyGenerator in 4.1 | Trevor Turk | 2013-04-03 | 2 | -2/+0 |
| | | | |||||
* | | | Merge pull request #9932 from senny/9913_routing_problem | Andrew White | 2013-04-03 | 1 | -0/+29 |
|\ \ \ | | | | | | | | | routing bugfixes when matching multiple paths | ||||
| * | | | routing shorthand syntax works with multiple paths | Yves Senn | 2013-03-26 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | Closes #9913. We need to expand the match shorthand syntax for every path. | ||||
| * | | | bugfix, when matching multiple paths with `get`, `post`, ... | Yves Senn | 2013-03-26 | 1 | -0/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | This problem was introduced with: https://github.com/rails/rails/commit/d03aa104e069be4e301efa8cefb90a2a785a7bff | ||||
* | | | | fix regression in Mapper when `format:` was used in a `scope`. | Yves Senn | 2013-04-03 | 1 | -0/+22 |
| |/ / |/| | | | | | | | | | | | | | | | | | Closes #10071 `#normalize_path!` depends on the options so we need to call `#normalize_options!` first to make sure everything is set correctly. | ||||
* | | | Merge pull request #10061 from trevorturk/dummy-key-generator-rename | Santiago Pastorino | 2013-04-02 | 2 | -8/+8 |
|\ \ \ | | | | | | | | | Rename DummyKeyGenerator -> LegacyKeyGenerator | ||||
| * | | | Rename DummyKeyGenerator -> LegacyKeyGenerator | Trevor Turk | 2013-04-02 | 2 | -8/+8 |
| | | | | |||||
* | | | | Fix permanent cookie jar accessor typo | Trevor Turk | 2013-04-02 | 1 | -1/+6 |
|/ / / | |||||
* | | | Fixed typo on AP dispatch Mime::Type test | KalabiYau | 2013-04-01 | 1 | -1/+1 |
| | | | |||||
* | | | Allow transparent upgrading of legacy signed cookies to encrypted cookies; ↵ | Trevor Turk | 2013-03-28 | 1 | -2/+73 |
|/ / | | | | | | | Automatically configure cookie-based sessions to use the best cookie jar given the app's config | ||||
* | | Skipping test for OpenSSL::PKCS5 JRuby | Arun Agrawal | 2013-03-25 | 1 | -0/+10 |
| | | |||||
* | | Update tests for #9704, named route collisions | Jeremy Kemper | 2013-03-24 | 1 | -1/+1 |
| | | | | | | | | | | * Fix named route collision in mount test fixture * Update controller named route precedence test | ||||
* | | Introduce UpgradeLegacySignedCookieJar to transparently upgrade existing ↵ | Trevor Turk | 2013-03-24 | 1 | -0/+55 |
| | | | | | | | | signed cookies generated by Rails 3 to avoid invalidating them when upgrading to Rails 4 | ||||
* | | Raise an ArgumentError when a clashing named route is defined | Trevor Turk | 2013-03-19 | 1 | -19/+18 |
|/ | |||||
* | Fix improperly configured host in generated urls | schneems | 2013-03-19 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | | | | If the host in `default_url_options` is accidentally set with a protocol such as ``` host: "http://example.com" ``` then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention. This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host. I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted. This is based off of work in #7415 cc/ @pixeltrix ATP Action Mailer and Action Pack | ||||
* | Merge pull request #5606 from teohm/multipart_unicode_param_name | Steve Klabnik | 2013-03-15 | 1 | -1/+20 |
|\ | | | | | multipart POST - utf8 param name not encoded | ||||
| * | UTF-8 encode all keys and values in nested params hash. | Teo Hui Ming | 2013-03-15 | 1 | -1/+20 |
| | | |||||
* | | `Http::Headers` directly modifies the passed environment. | Yves Senn | 2013-03-15 | 1 | -6/+16 |
|/ | | | | | | | | | The env hash passed to `Http::Headers#new` must be in env format. Also be aware that the passed hash is modified directly. docs and test-cases for setting headers/env in functional tests. Follow up to #9700. | ||||
* | `Http::Headers` respects dotted env vars, symbols, headers with numbers. | Yves Senn | 2013-03-13 | 1 | -0/+27 |
| | |||||
* | allow headers and env to be passed in `IntegrationTest`. | Yves Senn | 2013-03-13 | 1 | -1/+44 |
| | | | | Closes #6513. | ||||
* | refactor, `Http::Headers` stores headers in env notation | Yves Senn | 2013-03-13 | 1 | -12/+21 |
| | | | | | Also: cleanup, use consistent syntax for `Http::Header` and test. | ||||
* | Http::Headers respects headers that are not prefixed with HTTP_ | Yves Senn | 2013-03-13 | 1 | -6/+13 |
| | |||||
* | Change from each to each_value on hash to avoid unused variable warning | Vipul A M | 2013-03-11 | 1 | -1/+1 |
| | |||||
* | Fix formats on xhr requests when HTTP_ACCEPT is empty string | maximerety | 2013-03-04 | 1 | -0/+5 |
| | | | | | | Fix ActionDispatch::Request#formats on xhr requests when HTTP_ACCEPT header is empty string. About issue #7774, same fix as in commit bebb02f but for xhr requests. | ||||
* | Use custom visitor class for optimized url helpers | Andrew White | 2013-03-03 | 1 | -0/+6 |
| | | | | | | | | Rather than trying to use gsub to remove the optional route segments, which will fail with nested optional segments, use a custom visitor class that returns a empty string for group nodes. Closes #9524 | ||||
* | `format: true` does not override existing format constraints. | Yves Senn | 2013-02-27 | 1 | -0/+24 |
| | | | | | | | Closes #9466. Passing `format: true` used to override the constraints: { format: /json/ } with `/.+/`. This patch only sets the format if there is no constraint present. | ||||
* | allow non-String default params in the router. | Yves Senn | 2013-02-26 | 1 | -1/+21 |
| | | | | | | | Closes #9435. Skip valid encoding checks for non-String parameters that come from the matched route's defaults. | ||||
* | the router allows String contraints. | Yves Senn | 2013-02-26 | 1 | -0/+36 |
| | | | | Closes #9432. | ||||
* | determine the match shorthand target early. | Yves Senn | 2013-02-21 | 1 | -0/+27 |
| | | | | | | | | Closes #7554. This patch determines the `controller#action` directly in the `match` method when the shorthand syntax is used. this prevents problems with namespaces and scopes. | ||||
* | Remove XML Parser from ActionDispatch | Prem Sichanugrist | 2013-02-20 | 1 | -182/+0 |
| | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem. | ||||
* | InvalidMessage is in ActiveSupport::MessageEncryptor namespace | Santiago Pastorino | 2013-02-19 | 1 | -3/+18 |
| | | | | Closes #9302 | ||||
* | Fix AP tests related to routes inspector output and the new column titles | Carlos Antonio da Silva | 2013-02-19 | 1 | -20/+65 |
| | |||||
* | Merge pull request #8704 from senny/remove_regexp_global_from_url_for | Aaron Patterson | 2013-02-14 | 1 | -0/+3 |
|\ | | | | | replace regexp global in #url_for | ||||
| * | replace regexp global in #url_for | Yves Senn | 2013-01-16 | 1 | -0/+3 |
| | | |||||
* | | the `:controller` option for routes can contain numbers. closes #9231. | Yves Senn | 2013-02-09 | 1 | -0/+12 |
| | | |||||
* | | ruby constant syntax is not supported as routing `:controller` option. | Yves Senn | 2013-02-06 | 1 | -9/+40 |
| | | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide. | ||||
* | | Add 'X-UA-Compatible' => 'chrome=1' to default headers | Guillermo Iguaran | 2013-01-29 | 1 | -1/+3 |
| | | |||||
* | | Remove BestStandardsSupport middleware | Guillermo Iguaran | 2013-01-29 | 1 | -35/+0 |
| | | |||||
* | | Use Encoding::UTF_8 constant :do_not_litter: | Akira Matsuda | 2013-01-28 | 1 | -1/+1 |
| | | |||||
* | | add fetch to CookieJar | Aaron Patterson | 2013-01-27 | 1 | -0/+30 |
| | |