| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix broken IPv6 addresses handling
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The following Rails code failed (with a `KeyError` exception) under
test:
```ruby
class ApplicationController < ActionController::Base
def user_strategy
# At this point:
# ```ruby
# session == {
# "user_strategy"=>"email",
# "user_identifying_value"=>"hello@world.com"
# }
# ```
if session.key?(:user_strategy)
session.fetch(:user_strategy)
end
end
end
```
When I checked the session's keys (`session.keys`), I got an array of
strings. If I accessed `session[:user_strategy]` I got the expected
`'email'` value. However if I used `session.fetch(:user_strategy)` I
got a `KeyError` exception.
This appears to be a Rails 4.2.4 regression (as the code works under
Rails 4.2.3).
Closes #21383
|
|\ \
| | |
| | | |
Get rid of mocha tests in actionpack - part 2
|
| | | |
|
| | | |
|
|/ / |
|
|\ \
| | |
| | | |
Get rid of mocha tests in actionpack - part 1
|
| | | |
|
|/ /
| |
| |
| |
| | |
This commit allows us to use one request object rather than allocating
multiple request objects to deal with the session.
|
| | |
|
| |
| |
| |
| |
| | |
I'm going to change the constructor, so it's easier to do it in one
place.
|
| | |
|
| |
| |
| |
| |
| | |
nobody should be touching the routes hash without going through the
NamedRouteCollection object.
|
| | |
|
| |
| |
| |
| |
| | |
then we can let the mapping object derive stuff that the Route object
needs.
|
| |
| |
| |
| |
| | |
now that we aren't doing options manipulations, we can just pass the
mapping object down and read values from it.
|
| | |
|
| |
| |
| |
| |
| | |
now we don't need to add it to a hash and delete it from the hash later
just to pass it around
|
| |
| |
| |
| |
| | |
`add_route` needs the AST, so rather than shove it in a hash and delete
later, lets move parsing up the stack so we can pass down later
|
| |
| |
| |
| |
| | |
also change the feeler to subclass AD::Request so that it has all the
methods that Request has
|
| | |
|
| |
| |
| |
| | |
Eventually I want to eliminate the FakeSet test class
|
| |
| |
| |
| |
| | |
I'm going to reimplement this using route objects, so it will be easier
if we just change ast access to go through a method rather than hashes
|
| |
| |
| |
| | |
we don't need to keep adding it and deleting if from hashes.
|
| | |
|
| |
| |
| |
| | |
the caller already has access to `as`, so we can stop passing it around.
|
| |
| |
| |
| |
| |
| | |
the same value that is extracted from the options hash earlier is
returned, so we don't need to pass it in in the first place. The caller
already has the data, so stop passing it around.
|
| |
| |
| |
| |
| | |
this way we don't have to mutate the options hash so far away from where
the user passed it in
|
| |
| |
| |
| |
| |
| | |
The `anchor` parameter [is overridden](https://github.com/rails/rails/blob/b4b4a611d0eb9aa1c640c5f521c6a43bf2a65bab/actionpack/lib/action_dispatch/routing/mapper.rb#L1528) unless it
is directly passed to `match`, so setting it in a scope must be a
mistake.
|
| |
| |
| |
| | |
this reduces the number of times we have to mutate the options hash.
|
| |
| |
| |
| | |
This just ensures that `format` is applied to things inside the scope
|
| | |
|
| |
| |
| |
| |
| | |
Eventually we don't want to expose the "options" hash from scope, only
read values from it. Lets start by adding a reader method.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
We're going to try pulling this up further, and check `via` validity
sooner. This way we don't have to do a bunch of processing on `options`
hashes only to find out that the route is incorrect
|
| |
| |
| |
| |
| | |
this way we don't have to insert / delete it from the options hash so
many times.
|
| |
| |
| |
| |
| | |
I think we can find the original place where `action` is added to the
options hash now.
|
| |
| |
| |
| |
| |
| | |
we want to try to pull this logic up to where the user actually passed
in "controller" so that it's close to the related call. That way when
we're down the stack, we don't need to wonder "why are we doing this?"
|
|\ \
| | |
| | | |
Allow a custom dispatcher to be provided to routing.
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Using the string version of the class reference is now deprecated when
referencing middleware. This should be written as a class not as a string.
Deprecation warning that this change fixes:
```
DEPRECATION WARNING: Passing strings or symbols to the middleware
builder is deprecated, please change
them to actual class references. For example:
"ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions
```
|
| |
| |
| |
| |
| | |
since we only work with instances of classes, it greatly simplifies the
`Middleware` implementation.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Convert things like this:
middleware.use "Foo::Bar"
to this:
middleware.use Foo::Bar
|
| |
| |
| |
| |
| |
| | |
We should do the hard work outside the constructor. Also fix the tests
to not directly construct middleware objects, but to go through the
stack object.
|
| |
| |
| |
| |
| |
| | |
ExceptionWrapper only cares about the backtrace cleaner, so lets just
pass the cleaner to the wrapper. It does not need to know that env
exists or what key the backtrace cleaner is stored in
|
| | |
|
|\ \
| | |
| | | |
Fix Encoding::UndefinedConversionError with multibyte UTF-8 filename containing "%" character
|
| | | |
|