aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Remove symbolized_path_parameters.Guo Xiang Tan2014-07-021-2/+2
| | | | This pull request is a continuation of https://github.com/rails/rails/commit/925bd975 and https://github.com/rails/rails/commit/8d8ebe3d.
* Fix typoRafael Mendonça França2014-07-021-1/+1
|
* Fix request's path_info when a rack app mounted at '/'.Larry Lv2014-06-141-0/+7
| | | | Fixes issue #15511.
* Merge pull request #15530 from zuhao/refactor_actionpack_reloader_testMatthew Draper2014-06-061-0/+5
|\ | | | | Reset callbacks after test.
| * Reset callbacks after test.Zuhao Wan2014-06-051-0/+5
| | | | | | | | Otherwise the state of callback chain is leaked.
* | Merge pull request #15532 from zuhao/refactor_actionpack_response_testYves Senn2014-06-051-2/+4
|\ \ | | | | | | Restore Response.default_headers after test.
| * | Restore Response.default_headers after test.Zuhao Wan2014-06-051-2/+4
| | |
* | | Avoid hard-coded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/ /
* | Merge pull request #15529 from zuhao/refactor_actionpack_mime_type_testYves Senn2014-06-051-2/+0
|\ \ | |/ |/| Make sure Mime::Type is not altered after tests.
| * Mime::PNG is already defined.Zuhao Wan2014-06-051-2/+0
| |
* | Avoid hardcoded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/
* Merge pull request #15349 from tgxworld/remove_duplicated_method_callRafael Mendonça França2014-06-031-4/+1
|\ | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
| * Remove duplicated HashWithIndifferentAccess#with_indifferent_access.Guo Xiang Tan2014-05-261-4/+1
| |
* | Routes specifying 'to:' must be a string that contains a "#" or a rackAaron Patterson2014-06-032-24/+32
| | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`.
* | use the factory method to construct the mappingAaron Patterson2014-06-031-1/+1
| |
* | add tests for mixing :to and controller / actionAaron Patterson2014-06-031-0/+48
| |
* | test with an empty viaAaron Patterson2014-06-031-0/+8
| |
* | add a test for missing "via" parameterAaron Patterson2014-06-031-0/+8
| |
* | Mapping never actually uses @set, so rmAaron Patterson2014-05-291-1/+1
| |
* | use a parser to extract the group parts from the pathAaron Patterson2014-05-291-2/+2
| |
* | "controllers" should be a valid path nameAaron Patterson2014-05-291-0/+10
| |
* | add a test for controllers without colonsAaron Patterson2014-05-281-0/+10
| |
* | add a test for existing mapper functionalityAaron Patterson2014-05-281-0/+12
| | | | | | | | | | I'm not sure if this is actually used, but I'm adding a test to define the behavior
* | add tests for argument error casesAaron Patterson2014-05-281-0/+27
| |
* | Skip individual tests upon Dalli::RingErrorMatthew Draper2014-05-271-0/+18
|/ | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem.
* Merge pull request #14986 from dlangevin/trailing-slash-url-generationRafael Mendonça França2014-05-241-0/+18
|\ | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb
| * Fixes URL generation with trailing_slash: trueDan Langevin2014-05-221-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash
* | extract request allocation from the main app serving routineAaron Patterson2014-05-231-0/+1
| |
* | use the request object since we have itAaron Patterson2014-05-231-5/+3
| | | | | | | | | | stop hardcoding hash keys and use the accessors provided on the request object.
* | stop using PARAMETERS_KEY, and use the accessor on the request objectAaron Patterson2014-05-221-0/+3
| | | | | | | | this decouples our code from the env hash a bit.
* | Form full URI as string to be parsed in Rack::Test.Guo Xiang Tan2014-05-211-6/+6
| | | | | | | | There are performance gains to be made by avoiding URI setter methods.
* | Add RFC4791 MKCALENDAR methodkasper2014-05-151-2/+3
| |
* | Remove unused method in RouteSet test.Guo Xiang Tan2014-05-151-4/+0
| |
* | this class is a model, so it should act like oneAaron Patterson2014-05-121-0/+3
| |
* | Always use the provided port for protocol relative urlsAndrew White2014-05-111-0/+12
| | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided.
* | HTTP::Headers#key? correctly convertsschneems2014-05-071-0/+2
|/ | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence
* Use assert_raisesRafael Mendonça França2014-05-041-3/+1
|
* Merge pull request #11166 from xavier/callable_constraint_verificationRafael Mendonça França2014-05-041-0/+15
|\ | | | | | | | | | | | | Callable route constraint verification Conflicts: actionpack/CHANGELOG.md
| * Verify that route constraints respond to the expected messages instead of ↵Xavier Defrang2013-06-281-0/+15
| | | | | | | | silently failing to enforce the constraint
* | Merge pull request #12651 from cespare/ipv6-remote-ip-fixesRafael Mendonça França2014-05-011-1/+4
|\ \ | | | | | | | | | | | | | | | | | | Make remote_ip detection properly handle private IPv6 addresses Conflicts: actionpack/CHANGELOG.md
| * | Make remote_ip detection properly handle private IPv6 addressesCaleb Spare2013-10-261-1/+4
| | | | | | | | | | | | Fixes #12638.
* | | Fixed an issue with migrating legacy json cookies.Godfrey Chan2014-04-231-0/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming cookies are marshal-encoded. This is not the case when `secret_token` is used in conjunction with the `:json` or `:hybrid` serializer. In those case, when upgrading to use `secret_key_base`, this would cause a `TypeError: incompatible marshal file format` and a 500 error for the user. Fixes #14774. *Godfrey Chan*
* | | Make URL escaping more consistentAndrew White2014-04-201-3/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Escape '%' characters in URLs - only unescaped data should be passed to URL helpers 2. Add an `escape_segment` helper to `Router::Utils` that escapes '/' characters 3. Use `escape_segment` rather than `escape_fragment` in optimized URL generation 4. Use `escape_segment` rather than `escape_path` in URL generation For point 4 there are two exceptions. Firstly, when a route uses wildcard segments (e.g. *foo) then we use `escape_path` as the value may contain '/' characters. This means that wildcard routes can't be optimized. Secondly, if a `:controller` segment is used in the path then this uses `escape_path` as the controller may be namespaced. Fixes #14629, #14636 and #14070.
* | | Change the method descriptionRafael Mendonça França2014-04-171-1/+1
| | |
* | | Merge pull request #14755 from timlinquist/to_io_http_uploadRafael Mendonça França2014-04-171-0/+6
|\ \ \ | | | | | | | | | | | | Use common to_io so users can access the underlying IO object
| * | | Provide interface for accessing underlying IO objectTim Linquist2014-04-151-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | In some cases users may need to work with/manipulate more of the Tempfile api than provided by Upload. Allow users to get at the underlying io via the common to_io method of IO/IO-like objects
* | | | Display diagnostics in text format for xhr requestVlad Bokov2014-04-141-1/+2
|/ / /
* | | Add a failing test for a URL helper that was broken by a6b9ea2.James Coglan2014-04-101-0/+18
| | |
* | | Avoid URI parsingAndriel Nuernberg2014-04-091-0/+7
| | | | | | | | | | | | | | | This parsing is unecessary once the Request object already has the needed information.
* | | Append link to bad code to backtrace when exception is SyntaxErrorBoris Kuznetsov2014-03-271-0/+35
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 18:41:52 +0000