Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #15530 from zuhao/refactor_actionpack_reloader_test | Matthew Draper | 2014-06-06 | 1 | -0/+5 |
|\ | | | | | Reset callbacks after test. | ||||
| * | Reset callbacks after test. | Zuhao Wan | 2014-06-05 | 1 | -0/+5 |
| | | | | | | | | Otherwise the state of callback chain is leaked. | ||||
* | | Merge pull request #15532 from zuhao/refactor_actionpack_response_test | Yves Senn | 2014-06-05 | 1 | -2/+4 |
|\ \ | | | | | | | Restore Response.default_headers after test. | ||||
| * | | Restore Response.default_headers after test. | Zuhao Wan | 2014-06-05 | 1 | -2/+4 |
| | | | |||||
* | | | Avoid hard-coded value in test setup/teardown. | Zuhao Wan | 2014-06-05 | 1 | -1/+2 |
|/ / | |||||
* | | Merge pull request #15529 from zuhao/refactor_actionpack_mime_type_test | Yves Senn | 2014-06-05 | 1 | -2/+0 |
|\ \ | |/ |/| | Make sure Mime::Type is not altered after tests. | ||||
| * | Mime::PNG is already defined. | Zuhao Wan | 2014-06-05 | 1 | -2/+0 |
| | | |||||
* | | Avoid hardcoded value in test setup/teardown. | Zuhao Wan | 2014-06-05 | 1 | -1/+2 |
|/ | |||||
* | Merge pull request #15349 from tgxworld/remove_duplicated_method_call | Rafael Mendonça França | 2014-06-03 | 1 | -4/+1 |
|\ | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | ||||
| * | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | Guo Xiang Tan | 2014-05-26 | 1 | -4/+1 |
| | | |||||
* | | Routes specifying 'to:' must be a string that contains a "#" or a rack | Aaron Patterson | 2014-06-03 | 2 | -24/+32 |
| | | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`. | ||||
* | | use the factory method to construct the mapping | Aaron Patterson | 2014-06-03 | 1 | -1/+1 |
| | | |||||
* | | add tests for mixing :to and controller / action | Aaron Patterson | 2014-06-03 | 1 | -0/+48 |
| | | |||||
* | | test with an empty via | Aaron Patterson | 2014-06-03 | 1 | -0/+8 |
| | | |||||
* | | add a test for missing "via" parameter | Aaron Patterson | 2014-06-03 | 1 | -0/+8 |
| | | |||||
* | | Mapping never actually uses @set, so rm | Aaron Patterson | 2014-05-29 | 1 | -1/+1 |
| | | |||||
* | | use a parser to extract the group parts from the path | Aaron Patterson | 2014-05-29 | 1 | -2/+2 |
| | | |||||
* | | "controllers" should be a valid path name | Aaron Patterson | 2014-05-29 | 1 | -0/+10 |
| | | |||||
* | | add a test for controllers without colons | Aaron Patterson | 2014-05-28 | 1 | -0/+10 |
| | | |||||
* | | add a test for existing mapper functionality | Aaron Patterson | 2014-05-28 | 1 | -0/+12 |
| | | | | | | | | | | I'm not sure if this is actually used, but I'm adding a test to define the behavior | ||||
* | | add tests for argument error cases | Aaron Patterson | 2014-05-28 | 1 | -0/+27 |
| | | |||||
* | | Skip individual tests upon Dalli::RingError | Matthew Draper | 2014-05-27 | 1 | -0/+18 |
|/ | | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem. | ||||
* | Merge pull request #14986 from dlangevin/trailing-slash-url-generation | Rafael Mendonça França | 2014-05-24 | 1 | -0/+18 |
|\ | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb | ||||
| * | Fixes URL generation with trailing_slash: true | Dan Langevin | 2014-05-22 | 1 | -0/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash | ||||
* | | extract request allocation from the main app serving routine | Aaron Patterson | 2014-05-23 | 1 | -0/+1 |
| | | |||||
* | | use the request object since we have it | Aaron Patterson | 2014-05-23 | 1 | -5/+3 |
| | | | | | | | | | | stop hardcoding hash keys and use the accessors provided on the request object. | ||||
* | | stop using PARAMETERS_KEY, and use the accessor on the request object | Aaron Patterson | 2014-05-22 | 1 | -0/+3 |
| | | | | | | | | this decouples our code from the env hash a bit. | ||||
* | | Form full URI as string to be parsed in Rack::Test. | Guo Xiang Tan | 2014-05-21 | 1 | -6/+6 |
| | | | | | | | | There are performance gains to be made by avoiding URI setter methods. | ||||
* | | Add RFC4791 MKCALENDAR method | kasper | 2014-05-15 | 1 | -2/+3 |
| | | |||||
* | | Remove unused method in RouteSet test. | Guo Xiang Tan | 2014-05-15 | 1 | -4/+0 |
| | | |||||
* | | this class is a model, so it should act like one | Aaron Patterson | 2014-05-12 | 1 | -0/+3 |
| | | |||||
* | | Always use the provided port for protocol relative urls | Andrew White | 2014-05-11 | 1 | -0/+12 |
| | | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided. | ||||
* | | HTTP::Headers#key? correctly converts | schneems | 2014-05-07 | 1 | -0/+2 |
|/ | | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence | ||||
* | Use assert_raises | Rafael Mendonça França | 2014-05-04 | 1 | -3/+1 |
| | |||||
* | Merge pull request #11166 from xavier/callable_constraint_verification | Rafael Mendonça França | 2014-05-04 | 1 | -0/+15 |
|\ | | | | | | | | | | | | | Callable route constraint verification Conflicts: actionpack/CHANGELOG.md | ||||
| * | Verify that route constraints respond to the expected messages instead of ↵ | Xavier Defrang | 2013-06-28 | 1 | -0/+15 |
| | | | | | | | | silently failing to enforce the constraint | ||||
* | | Merge pull request #12651 from cespare/ipv6-remote-ip-fixes | Rafael Mendonça França | 2014-05-01 | 1 | -1/+4 |
|\ \ | | | | | | | | | | | | | | | | | | | Make remote_ip detection properly handle private IPv6 addresses Conflicts: actionpack/CHANGELOG.md | ||||
| * | | Make remote_ip detection properly handle private IPv6 addresses | Caleb Spare | 2013-10-26 | 1 | -1/+4 |
| | | | | | | | | | | | | Fixes #12638. | ||||
* | | | Fixed an issue with migrating legacy json cookies. | Godfrey Chan | 2014-04-23 | 1 | -0/+117 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming cookies are marshal-encoded. This is not the case when `secret_token` is used in conjunction with the `:json` or `:hybrid` serializer. In those case, when upgrading to use `secret_key_base`, this would cause a `TypeError: incompatible marshal file format` and a 500 error for the user. Fixes #14774. *Godfrey Chan* | ||||
* | | | Make URL escaping more consistent | Andrew White | 2014-04-20 | 1 | -3/+25 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Escape '%' characters in URLs - only unescaped data should be passed to URL helpers 2. Add an `escape_segment` helper to `Router::Utils` that escapes '/' characters 3. Use `escape_segment` rather than `escape_fragment` in optimized URL generation 4. Use `escape_segment` rather than `escape_path` in URL generation For point 4 there are two exceptions. Firstly, when a route uses wildcard segments (e.g. *foo) then we use `escape_path` as the value may contain '/' characters. This means that wildcard routes can't be optimized. Secondly, if a `:controller` segment is used in the path then this uses `escape_path` as the controller may be namespaced. Fixes #14629, #14636 and #14070. | ||||
* | | | Change the method description | Rafael Mendonça França | 2014-04-17 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #14755 from timlinquist/to_io_http_upload | Rafael Mendonça França | 2014-04-17 | 1 | -0/+6 |
|\ \ \ | | | | | | | | | | | | | Use common to_io so users can access the underlying IO object | ||||
| * | | | Provide interface for accessing underlying IO object | Tim Linquist | 2014-04-15 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | In some cases users may need to work with/manipulate more of the Tempfile api than provided by Upload. Allow users to get at the underlying io via the common to_io method of IO/IO-like objects | ||||
* | | | | Display diagnostics in text format for xhr request | Vlad Bokov | 2014-04-14 | 1 | -1/+2 |
|/ / / | |||||
* | | | Add a failing test for a URL helper that was broken by a6b9ea2. | James Coglan | 2014-04-10 | 1 | -0/+18 |
| | | | |||||
* | | | Avoid URI parsing | Andriel Nuernberg | 2014-04-09 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | This parsing is unecessary once the Request object already has the needed information. | ||||
* | | | Append link to bad code to backtrace when exception is SyntaxError | Boris Kuznetsov | 2014-03-27 | 1 | -0/+35 |
| | | | |||||
* | | | Cleaning and adding tests for Session | Attila Domokos | 2014-03-19 | 1 | -7/+34 |
| | | | | | | | | | Adding tests for Session `destroy`, `update` and `delete` methods. No changes for code under test. | ||||
* | | | Add an explicit require for 4ece124396669d3580e7f229ab407a0d4882727a rather ↵ | Jeremy Kemper | 2014-03-16 | 1 | -0/+1 |
| | | | | | | | | | | | | than assume SecureRandom is available | ||||
* | | | Avoid concurrent test collision on the same memcache server by namespacing keys | Jeremy Kemper | 2014-03-16 | 1 | -1/+1 |
| | | |