| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We should be asking the mime type method for the mime objects rather
than via const lookup
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We don't want to manage a list of constants on `Mime::`. Managing
constants is strange because it will break method caches, not to mention
looking up by a constant could cause troubles. For example suppose
there is a top level constant `HTML`, but nobody registers the HTML mime
type and someone accesses `Mime::HTML`. Instead of getting an error
about how the mime type doesn't exist, instead you'll get the top level
constant.
So, instead of directly accessing the constants, change this:
Mime::HTML
To this:
Mime::Type[:HTML]
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
SSL redirect:
* Move `:host` and `:port` options within `redirect: { … }`. Deprecate.
* Introduce `:status` and `:body` to customize the redirect response.
The 301 permanent default makes it difficult to test the redirect and
back out of it since browsers remember the 301. Test with a 302 or 307
instead, then switch to 301 once you're confident that all is well.
HTTP Strict Transport Security (HSTS):
* Shorter max-age. Shorten the default max-age from 1 year to 180 days,
the low end for https://www.ssllabs.com/ssltest/ grading and greater
than the 18-week minimum to qualify for browser preload lists.
* Disabling HSTS. Setting `hsts: false` now sets `hsts: { expires: 0 }`
instead of omitting the header. Omitting does nothing to disable HSTS
since browsers hang on to your previous settings until they expire.
Sending `{ hsts: { expires: 0 }}` flushes out old browser settings and
actually disables HSTS:
http://tools.ietf.org/html/rfc6797#section-6.1.1
* HSTS Preload. Introduce `preload: true` to set the `preload` flag,
indicating that your site may be included in browser preload lists,
including Chrome, Firefox, Safari, IE11, and Edge. Submit your site:
https://hstspreload.appspot.com
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
converts old ID methods to the new abstract store methods in Rack
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
With changes made in 8363b8 and ae29142 cookies that are mutated on the
request like `cookies.signed = x` were not retained in subsequent tests,
breaking cookie authentiation in controller tests.
The test added demonstrates the issue.
The reason we need to select from non-deleted cookies is because without
checking the `@delete_cookies` the `cookie_jar` `@cookies` will send the
wrong cookies to be updated. The code must check for `@deleted_cookies`
before sending an `#update` with the requests cookie_jar cookies.
This follows how the cookie_jar cookies from the request were updated
before these changes.
|
|\ \ \ \
| | | | |
| | | | | |
Fix broken IPv6 addresses handling
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The following Rails code failed (with a `KeyError` exception) under
test:
```ruby
class ApplicationController < ActionController::Base
def user_strategy
# At this point:
# ```ruby
# session == {
# "user_strategy"=>"email",
# "user_identifying_value"=>"hello@world.com"
# }
# ```
if session.key?(:user_strategy)
session.fetch(:user_strategy)
end
end
end
```
When I checked the session's keys (`session.keys`), I got an array of
strings. If I accessed `session[:user_strategy]` I got the expected
`'email'` value. However if I used `session.fetch(:user_strategy)` I
got a `KeyError` exception.
This appears to be a Rails 4.2.4 regression (as the code works under
Rails 4.2.3).
Closes #21383
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Get rid of mocha tests in actionpack - part 2
|
| | | | | | |
|
| | | | | | |
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Get rid of mocha tests in actionpack - part 1
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
This commit allows us to use one request object rather than allocating
multiple request objects to deal with the session.
|
| | | | | |
|
| |_|/ /
|/| | |
| | | |
| | | |
| | | | |
I'm going to change the constructor, so it's easier to do it in one
place.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
nobody should be touching the routes hash without going through the
NamedRouteCollection object.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
then we can let the mapping object derive stuff that the Route object
needs.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
now that we aren't doing options manipulations, we can just pass the
mapping object down and read values from it.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
now we don't need to add it to a hash and delete it from the hash later
just to pass it around
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`add_route` needs the AST, so rather than shove it in a hash and delete
later, lets move parsing up the stack so we can pass down later
|
| | | |
| | | |
| | | |
| | | |
| | | | |
also change the feeler to subclass AD::Request so that it has all the
methods that Request has
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Eventually I want to eliminate the FakeSet test class
|
| | | |
| | | |
| | | |
| | | |
| | | | |
I'm going to reimplement this using route objects, so it will be easier
if we just change ast access to go through a method rather than hashes
|
| | | |
| | | |
| | | |
| | | | |
we don't need to keep adding it and deleting if from hashes.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
the caller already has access to `as`, so we can stop passing it around.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
the same value that is extracted from the options hash earlier is
returned, so we don't need to pass it in in the first place. The caller
already has the data, so stop passing it around.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
this way we don't have to mutate the options hash so far away from where
the user passed it in
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The `anchor` parameter [is overridden](https://github.com/rails/rails/blob/b4b4a611d0eb9aa1c640c5f521c6a43bf2a65bab/actionpack/lib/action_dispatch/routing/mapper.rb#L1528) unless it
is directly passed to `match`, so setting it in a scope must be a
mistake.
|
| | | |
| | | |
| | | |
| | | | |
this reduces the number of times we have to mutate the options hash.
|
| | | |
| | | |
| | | |
| | | | |
This just ensures that `format` is applied to things inside the scope
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Eventually we don't want to expose the "options" hash from scope, only
read values from it. Lets start by adding a reader method.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We're going to try pulling this up further, and check `via` validity
sooner. This way we don't have to do a bunch of processing on `options`
hashes only to find out that the route is incorrect
|
| | | |
| | | |
| | | |
| | | |
| | | | |
this way we don't have to insert / delete it from the options hash so
many times.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
I think we can find the original place where `action` is added to the
options hash now.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
we want to try to pull this logic up to where the user actually passed
in "controller" so that it's close to the related call. That way when
we're down the stack, we don't need to wonder "why are we doing this?"
|
|\ \ \ \
| | | | |
| | | | | |
Allow a custom dispatcher to be provided to routing.
|
| | | | | |
|