Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Reset the request parameters after a constraints check | Andrew White | 2012-05-02 | 1 | -0/+19 |
| | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. | ||||
* | Enable ActionDispatch::Http::Headers to support fetch | Mark Turner | 2012-05-02 | 1 | -0/+5 |
| | |||||
* | Dont stream back cookie value if it was set to the same value | brainopia | 2012-04-30 | 1 | -0/+12 |
| | |||||
* | Dont set cookie header for deletion of unexisting data | brainopia | 2012-04-30 | 1 | -8/+24 |
| | |||||
* | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 1 | -1/+32 |
| | |||||
* | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 1 | -0/+29 |
| | |||||
* | Fix the build | Yehuda Katz | 2012-04-25 | 1 | -1/+2 |
| | |||||
* | Merge pull request #5980 from gazay/valid_ips | Jeremy Kemper | 2012-04-25 | 1 | -20/+114 |
|\ | | | | | Remote ip logic and validation. IPv6 support. | ||||
| * | Valid ips v4 and v6. Right logic for working with X-FORWARDED-FOR header and ↵ | Alexey Gaziev | 2012-04-25 | 1 | -20/+114 |
| | | | | | | | | tests. | ||||
* | | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 13 | -87/+87 |
|/ | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | adds delegetion for eof? to AD::Http::UploadedFile | Jens Fahnenbruck | 2012-03-27 | 1 | -0/+6 |
| | | | | | if you want to read the file you may need to ask if there is something to read from | ||||
* | Allow a defining custom member field on resources | Jamie Macey | 2012-03-25 | 1 | -0/+18 |
| | | | | | | | | | | By default, resources routes are created with :resource/:id. A model defining to_param can make prettier urls by using something more readable than an integer ID, but since the route picks it up as :id you wind up with awkward User.find_by_username(params[:id]) calls. By overriding the key to be used in @request.params you can be more obvious in your intent. | ||||
* | Fix secure cookies when there are more than one space before the secure | Rafael Mendonça França | 2012-03-19 | 1 | -0/+28 |
| | | | | keyword | ||||
* | Remove exclude option from ActionDispatch::SSL | Rafael Mendonça França | 2012-03-19 | 1 | -6/+0 |
| | |||||
* | Some refactoring and update ActionDispatch::SSL code to use the Rack 1.4.x | Rafael Mendonça França | 2012-03-17 | 1 | -14/+0 |
| | |||||
* | Rack::SSL -> ActionDispatch::SSL | Rafael Mendonça França | 2012-03-17 | 1 | -0/+149 |
| | |||||
* | fix ArgumentError being raised in case of invalid byte sequences | Michael Reinsch | 2012-03-08 | 1 | -0/+4 |
| | |||||
* | Refactor AD::UploadedFile, and raise sooner if tempfile is not present | Carlos Antonio da Silva | 2012-03-06 | 1 | -1/+1 |
| | |||||
* | Added parsing of arbitrary media type parameters. | Steve Klabnik | 2012-03-05 | 1 | -0/+6 |
| | | | | | | Based on #4918. Related to #4127. | ||||
* | Merge pull request #5219 from ↵ | Aaron Patterson | 2012-02-29 | 1 | -0/+12 |
|\ | | | | | | | | | mattfawcett/2781-fix-querystring-route-constraint-for-testing Fix for #2781 | ||||
| * | Fix the assert_recognizes test method so that it works when there are | Matt Fawcett | 2012-02-24 | 1 | -0/+12 |
| | | | | | | | | constraints on the querystring. Issue #2781 | ||||
* | | Remove wrong and redundant code. | kennyj | 2012-02-25 | 1 | -6/+4 |
| | | |||||
* | | uses PATCH for the forms of persisted records, and routes PATCH and PUT to ↵ | Xavier Noria | 2012-02-24 | 1 | -0/+8 |
|/ | | | | the update action of resources | ||||
* | Merge pull request #5119 from kennyj/fix_5114 | Aaron Patterson | 2012-02-22 | 1 | -0/+26 |
|\ | | | | | Testcase for GH #5114. | ||||
| * | Testcase for GH #5114. | kennyj | 2012-02-22 | 1 | -0/+26 |
| | | |||||
* | | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -4/+11 |
|/ | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | ||||
* | Remove fixture files with Windows incompatible filenames | Andrew White | 2012-02-20 | 1 | -26/+88 |
| | | | | | | Windows doesn't allow `\ / : * ? " < > |` in filenames so create the fixture files at runtime and ignore the incompatible ones when running on Windows. | ||||
* | Fix ActionDispatch::Static to serve files with unencoded PCHAR | Andrew White | 2012-02-17 | 1 | -2/+26 |
| | | | | | | | | | | | RFC 3986[1] allows sub-delim characters in path segments unencoded, however Rack::File requires them to be encoded so we use URI's unescape method to leave them alone and then escape them again. Also since the path gets passed to Dir[] we need to escape any glob characters in the path. [1]: http://www.ietf.org/rfc/rfc3986.txt | ||||
* | escape static file path to prevent double unescaping | Sergey Nartimov | 2012-02-16 | 1 | -0/+4 |
| | |||||
* | ActionDispatch: add missing test for callbacks | Bogdan Gusiev | 2012-02-16 | 1 | -2/+9 |
| | |||||
* | fixing AP tests | Aaron Patterson | 2012-02-15 | 1 | -1/+1 |
| | |||||
* | say goodbye to #with_test_routes :axe: | Xavier Noria | 2012-02-10 | 1 | -1166/+947 |
| | |||||
* | fixes a regression introduced by 532cd4, and a bogus test in AP the ↵ | Xavier Noria | 2012-02-10 | 1 | -6/+6 |
| | | | | regression uncovered | ||||
* | Fix GH #4720. Routing problem with nested namespace and already camelized ↵ | kennyj | 2012-02-10 | 1 | -0/+26 |
| | | | | controller option. | ||||
* | Fix failing request test | Carlos Antonio da Silva | 2012-02-07 | 1 | -1/+1 |
| | | | | | | | | Latest changes in remote ip handling conflicted with each other in tests. Related: dd09811fa6214a130fdc2de1d4c00b4337cb15f9 6a720226aad2adffcbd2422d40db772719579e2f | ||||
* | Merge pull request #2490 from gsterndale/x_forwarded_for_order | José Valim | 2012-02-07 | 1 | -4/+4 |
|\ | | | | | The first IP address in the X-Forwarded-For header is the originating IP | ||||
| * | The first IP address in the X-Forwarded-For header is the originating IP | Greg Sterndale | 2012-02-07 | 1 | -4/+4 |
| | | |||||
* | | Merge pull request #2632 from gsterndale/replace_trusted_proxies | José Valim | 2012-02-07 | 1 | -2/+13 |
|\ \ | | | | | | | Trusted proxies are configurable | ||||
| * | | Trusted proxies is replaced with a Regexp or appended to with a String | Greg Sterndale | 2012-02-07 | 1 | -2/+13 |
| |/ | |||||
* / | Failing test case that shows issue #736 should still be open. | Scott W. Bradley | 2012-02-06 | 1 | -0/+6 |
|/ | |||||
* | Fix url_for method's behavior when it is called with :controller option ↵ | kennyj | 2012-02-07 | 1 | -0/+33 |
| | | | | | | which starts with "/" from multiple nested controller. Closes #3864 | ||||
* | Revert "Deprecated multi args to http route methods" | Jeremy Kemper | 2012-02-05 | 1 | -2/+1 |
| | | | | | | | | | | Too painful to lose the compact shorthand form! This reverts commit e848c52535fa0f9488cdbdb3f1cedc7c7c02d643. Conflicts: actionpack/lib/action_dispatch/routing/mapper.rb | ||||
* | Add testcase for non english filename. Related to #2982. | kennyj | 2012-02-05 | 1 | -1/+6 |
| | |||||
* | Fix GH #4873. Allow swapping middleware of same class | kennyj | 2012-02-04 | 1 | -0/+6 |
| | |||||
* | Remove not used env[] call in routing_test. | Carlos Antonio da Silva | 2012-01-27 | 1 | -1/+0 |
| | | | The commit 4c321c6d42b6e35f9ead12eb1dccdead03c5abf4 removes the path_params variable assignment, actually the entire line is not used at all. | ||||
* | Fix warning. assigned but unused variable - path_params | kennyj | 2012-01-28 | 1 | -1/+1 |
| | |||||
* | Merge pull request #4658 from pwim/unicode-paths | Aaron Patterson | 2012-01-25 | 1 | -0/+20 |
| | | | | Test for unicode path support | ||||
* | Deprecated multi args to http route methods | Aaron Patterson | 2012-01-23 | 1 | -1/+2 |
| | |||||
* | ActionDispatch::Cookies::CookieJar#deleted? predicate method. | Paul Annesley | 2012-01-24 | 1 | -0/+11 |
| | | | | | Necessary in controller tests to determine if the CookieJar will delete the given cookie. | ||||
* | Removed unused assigns from ActionView::Template::Error | brainopia | 2012-01-20 | 2 | -2/+2 |
| | | | | | They existed since initial rails commit by DHH but lost use a long time ago |