aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/dispatch
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Fix duplicated test.Guo Xiang Tan2014-07-181-2/+6
| | | | | | | | | | | | | | | There is already another test covering Request#request_method. This test should cover Request#method.
| * | Update test to clearly reflect what it is testing for.Guo Xiang Tan2014-07-181-5/+7
| | |
| * | Update outdated test.Guo Xiang Tan2014-07-181-6/+3
| | | | | | | | | | | | | | | The current test is asserting against an outdated version of Request#method where HEAD requests are treated as GET requests.
* | | Add CHANGELOG for #14886Arthur Neves2014-07-181-1/+1
| | | | | | | | | | | | | | | | | | | | | Also cleanup test a bit [related #14886] [related #14743]
* | | LOCALHOST definition should match any 127.0.0.0/8 addressEarl J St Sauver2014-07-181-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The entire 127.0.0.0/8 range is assigned to the loopback address, not only 127.0.0.0/24. This patch allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8 loopback address. The only place that the #local? method was previously under test was in the show_expectations_test.rb file. I don't particularly like that that's implicitly where this code is under test, and I feel like I should move some of that testing code into the test/dispatch/request_test.rb file, but I wanted some feedback first. Credit goes to @sriedel for discovering the issue and adding the patch.
* | | Rails-ish apps should descend from Rails::RailtieAaron Patterson2014-07-162-5/+12
| | | | | | | | | | | | | | | Use an is_a check to ensure it's a Railsish app so we can avoid respond_to calls everywhere.
* | | always transcode the file to utf-8Aaron Patterson2014-07-161-0/+6
| | | | | | | | | | | | | | | | | | people may be passing filenames to the constructor that are not utf-8, but they will assome that calling `original_filename` returns utf-8 (because that's what it used to do).
* | | RouteSet should be in charge of constructing the dispatherAaron Patterson2014-07-151-2/+2
| | | | | | | | | | | | Now we can override how requests are dispatched in the routeset object
* | | Stash original path in `ShowExceptions` middlewareGrey Baker2014-07-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActionDispatch::ShowExceptions` overwrites `PATH_INFO` with the status code for the exception defined in `ExceptionWrapper`, so the path the user was visiting when an exception occurred was not previously available to any custom exceptions_app. The original `PATH_INFO` is now stashed in `env["action_dispatch.original_path"]`.
* | | Merge pull request #13999 from jamox/update_rackAaron Patterson2014-07-082-7/+17
|\ \ \ | |/ / |/| | This updates rails to use edge rack
| * | Upgraded rackJarmo Isotalo2014-05-192-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | As Rack has some non backwards compatible changes added required modifications to keep behaviour in rails close to same as before. Also modified generators to include rack/rack for not yet released version of rack
* | | always test against a routed rack app so there are always url_helpersAaron Patterson2014-07-074-35/+65
| | |
* | | Generate shallow paths for all children of shallow resources.Seb Jacobs2014-07-061-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this commit shallow resources would only generate paths for non-direct children (with a nested depth greater than 1). Take the following routes file. resources :blogs do resources :posts, shallow: true do resources :comments do resources :tags end end end This would generate shallow paths for `tags` nested under `posts`, e.g `/posts/:id/tags/`, however it would not generate shallow paths for `comments` nested under `posts`, e.g `/posts/:id/comments/new`. This commit changes the behaviour of the route mapper so that it generate paths for direct children of shallow resources, for example if you take the previous routes file, this will now generate shallow paths for `comments` nested under `posts`, .e.g `posts/:id/comments/new`. This was the behaviour in Rails `4.0.4` however this was broken in @jcoglan's fix for another routes related issue[1]. This also fixes an issue[2] reported by @smdern. [1] https://github.com/rails/rails/commit/d0e5963 [2] https://github.com/rails/rails/issues/15783
* | | Remove symbolized_path_parameters.Guo Xiang Tan2014-07-021-2/+2
| | | | | | | | | | | | This pull request is a continuation of https://github.com/rails/rails/commit/925bd975 and https://github.com/rails/rails/commit/8d8ebe3d.
* | | Fix typoRafael Mendonça França2014-07-021-1/+1
| | |
* | | Fix request's path_info when a rack app mounted at '/'.Larry Lv2014-06-141-0/+7
| | | | | | | | | | | | Fixes issue #15511.
* | | Merge pull request #15530 from zuhao/refactor_actionpack_reloader_testMatthew Draper2014-06-061-0/+5
|\ \ \ | | | | | | | | Reset callbacks after test.
| * | | Reset callbacks after test.Zuhao Wan2014-06-051-0/+5
| | | | | | | | | | | | | | | | Otherwise the state of callback chain is leaked.
* | | | Merge pull request #15532 from zuhao/refactor_actionpack_response_testYves Senn2014-06-051-2/+4
|\ \ \ \ | | | | | | | | | | Restore Response.default_headers after test.
| * | | | Restore Response.default_headers after test.Zuhao Wan2014-06-051-2/+4
| | | | |
* | | | | Avoid hard-coded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/ / / /
* | | | Merge pull request #15529 from zuhao/refactor_actionpack_mime_type_testYves Senn2014-06-051-2/+0
|\ \ \ \ | |/ / / |/| | | Make sure Mime::Type is not altered after tests.
| * | | Mime::PNG is already defined.Zuhao Wan2014-06-051-2/+0
| | | |
* | | | Avoid hardcoded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/ / /
* | | Merge pull request #15349 from tgxworld/remove_duplicated_method_callRafael Mendonça França2014-06-031-4/+1
|\ \ \ | | | | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
| * | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.Guo Xiang Tan2014-05-261-4/+1
| | | |
* | | | Routes specifying 'to:' must be a string that contains a "#" or a rackAaron Patterson2014-06-032-24/+32
| | | | | | | | | | | | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`.
* | | | use the factory method to construct the mappingAaron Patterson2014-06-031-1/+1
| | | |
* | | | add tests for mixing :to and controller / actionAaron Patterson2014-06-031-0/+48
| | | |
* | | | test with an empty viaAaron Patterson2014-06-031-0/+8
| | | |
* | | | add a test for missing "via" parameterAaron Patterson2014-06-031-0/+8
| | | |
* | | | Mapping never actually uses @set, so rmAaron Patterson2014-05-291-1/+1
| | | |
* | | | use a parser to extract the group parts from the pathAaron Patterson2014-05-291-2/+2
| | | |
* | | | "controllers" should be a valid path nameAaron Patterson2014-05-291-0/+10
| | | |
* | | | add a test for controllers without colonsAaron Patterson2014-05-281-0/+10
| | | |
* | | | add a test for existing mapper functionalityAaron Patterson2014-05-281-0/+12
| | | | | | | | | | | | | | | | | | | | I'm not sure if this is actually used, but I'm adding a test to define the behavior
* | | | add tests for argument error casesAaron Patterson2014-05-281-0/+27
| | | |
* | | | Skip individual tests upon Dalli::RingErrorMatthew Draper2014-05-271-0/+18
|/ / / | | | | | | | | | | | | | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem.
* | | Merge pull request #14986 from dlangevin/trailing-slash-url-generationRafael Mendonça França2014-05-241-0/+18
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb
| * | | Fixes URL generation with trailing_slash: trueDan Langevin2014-05-221-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash
* | | | extract request allocation from the main app serving routineAaron Patterson2014-05-231-0/+1
| | | |
* | | | use the request object since we have itAaron Patterson2014-05-231-5/+3
| | | | | | | | | | | | | | | | | | | | stop hardcoding hash keys and use the accessors provided on the request object.
* | | | stop using PARAMETERS_KEY, and use the accessor on the request objectAaron Patterson2014-05-221-0/+3
| | | | | | | | | | | | | | | | this decouples our code from the env hash a bit.
* | | | Form full URI as string to be parsed in Rack::Test.Guo Xiang Tan2014-05-211-6/+6
| |/ / |/| | | | | | | | There are performance gains to be made by avoiding URI setter methods.
* | | Add RFC4791 MKCALENDAR methodkasper2014-05-151-2/+3
| | |
* | | Remove unused method in RouteSet test.Guo Xiang Tan2014-05-151-4/+0
| | |
* | | this class is a model, so it should act like oneAaron Patterson2014-05-121-0/+3
| | |
* | | Always use the provided port for protocol relative urlsAndrew White2014-05-111-0/+12
| | | | | | | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided.
* | | HTTP::Headers#key? correctly convertsschneems2014-05-071-0/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence
* | Use assert_raisesRafael Mendonça França2014-05-041-3/+1
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 05:42:52 +0000