Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix bug when url_for changes controller. | Nikita Beloglazov | 2012-11-16 | 1 | -0/+9 |
| | |||||
* | Merge pull request #8093 from nikitug/keep_app_x_ua_compatible | Carlos Antonio da Silva | 2012-11-08 | 1 | -0/+34 |
| | | | | | | | Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header) Conflicts: actionpack/CHANGELOG.md | ||||
* | backport, handle trailing slash with engines | Yves Senn | 2012-11-08 | 1 | -0/+5 |
| | | | | this is a backport of #8115 to fix #7842 | ||||
* | Add test to avoid regression of 4a86362 | Rafael Mendonça França | 2012-11-02 | 1 | -0/+10 |
| | |||||
* | Revert "Merge pull request #7668 from Draiken/fix_issue_6497" | Rafael Mendonça França | 2012-11-02 | 1 | -7/+0 |
| | | | | | | | | | This reverts commit 61d5d2d8a97fd289b81991cd79dca3112e7ca135. Conflicts: actionpack/CHANGELOG.md REASON: This added a backward incompatible change. | ||||
* | Merge pull request #7789 from senny/7777_resource_functions_modify_options | Rafael Mendonça França | 2012-10-01 | 1 | -0/+20 |
| | | | | resource and resources do no longer modify passed options | ||||
* | Since File instance doesn't respond to #open use a double to test the | Rafael Mendonça França | 2012-09-30 | 1 | -1/+1 |
| | | | | behavior added at c53e5def08f7a289a92a8e5f79dcd7caa5c3a2fb | ||||
* | Merge pull request #7668 from Draiken/fix_issue_6497 | Rafael Mendonça França | 2012-09-19 | 1 | -0/+7 |
| | | | | | | Removing to_shorthand to fix #6497 Conflicts: actionpack/CHANGELOG.md | ||||
* | Fix bug when Rails.application is defined but is nil. See #881 | Marc-Andre Lafortune | 2012-08-28 | 1 | -0/+7 |
| | |||||
* | Test actual content of permanent cookie | brainopia | 2012-08-10 | 1 | -1/+1 |
| | |||||
* | Dont stream back cookie value if it was set to the same value | brainopia | 2012-08-10 | 1 | -1/+13 |
| | |||||
* | Add support for optional root segments containing slashes | Andrew White | 2012-07-17 | 1 | -0/+26 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optional segments with a root scope need to have the leading slash outside of the parentheses, otherwise the generated url will be empty. However if the route has non-optional elements then the leading slash needs to remain inside the parentheses otherwise the generated url will have two leading slashes, e.g: Blog::Application.routes.draw do get '/(:category)', :to => 'posts#index', :as => :root get '/(:category)/author/:name', :to => 'posts#author', :as => :author end $ rake routes root GET /(:category)(.:format) posts#index author GET (/:category)/author/:name(.:format) posts#author This change adds support for optional segments that contain a slash, allowing support for urls like /page/2 for the root path, e.g: Blog::Application.routes.draw do get '/(page/:page)', :to => 'posts#index', :as => :root end $ rake routes root GET /(page/:page)(.:format) posts#index Fixes #7073 (cherry picked from commit d8745decaf59aad32aa2f09abdba99b8d0e48b31) | ||||
* | Array parameters should not contain nil values. | Aaron Patterson | 2012-06-11 | 1 | -0/+4 |
| | |||||
* | Strip [nil] from parameters hash. | Aaron Patterson | 2012-05-30 | 1 | -1/+6 |
| | | | | | | Thanks to Ben Murphy for reporting this! CVE-2012-2660 | ||||
* | Don't ignore nil positional arguments for url helpers - fixes #6196. | Andrew White | 2012-05-10 | 1 | -0/+34 |
| | |||||
* | Reset the request parameters after a constraints check | Andrew White | 2012-05-03 | 1 | -0/+19 |
| | | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. (cherry picked from commit 56030506563352944fed12a6bb4793bb2462094b) | ||||
* | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 1 | -1/+40 |
| | |||||
* | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 1 | -0/+28 |
| | |||||
* | Fix the redirect when it receive blocks with arity of 1. | Rafael Mendonça França | 2012-03-31 | 1 | -0/+15 |
| | | | | Closes #5677 | ||||
* | fix ArgumentError being raised in case of invalid byte sequences | Michael Reinsch | 2012-03-08 | 1 | -0/+4 |
| | |||||
* | Fix some warnings on 3-2-stable | kennyj | 2012-02-21 | 1 | -1/+0 |
| | |||||
* | Remove fixture files with Windows incompatible filenames | Andrew White | 2012-02-20 | 1 | -27/+88 |
| | | | | | | Windows doesn't allow `\ / : * ? " < > |` in filenames so create the fixture files at runtime and ignore the incompatible ones when running on Windows. | ||||
* | Fix ActionDispatch::Static to serve files with unencoded PCHAR | Andrew White | 2012-02-17 | 1 | -0/+28 |
| | | | | | | | | | | | RFC 3986[1] allows sub-delim characters in path segments unencoded, however Rack::File requires them to be encoded so we use URI's unescape method to leave them alone and then escape them again. Also since the path gets passed to Dir[] we need to escape any glob characters in the path. [1]: http://www.ietf.org/rfc/rfc3986.txt | ||||
* | backporting #4918 to 3.2 stable; adding extra test for accept header given ↵ | Aditya Sanghi | 2012-02-17 | 1 | -0/+12 |
| | | | | by googlebot | ||||
* | Merge pull request #4988 from kennyj/fix_4720-3 | Aaron Patterson | 2012-02-10 | 1 | -0/+26 |
| | | | | Fix GH #4720. Routing problem with nested namespace and already camelized controller option. | ||||
* | Merge pull request #4908 from kennyj/fix_3864 | José Valim | 2012-02-06 | 1 | -0/+33 |
| | | | | Fix url_for method's behavior. GH #3684. | ||||
* | Merge pull request #4879 from kennyj/fix_4873 | José Valim | 2012-02-04 | 1 | -0/+6 |
| | | | | Fix GH #4873. Allow swapping same class middleware. | ||||
* | Test for unicode path support | Paul McMahon | 2012-01-25 | 1 | -0/+20 |
| | | | | This is currently broken due to a bug in journey. | ||||
* | Deprecate AC::UnknownError and AC::DoubleRenderError | Carlos Antonio da Silva | 2012-01-17 | 2 | -3/+3 |
| | | | | | Use the constants AbstractController::ActionNotFound and AbstractController::DoubleRenderError respectively instead. | ||||
* | Merge pull request #4462 from spohlenz/fix-routing-tests | Aaron Patterson | 2012-01-16 | 1 | -0/+4 |
| | | | | Stub ip method of alternative request class in router tests | ||||
* | Use a BodyProxy instead of including a Module that responds to close. | Santiago Pastorino | 2012-01-13 | 1 | -1/+12 |
| | | | | Closes #4441 if Active Record is disabled assets are delivered correctly | ||||
* | Add original_fullpath and original_url methods to Request | Piotr Sarnacki | 2012-01-10 | 1 | -0/+24 |
| | |||||
* | Override respond_to? since we are also overriding method_missing. | José Valim | 2012-01-03 | 1 | -0/+7 |
| | |||||
* | deprecate ActiveSupport::Base64 | Sergey Nartimov | 2012-01-03 | 1 | -4/+4 |
| | | | | extend and define ::Base64 if needed | ||||
* | last named route wins. fixes #4164 | Aaron Patterson | 2011-12-28 | 1 | -1/+1 |
| | | | | | | This differs from route recognition where first recognized route wins. This will not be supported in Rails 4.0 so that route recognition and generation rules are consistent. | ||||
* | adding tests for #4029 | Aaron Patterson | 2011-12-19 | 1 | -1/+1 |
| | |||||
* | Add test for register_alias | Justin Campbell | 2011-12-17 | 1 | -0/+9 |
| | |||||
* | Add test for type aliases | Justin Campbell | 2011-12-17 | 1 | -0/+11 |
| | |||||
* | Allow symbols to be passed for extension aliases | Justin Campbell | 2011-12-17 | 1 | -0/+11 |
| | |||||
* | Do not raise an exception if an invalid route was generated automatically. | José Valim | 2011-12-16 | 1 | -0/+1 |
| | |||||
* | ShowExceptions should understand X-Cascade responses from exceptions app. | José Valim | 2011-12-16 | 1 | -0/+11 |
| | |||||
* | Improve the specs on exceptions app. | José Valim | 2011-12-16 | 1 | -1/+14 |
| | |||||
* | Extract the rendering of public exceptions pages into a Rack app. | José Valim | 2011-12-16 | 1 | -1/+1 |
| | |||||
* | Get rid of the close checks since we cannot reliably close the session anyway. | José Valim | 2011-12-16 | 1 | -97/+1 |
| | |||||
* | Warning removed "warning: (...) interpreted as grouped expression" | Arun Agrawal | 2011-12-16 | 1 | -1/+1 |
| | |||||
* | Close the response body on cascade pass, closes #3975. | José Valim | 2011-12-14 | 1 | -3/+22 |
| | |||||
* | log exception backtrace when all backtrace lines silenced | Sergey Nartimov | 2011-12-13 | 1 | -0/+13 |
| | |||||
* | Fix failing AP tests. | José Valim | 2011-12-13 | 1 | -1/+1 |
| | |||||
* | use Array#join so that file encoding doesn't impact returned string. | Aaron Patterson | 2011-12-12 | 1 | -0/+9 |
| | | | | Fixes #3957 | ||||
* | Speed up development by only reloading classes if dependencies files changed. | José Valim | 2011-12-12 | 1 | -0/+9 |
| | | | | | | | | This can be turned off by setting `config.reload_classes_only_on_change` to false. Extensions like Active Record should add their respective files like db/schema.rb and db/structure.sql to `config.watchable_files` if they want their changes to affect classes reloading. Thanks to https://github.com/paneq/active_reload and Pastorino for the inspiration. <3 |