Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add the `Mime::Type::InvalidMimeType` error in the default rescue_response: | Edouard CHIN | 2019-03-26 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | - https://github.com/rails/rails/pull/35604 introduced a vulnerability fix to raise an error in case the `HTTP_ACCEPT` headers contains malformated mime type. This will cause applications to throw a 500 if a User Agent sends an invalid header. This PR adds the `InvalidMimeType` in the default `rescue_responses` from the ExceptionWrapper and will return a 406. I looked up the HTTP/1.1 RFC and it doesn't stand what should be returned when the UA sends malformated mime type. Decided to get 406 as it seemed to be the status the better suited for this. | ||||
* | Use env instead of headers on those tests | Rafael Mendonça França | 2018-11-26 | 1 | -14/+14 |
| | | | | | We are dealing with the rack env so it is better to specify it in the tests. | ||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Deprecated ActionDispatch::ParamsParser::ParamsParser | Rafael Mendonça França | 2016-10-10 | 1 | -1/+1 |
| | | | | | | ActionDispatch::ParamsParser class was removed in favor of ActionDispatch::Http::Parameters so it is better to move the error constant to the new class. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | |||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 1 | -17/+17 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Use URL path extension as format in bad params exception handling | Jorge Bejar | 2015-12-08 | 1 | -1/+15 |
| | |||||
* | Deprecate exception#original_exception in favor of exception#cause | Yuki Nishijima | 2015-11-03 | 1 | -2/+10 |
| | |||||
* | Tweaked wording used in some tests. | Sebastian McKenzie | 2015-10-25 | 1 | -2/+2 |
| | |||||
* | Remove extra whitespaces | Santiago Pastorino | 2015-06-11 | 1 | -1/+1 |
| | |||||
* | Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already ↵ | Santiago Pastorino | 2015-06-11 | 1 | -37/+0 |
| | | | | does the work | ||||
* | Add ApiPublicException middleware | Santiago Pastorino | 2015-06-11 | 1 | -2/+39 |
| | |||||
* | Consistent usage of spaces in hashes across our codebase | Rafael Mendonça França | 2015-01-29 | 1 | -12/+12 |
| | |||||
* | Switch to kwargs in ActionController::TestCase and ActionDispatch::Integration | Kir Shatrov | 2015-01-29 | 1 | -12/+12 |
| | | | | | | | | Non-kwargs requests are deprecated now. Guides are updated as well. `post url, nil, nil, { a: 'b' }` doesn't make sense. `post url, params: { y: x }, session: { a: 'b' }` would be an explicit way to do the same | ||||
* | Stash original path in `ShowExceptions` middleware | Grey Baker | 2014-07-14 | 1 | -1/+2 |
| | | | | | | | | | | `ActionDispatch::ShowExceptions` overwrites `PATH_INFO` with the status code for the exception defined in `ExceptionWrapper`, so the path the user was visiting when an exception occurred was not previously available to any custom exceptions_app. The original `PATH_INFO` is now stashed in `env["action_dispatch.original_path"]`. | ||||
* | Merge pull request #9857 from yyyc514/bad_params_should_400 | Aaron Patterson | 2013-04-30 | 1 | -0/+6 |
|\ | | | | | failure to parse params should trigger a 400 Bad Request | ||||
| * | failure to parse params should trigger a 400 Bad Request | Josh Goebel | 2013-03-21 | 1 | -0/+6 |
| | | |||||
* | | Return a 405 response for unknown HTTP methods | Lewis Marshall | 2013-04-22 | 1 | -0/+6 |
|/ | |||||
* | Removed unused assigns from ActionView::Template::Error | brainopia | 2012-01-20 | 1 | -1/+1 |
| | | | | | They existed since initial rails commit by DHH but lost use a long time ago | ||||
* | Remove other old compatibility constants | Carlos Antonio da Silva | 2012-01-17 | 1 | -1/+1 |
| | |||||
* | ShowExceptions should understand X-Cascade responses from exceptions app. | José Valim | 2011-12-16 | 1 | -0/+11 |
| | |||||
* | Improve the specs on exceptions app. | José Valim | 2011-12-16 | 1 | -1/+14 |
| | |||||
* | Extract the rendering of public exceptions pages into a Rack app. | José Valim | 2011-12-16 | 1 | -1/+1 |
| | |||||
* | Remove unnecessary test setup. | José Valim | 2011-12-01 | 1 | -6/+1 |
| | |||||
* | Split and improve show and debug exceptions middlewares. | José Valim | 2011-12-01 | 1 | -76/+14 |
| | |||||
* | Split ShowExceptions responsibilities in two middlewares. | José Valim | 2011-12-01 | 1 | -2/+2 |
| | |||||
* | put backtrace_cleaner to env | lest | 2011-11-28 | 1 | -0/+7 |
| | |||||
* | middlewares should use logger from env | lest | 2011-11-25 | 1 | -0/+7 |
| | |||||
* | refactor show exceptions tests | lest | 2011-11-22 | 1 | -42/+19 |
| | |||||
* | add ActionController::Metal#show_detailed_exceptions? | lest | 2011-11-22 | 1 | -19/+26 |
| | |||||
* | Don't pluralize, camelize. | José Valim | 2011-05-06 | 1 | -2/+2 |
| | |||||
* | Sets the HTTP charset parameter for rescue response. | Matias Korhonen | 2011-05-03 | 1 | -0/+7 |
| | |||||
* | correction to the outputted controller name in the diagnostics error ↵ | Josh Kalderimis | 2011-03-24 | 1 | -0/+16 |
| | | | | | | template, test included Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Show exceptions rescues the original exception | Les Hill and Sandro Turriate | 2010-10-12 | 1 | -0/+20 |
| | | | | | | [#5784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | removing more duplicate code | Aaron Patterson | 2010-10-01 | 1 | -14/+0 |
| | |||||
* | Use parentheses when using assert_match followed by a regexp to avoid warnings. | Emilio Tagua | 2010-09-27 | 1 | -7/+7 |
| | |||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 1 | -1/+1 |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | ||||
* | Revert "Setup explicit requires for files with exceptions. Removed them from ↵ | José Valim | 2010-09-02 | 1 | -1/+0 |
| | | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6. | ||||
* | Setup explicit requires for files with exceptions. Removed them from ↵ | Łukasz Strzałkowski | 2010-09-02 | 1 | -0/+1 |
| | | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make sure that rails recognized the full notation of IPv6 loopback address, ↵ | Prem Sichanugrist | 2010-06-08 | 1 | -1/+1 |
| | | | | | | and recognize 127.0.0.0/8 in IPv4 Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use config.filter_parameters on in-browser request dump. [#4335 state:resolved] | José Valim | 2010-04-07 | 1 | -0/+9 |
| | |||||
* | Disable ShowExceptions during integration tests | Joshua Peek | 2010-01-19 | 1 | -11/+11 |
| | |||||
* | Make local_request? to returns true when facing ::1 IPv6 address [#3257 ↵ | Prem Sichanugrist | 2010-01-17 | 1 | -10/+12 |
| | | | | | | status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add ActionDispatch::Notifications middleware. | José Valim | 2010-01-17 | 1 | -23/+0 |
| | |||||
* | Ensure no notification is on the queue before running notifications related ↵ | José Valim | 2010-01-03 | 1 | -0/+3 |
| | | | | tests. | ||||
* | Add notifications to ActionDispatch::ShowExceptions, this can be used as ↵ | José Valim | 2010-01-03 | 1 | -0/+20 |
| | | | | hooks for plugins like ExceptionNotifier. | ||||
* | Allow integration test rack app to be set with "@app" ivar instead of using ↵ | Joshua Peek | 2009-09-26 | 1 | -4/+4 |
| | | | | open_session | ||||
* | Ensure changes to I18n locale get reset during tests | Joshua Peek | 2009-09-19 | 1 | -2/+1 |
| |