Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | finish deprecating handling strings and symbols | Aaron Patterson | 2015-08-07 | 2 | -2/+2 |
| | | | | | since we only work with instances of classes, it greatly simplifies the `Middleware` implementation. | ||||
* | Adds missing argument handling for ActionController::TestSession to | Matthew Gerrior | 2015-08-06 | 1 | -0/+10 |
| | | | | allow testing controllers that use session#fetch with a default value. | ||||
* | Stop using deprecated `render :text` in test | Prem Sichanugrist | 2015-07-17 | 3 | -9/+9 |
| | | | | | | | | | This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`. | ||||
* | Use request.session.id instead of request.session_options[:id] | Brian John | 2015-03-12 | 3 | -4/+4 |
| | | | | | | | | | As of the upgrade to Rack 1.5, request.session_options[:id] is no longer populated. Reflect this change in the tests by using request.session.id instead. Related change in Rack: https://github.com/rack/rack/commit/83a270d6 | ||||
* | Consistent usage of spaces in hashes across our codebase | Rafael Mendonça França | 2015-01-29 | 1 | -1/+1 |
| | |||||
* | Switch to kwargs in ActionController::TestCase and ActionDispatch::Integration | Kir Shatrov | 2015-01-29 | 2 | -5/+7 |
| | | | | | | | | Non-kwargs requests are deprecated now. Guides are updated as well. `post url, nil, nil, { a: 'b' }` doesn't make sense. `post url, params: { y: x }, session: { a: 'b' }` would be an explicit way to do the same | ||||
* | Expectations first | Akira Matsuda | 2014-08-18 | 1 | -3/+3 |
| | |||||
* | Regenerate sid when sbdy tries to fixate the session | Santiago Pastorino | 2014-08-04 | 1 | -9/+8 |
| | | | | | | Fixed broken test. Thanks Stephen Richards for reporting. | ||||
* | Skip individual tests upon Dalli::RingError | Matthew Draper | 2014-05-27 | 1 | -0/+18 |
| | | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem. | ||||
* | Add an explicit require for 4ece124396669d3580e7f229ab407a0d4882727a rather ↵ | Jeremy Kemper | 2014-03-16 | 1 | -0/+1 |
| | | | | than assume SecureRandom is available | ||||
* | Avoid concurrent test collision on the same memcache server by namespacing keys | Jeremy Kemper | 2014-03-16 | 1 | -1/+1 |
| | |||||
* | Remove comments about removing LegacyKeyGenerator in 4.1 | Trevor Turk | 2013-04-03 | 1 | -1/+0 |
| | |||||
* | Rename DummyKeyGenerator -> LegacyKeyGenerator | Trevor Turk | 2013-04-02 | 1 | -2/+2 |
| | |||||
* | Add keys/values methods to TestSession | Carlos Antonio da Silva | 2013-01-25 | 1 | -5/+11 |
| | | | | Bring back the same API we have with Request::Session. | ||||
* | Integrate Action Pack with Rack 1.5 | Carlos Antonio da Silva | 2013-01-25 | 1 | -2/+2 |
| | | | | | | All ActionPack and Railties tests are passing. Closes #8891. [Carlos Antonio da Silva + Santiago Pastorino] | ||||
* | Alias refute methods to assert_not and perfer assert_not on tests | Rafael Mendonça França | 2012-12-31 | 1 | -1/+1 |
| | |||||
* | Sign cookies using key deriver | Santiago Pastorino | 2012-11-03 | 1 | -1/+4 |
| | |||||
* | fix cache store test | Steve Klabnik | 2012-09-30 | 1 | -0/+1 |
| | | | | Pull #7800 broke the build, this should fix it. | ||||
* | Add integration tests for reset_session in cookie store | Andreas Loupasakis | 2012-09-08 | 1 | -0/+20 |
| | |||||
* | Dalli doesn't support autoloading of unloaded classes | Guillermo Iguaran | 2012-09-06 | 1 | -5/+0 |
| | |||||
* | Let's run action pack tests with Dalli | Arun Agrawal | 2012-09-06 | 1 | -4/+4 |
| | | | | There is no memcache gem left in repo. | ||||
* | Revert "Merge pull request #7452 from arunagw/memcached_dalli" | Jon Leighton | 2012-08-31 | 1 | -4/+4 |
| | | | | | | | This reverts commit 7256cb53e0c34e510a4d59a50d120c0358cf1d99, reversing changes made to 6ebe22c3ae716d089af1e5090ddb0d12b31af8ac. Reason: A test was failing. | ||||
* | Revert "Add missing require" | Jon Leighton | 2012-08-31 | 1 | -1/+0 |
| | | | | | | This reverts commit e4b33b08d6d2b88b627b1e52c4f349e57c5b89fc. https://github.com/rails/rails/pull/7452#issuecomment-8094302 | ||||
* | Add missing require | Rafael Mendonça França | 2012-08-28 | 1 | -0/+1 |
| | |||||
* | Let's run action pack tests with Dalli | Arun Agrawal | 2012-08-27 | 1 | -4/+4 |
| | | | There is no memcache gem left in repo. | ||||
* | testing session store behavior | Aaron Patterson | 2012-05-02 | 1 | -0/+56 |
| | |||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 3 | -3/+3 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Remove rescue_action from compatibility module and tests | Carlos Antonio da Silva | 2012-01-17 | 3 | -6/+0 |
| | |||||
* | Add ActionDispatch::Session::CacheStore as a generic way of storing sessions ↵ | Brian Durand | 2011-10-21 | 1 | -0/+181 |
| | | | | in a cache. | ||||
* | fix deprecation warning in cookie_store_test | Vijay Dev | 2011-09-25 | 1 | -1/+1 |
| | | | | The options argument to MessageVerifier#initialize should be a hash. | ||||
* | remove warning: assigned but unused variable | Santiago Pastorino | 2011-06-08 | 1 | -1/+0 |
| | |||||
* | Replace references to ActiveSupport::SecureRandom with just SecureRandom, ↵ | Jon Leighton | 2011-05-23 | 1 | -1/+1 |
| | | | | and require 'securerandom' from the stdlib when active support is required. | ||||
* | Fix renew feature on cookies. | José Valim | 2011-05-04 | 1 | -0/+16 |
| | |||||
* | cleaning up some warnings on 1.9.3 | Aaron Patterson | 2011-02-07 | 1 | -1/+0 |
| | |||||
* | Rely on Rack::Session stores API for more compatibility across the Ruby world. | José Valim | 2010-10-03 | 1 | -12/+0 |
| | |||||
* | Use parentheses when using assert_match followed by a regexp to avoid warnings. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 2 | -4/+4 |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | ||||
* | Only send secure cookies over SSL. | W. Andrew Loe III | 2010-09-13 | 1 | -0/+17 |
| | |||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 2 | -2/+2 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 2 | -5/+5 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Set session options id to nil is respected and cancels lazy loading. | José Valim | 2010-07-18 | 1 | -1/+19 |
| | |||||
* | porting session.clear fix to master branch. [#5030 state:resolved] | Aaron Patterson | 2010-07-01 | 1 | -0/+22 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fixed that an ArgumentError is thrown when request.session_options[:id] is ↵ | Michael Lovitt | 2010-06-27 | 2 | -0/+50 |
| | | | | | | | | read in the following scenario: when the cookie store is used, and the session contains a serialized object of an unloaded class, and no session data accesses have occurred yet. Pushed the stale_session_check responsibility out of the SessionHash and down into the session store, closer to where the deserialization actually occurs. Added some test coverage for this case and others related to deserialization of unloaded types. [#4938] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make sure that Rails doesn't resent session_id cookie over and over again if ↵ | Prem Sichanugrist | 2010-06-25 | 1 | -0/+12 |
| | | | | | | | | it's already there [#2485 state:resolved] This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Avoid deserializing cookies too early, which causes session objects to not ↵ | José Valim | 2010-06-24 | 1 | -3/+3 |
| | | | | be available yet. Unfortunately, could not reproduce this in a test case. | ||||
* | Sessions should not be created until written to and session data should be ↵ | Michael Lovitt | 2010-06-23 | 2 | -3/+39 |
| | | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | The previous commit didn't work with complex domains, which is now fixed. | Rizwan Reza | 2010-06-11 | 1 | -5/+5 |
| | |||||
* | Add support for multi-subdomain session by setting cookie host in session ↵ | Rizwan Reza | 2010-06-11 | 1 | -0/+29 |
| | | | | | | cookie so you can share session between www.example.com, example.com and user.example.com. [#4818 state:resolved] This reverts commit 330a89072a493aafef1e07c3558964477f85adf0. | ||||
* | Cut the fat and make session stores rely on request.cookie_jar and change ↵ | José Valim | 2010-05-18 | 2 | -2/+7 |
| | | | | set_session semantics to return the cookie value instead of a boolean. | ||||
* | Remove deprecated methods since 2-3-stable. | José Valim | 2010-05-18 | 1 | -12/+0 |
| |