aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/dispatch/routing_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Reset the request parameters after a constraints checkAndrew White2012-05-031-0/+19
| | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. (cherry picked from commit 56030506563352944fed12a6bb4793bb2462094b)
* Restore interpolation of path option in redirect routesAndrew White2012-04-291-1/+40
|
* Escape interpolated params when redirecting - fixes #5688Andrew White2012-04-291-0/+28
|
* Fix the redirect when it receive blocks with arity of 1.Rafael Mendonça França2012-03-311-0/+15
| | | | Closes #5677
* Fix some warnings on 3-2-stablekennyj2012-02-211-1/+0
|
* Merge pull request #4988 from kennyj/fix_4720-3Aaron Patterson2012-02-101-0/+26
| | | | Fix GH #4720. Routing problem with nested namespace and already camelized controller option.
* Merge pull request #4908 from kennyj/fix_3864José Valim2012-02-061-0/+33
| | | | Fix url_for method's behavior. GH #3684.
* Test for unicode path supportPaul McMahon2012-01-251-0/+20
| | | | This is currently broken due to a bug in journey.
* Merge pull request #4462 from spohlenz/fix-routing-testsAaron Patterson2012-01-161-0/+4
| | | | Stub ip method of alternative request class in router tests
* last named route wins. fixes #4164Aaron Patterson2011-12-281-1/+1
| | | | | | This differs from route recognition where first recognized route wins. This will not be supported in Rails 4.0 so that route recognition and generation rules are consistent.
* Do not raise an exception if an invalid route was generated automatically.José Valim2011-12-161-0/+1
|
* Fix failing AP tests.José Valim2011-12-131-1/+1
|
* Refactoring the redirect method for the router api.Aaron Patterson2011-11-181-0/+5
|
* remove the :path feature to redirects, since it cannot workAaron Patterson2011-11-181-33/+0
|
* require that all blocks have arity of 2Aaron Patterson2011-11-181-1/+1
|
* Symbol captures may generate multiple path segments, so don't escape / -> ↵Jeremy Kemper2011-10-131-7/+17
| | | | %2F. Test splat escaping.
* Failing tests for path parameter escapingJeremy Kemper2011-10-131-0/+27
|
* allow shorthand routes with nested optional parametersDiego Carrion2011-10-101-0/+11
|
* Fix named routes modifying argumentsPawel Pierzchala2011-09-221-0/+11
|
* when calling url_for with a hash, additional (likely unwanted) values (such ↵Andrew Kaspick2011-08-111-0/+12
| | | | as :host) would be returned in the hash... calling #dup on the hash prevents this
* Ensure the constraints block is only applied to the correct routeDave Rogers2011-07-251-0/+20
| | | | | addresses issue #1907 - any routes that follow a route with a constraints block are inheriting the previous route's constraints.
* Remove `#among?` from Active SupportPrem Sichanugrist2011-04-131-1/+1
| | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
* Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵David Heinemeier Hansson2011-04-121-1/+1
| | | | suggestion!
* Fix failing test case on masterPrem Sichanugrist2011-04-101-1/+1
| | | | It turned out that I overlook at some replacements ..
* Using Object#in? and Object#either? in various placesPrem Sichanugrist2011-04-111-1/+2
| | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
* Raise ArgumentError if route name is invalid [#6517 state:resolved]Andrew White2011-03-061-0/+32
|
* Add test to prevent regression on namespace root nested in a resourceAndrew White2011-02-141-0/+9
| | | | [#6389 state:resolved]
* Fix named route helper for routes nested inside deeply nested resourcesAndrew White2011-02-141-1/+9
| | | | [#6416 state:resolved]
* fixed bug with nested resources within shallow scopegerman2011-02-041-0/+62
| | | | | | [#6372 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Added documentation explaining the new additional supported syntaxes for the ↵Josh Kalderimis2010-11-301-0/+17
| | | | routing redirect method, a small changelog note, and two extra tests for path interpolation when using the hash option syntax.
* The redirect routing method now allows for a hash of options which only ↵Josh Kalderimis2010-11-301-0/+48
| | | | changes the relevant parts of the url, or an object which responds to call can be supplied so common redirect rules can be easily reused. This commit includes a change where url generation from parts has been moved to AD::Http::URL as a class method.
* Dynamically generaeted helpers on collection should not clobber resources ↵José Valim2010-11-251-0/+11
| | | | url helper [#6028 state:resolved]
* Add additional HTTP request methods from the following RFCs:Andrew White2010-11-021-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | * Hypertext Transfer Protocol -- HTTP/1.1 http://www.ietf.org/rfc/rfc2616.txt) * HTTP Extensions for Distributed Authoring -- WEBDAV http://www.ietf.org/rfc/rfc2518.txt * Versioning Extensions to WebDAV http://www.ietf.org/rfc/rfc3253.txt * Ordered Collections Protocol (WebDAV) http://www.ietf.org/rfc/rfc3648.txt * Web Distributed Authoring and Versioning (WebDAV) Access Control Protocol http://www.ietf.org/rfc/rfc3744.txt * Web Distributed Authoring and Versioning (WebDAV) SEARCH http://www.ietf.org/rfc/rfc5323.txt * PATCH Method for HTTP http://www.ietf.org/rfc/rfc5789.txt [#2809 state:resolved] [#5895 state:resolved]
* Ensure that named routes do not overwrite previously defined routes.José Valim2010-09-291-0/+18
|
* Remove duplicated test.Emilio Tagua2010-09-271-8/+0
|
* Remove deprecated stuff in ActionControllerCarlos Antonio da Silva2010-09-261-3/+3
| | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController.
* Raise ArgumentError instead of normalizing controller name when there is a ↵Andrew White2010-09-181-6/+30
| | | | leading slash [#5651 state:resolved]
* Remove leading slash from controller [#5651 state:resolved]Andrew White2010-09-181-0/+8
|
* Add RouteSet#appendCarl Lerche2010-09-171-0/+33
| | | Allows specifying blocks to the routeset that will get appended after the RouteSet is drawn.
* Implemented RouteSet#default_scope, which allows to set the scope for the ↵Piotr Sarnacki2010-09-031-0/+29
| | | | entire routes object
* Revert "Setup explicit requires for files with exceptions. Removed them from ↵José Valim2010-09-021-1/+0
| | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6.
* Setup explicit requires for files with exceptions. Removed them from ↵Łukasz Strzałkowski2010-09-021-0/+1
| | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com>
* Move implicit nested call before options handling so that nested constraints ↵Andrew White2010-09-011-0/+18
| | | | | | work [#5513 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Bump rack-mount to 0.6.13 and add test case for named character classes ↵Andrew White2010-08-311-0/+12
| | | | | | [#5509 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use nested scope for routes defined at the :resources scope level (as in ↵Andrew White2010-08-241-0/+7
| | | | | | Rails 2.3) Signed-off-by: José Valim <jose.valim@gmail.com>
* Allow format to be skipped. This is used internally by mount.José Valim2010-08-241-1/+1
|
* Finally fix the bug where symbols and strings were not having the same ↵José Valim2010-08-241-6/+38
| | | | | | | behavior in the router. If you were using symbols before for methods like match/get/post/put/delete, it is likely that this commit will break your routes. Everything should behave the same if you are using strings, if not, please open up a ticket.
* Ensure shortcuts inside resources also generates helpers.José Valim2010-08-241-4/+4
|
* Fix how routes inside namespaces are generated.José Valim2010-08-241-3/+3
|
* Allow actions which start with A-Za-z_ onlySantiago Pastorino2010-08-241-1/+4
|