aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/dispatch/routing_assertions_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Make sure assert_recognizes can still find routes mounted after enginesRafael Mendonça França2018-02-091-0/+6
| | | | | Before, if the application defined after an engine this method would not recognize the route since it was not defined insdie the engine.
* Fix merge conflict and rubocop offencesRyuta Kamizono2017-11-071-19/+18
|
* Merge pull request #22435 from yui-knk/fix_engine_route_testRafael Mendonça França2017-11-061-0/+72
|\ | | | | | | Make `assert_recognizes` to traverse mounted engines
| * Make `assert_recognizes` to traverse mounted enginesyui-knk2016-04-231-0/+71
| | | | | | | | | | | | Before this commit paths of mounted engines are not traversed when `assert_recognizes` is called, causing strange test results. This commit enable to traverse mounted paths.
* | Fix RuboCop offensesKoichi ITO2017-08-161-6/+6
| | | | | | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* | Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
| |
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* | Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
| |
* | Add three new rubocop rulesRafael Mendonça França2016-08-161-1/+1
| | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | applies remaining conventions across the projectXavier Noria2016-08-061-1/+0
| |
* | remove redundant curlies from hash argumentsXavier Noria2016-08-061-16/+16
| |
* | modernizes hash syntax in actionpackXavier Noria2016-08-061-33/+33
| |
* | applies new string literal convention in actionpack/testXavier Noria2016-08-061-35/+35
|/ | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Add test to assert_recognizes with custom messageRafael Mendonça França2014-09-051-1/+9
|
* Propagate test messages through assert_routing helper, Fixes #14908Earl St Sauver2014-04-291-0/+8
| | | | | | | | | | | | | | | assert_routing was not raising the message passed into the assertion violation that it raised. This change propagates messages through the on_fail error. This fixes this error: https://github.com/rails/rails/issues/14908 A test case for this issue is located here. https://github.com/estsauver/test14908 To see that test case fail in the example app, just run ruby -Itest test/controllers/guests_controller_test.rb
* Raise Assertion instead of RoutingError for routing assertion failures.David Chelimsky2012-05-201-6/+6
| | | | | | | | | | | | | Before this change, assert_recognizes, assert_generates, and assert_routing raised ActionController::RoutingError when they failed to recognize the route. This commit changes them to raise Assertion instead. This aligns with convention for logical failures, and supports reporting tools that care about the difference between logical failures and errors e.g. the summary at the end of a test run. - Fixes #5899
* Copy literal route constraints to defaults - fixes #3571 and #6224.Andrew White2012-05-111-3/+3
|
* Fix the assert_recognizes test method so that it works when there areMatt Fawcett2012-02-241-0/+12
| | | | constraints on the querystring. Issue #2781
* Fix assert_recognizes with block constraints [#5805 state:resolved]Andrew White2011-02-131-0/+103