Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Cleanup ul_encoded_params_parsing_test | Genadi Samokovarov | 2013-07-05 | 1 | -25/+27 | |
| | ||||||
* | use bytesize rather than force encoding | Aaron Patterson | 2013-06-28 | 1 | -2/+1 | |
| | ||||||
* | Replace multi_json with json | Erik Michaels-Ober | 2013-05-11 | 1 | -1/+1 | |
| | ||||||
* | Fix failing AP test | Carlos Antonio da Silva | 2013-05-01 | 1 | -1/+1 | |
| | ||||||
* | UTF-8 encode all keys and values in nested params hash. | Teo Hui Ming | 2013-03-15 | 1 | -1/+20 | |
| | ||||||
* | Change from each to each_value on hash to avoid unused variable warning | Vipul A M | 2013-03-11 | 1 | -1/+1 | |
| | ||||||
* | Remove XML Parser from ActionDispatch | Prem Sichanugrist | 2013-02-20 | 1 | -182/+0 | |
| | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem. | |||||
* | Fix json params parsing regression for non-object JSON content. | Dylan Smith | 2013-01-11 | 1 | -0/+7 | |
| | | | | Fixes #8845. | |||||
* | Remove :yaml related tests and fix other related to parsing empty arrays | Carlos Antonio da Silva | 2013-01-08 | 1 | -2/+2 | |
| | | | | All Action Pack tests are green. | |||||
* | * Strip nils from collections on JSON and XML posts. [CVE-2013-0155] * ↵ | Aaron Patterson | 2013-01-08 | 2 | -0/+32 | |
| | | | | | | | | | | | | dealing with empty hashes. Thanks Damien Mathieu Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/http/request.rb actionpack/lib/action_dispatch/middleware/params_parser.rb activerecord/CHANGELOG.md activerecord/lib/active_record/relation/predicate_builder.rb activerecord/test/cases/relation/where_test.rb | |||||
* | Revert "Merge branch 'master-sec'" | Jeremy Kemper | 2013-01-08 | 2 | -32/+0 | |
| | | | | | This reverts commit 88cc1688d0cb828c17706b41a8bd27870f2a2beb, reversing changes made to f049016cd348627bf8db0d72382d7580bf802a79. | |||||
* | * Strip nils from collections on JSON and XML posts. [CVE-2013-0155] * ↵ | Aaron Patterson | 2013-01-07 | 2 | -0/+32 | |
| | | | | | | | | | | | | dealing with empty hashes. Thanks Damien Mathieu Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/http/request.rb actionpack/lib/action_dispatch/middleware/params_parser.rb activerecord/CHANGELOG.md activerecord/lib/active_record/relation/predicate_builder.rb activerecord/test/cases/relation/where_test.rb | |||||
* | Alias refute methods to assert_not and perfer assert_not on tests | Rafael Mendonça França | 2012-12-31 | 1 | -1/+1 | |
| | ||||||
* | Prevent raising EOFError on multipart GET request. | Adam Stankiewicz | 2012-12-10 | 1 | -0/+12 | |
| | | | | | | | | | | Such request can happen on Internet Explorer. When we redirect after multipart form submission, the request type is changed to GET, but Content-Type is preserved as multipart. GET request cannot have multipart body and that caused Rails to fail. It's similar fix to Rack's one: https://github.com/chneukirchen/rack/blob/8025a4ae9477d1e6231344c2b7d795aa9b3717b6/lib/rack/request.rb#L224 | |||||
* | Merge pull request #7444 from szimek/params_parser_raises_parsing_error | Aaron Patterson | 2012-09-26 | 2 | -2/+6 | |
|\ | | | | | Raise generic ParseError exception when ParamsParser fails parsing request params | |||||
| * | Make ActionDispatch::ParamsParser::ParseError#original_exception return the ↵ | Szymon Nowak | 2012-08-27 | 2 | -2/+4 | |
| | | | | | | | | original exception. | |||||
| * | Fix ActionDispatch::ParamsParser::ParseError message for XML and JSON parsers. | Szymon Nowak | 2012-08-24 | 2 | -2/+4 | |
| | | ||||||
| * | Raise generic ParseError exception when ActionDispatch::ParamsParser fails ↵ | Szymon Nowak | 2012-08-24 | 2 | -2/+2 | |
| | | | | | | | | parsing request params. | |||||
* | | Add test for clear in ActionDispatch::Request::Session | Andreas Loupasakis | 2012-09-08 | 1 | -0/+9 | |
|/ | ||||||
* | Fix build | Santiago Pastorino | 2012-06-13 | 1 | -2/+2 | |
| | ||||||
* | Array parameters should not contain nil values. | Aaron Patterson | 2012-06-12 | 1 | -0/+4 | |
| | ||||||
* | Merge branch 'master-sec' | Aaron Patterson | 2012-05-31 | 1 | -1/+6 | |
|\ | | | | | | | | | | | * master-sec: Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this! predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this | |||||
| * | Strip [nil] from parameters hash. | Aaron Patterson | 2012-05-30 | 1 | -1/+6 | |
| | | | | | | | | | | | | Thanks to Ben Murphy for reporting this! CVE-2012-2660 | |||||
* | | Added ActionDispatch::Request::Session#keys and ↵ | Philip Arndt | 2012-05-23 | 1 | -0/+16 | |
|/ | | | | ActionDispatch::Request::Session#values | |||||
* | Raise ActionController::BadRequest for malformed parameter hashes. | Andrew White | 2012-05-20 | 2 | -0/+22 | |
| | | | | | | | | | | | | | | Currently Rack raises a TypeError when it encounters a malformed or ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this through to the application this commit captures the exception and re-raises it using a new ActionController::BadRequest exception. The new ActionController::BadRequest exception returns a 400 error instead of the 500 error that would've been returned by the original TypeError. This allows exception notification libraries to ignore these errors if so desired. Closes #3051 | |||||
* | testing session store behavior | Aaron Patterson | 2012-05-02 | 1 | -0/+48 | |
| | ||||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 5 | -7/+7 | |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | |||||
* | Moved all the logger methods to active support logger | Karunakar (Ruby) | 2012-01-06 | 2 | -2/+2 | |
| | | | | minor | |||||
* | remove ActiveSupport::Base64 in favor of ::Base64 | Sergey Nartimov | 2012-01-02 | 1 | -4/+4 | |
| | ||||||
* | remove checks for encodings availability | Sergey Nartimov | 2011-12-25 | 1 | -1/+1 | |
| | ||||||
* | deprecate String#encoding_aware? and remove its usage | Sergey Nartimov | 2011-12-24 | 1 | -2/+0 | |
| | ||||||
* | middlewares should use logger from env | lest | 2011-11-25 | 2 | -20/+12 | |
| | ||||||
* | Remove unreachable code, and add additional testcases. | kennyj | 2011-11-24 | 2 | -0/+24 | |
| | ||||||
* | Multipart is now fixed in Rack. | José Valim | 2011-05-03 | 1 | -14/+8 | |
| | ||||||
* | Add `ActionController::ParamsWrapper` to wrap parameters into a nested hash | Prem Sichanugrist | 2011-05-03 | 2 | -0/+91 | |
| | | | This will allow us to do a rootless JSON/XML request to server. | |||||
* | if it walks like a duck and talks like a duck, it must be a duck | Aaron Patterson | 2010-10-04 | 1 | -7/+0 | |
| | ||||||
* | Change test to avoid warnings. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 | |
| | ||||||
* | undef method if already defined. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 | |
| | ||||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 5 | -5/+5 | |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | |||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 5 | -5/+5 | |
| | ||||||
* | Fix several known web encoding issues: | wycats | 2010-06-27 | 1 | -0/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | * Specify accept-charset on all forms. All recent browsers, as well as IE5+, will use the encoding specified for form parameters * Unfortunately, IE5+ will not look at accept-charset unless at least one character in the form's values is not in the page's charset. Since the user can override the default charset (which Rails sets to UTF-8), we provide a hidden input containing a unicode character, forcing IE to look at the accept-charset. * Now that the vast majority of web input is UTF-8, we set the inbound parameters to UTF-8. This will eliminate many cases of incompatible encodings between ASCII-8BIT and UTF-8. * You can safely ignore params[:_snowman_] TODO: * Validate inbound text to confirm it is UTF-8 * Combine the whole_form implementations in form_helper_test and form_tag_helper_test | |||||
* | Upgrade to Rack 1.2.1 | Jeremy Kemper | 2010-06-27 | 1 | -8/+14 | |
| | ||||||
* | Ruby 1.9: fix invalid rack response in test | Jeremy Kemper | 2010-05-15 | 1 | -1/+1 | |
| | ||||||
* | Fix parsing xml input by ActionDispatch::ParamsParser | Lawrence Pit | 2010-05-06 | 1 | -0/+13 | |
| | | | | | | [#4437 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Disable ShowExceptions during integration tests | Joshua Peek | 2010-01-19 | 2 | -2/+2 | |
| | ||||||
* | Use new routing dsl in tests | Joshua Peek | 2009-12-08 | 1 | -1/+1 | |
| | ||||||
* | Ruby 1.9: resolve constant lookup issues | Jeremy Kemper | 2009-11-04 | 4 | -6/+6 | |
| | ||||||
* | Start rewriting some internal tests to use the new routing dsl | Joshua Peek | 2009-10-20 | 4 | -4/+4 | |
| | ||||||
* | Add custom "with_routing" to internal tests to fix reseting session after using | Joshua Peek | 2009-10-03 | 5 | -5/+0 | |
| | | | | with_routing. This only affects our internal AP tests. | |||||
* | Reset session in integration tests after changing routes to reload the ↵ | Joshua Peek | 2009-08-27 | 5 | -0/+5 | |
| | | | | middleware stack |