| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | Fix test for DebugExceptions due to template change | Guillermo Iguaran | 2012-12-31 | 1 | -1/+1 | |
| | | ||||||
| * | Add Missing Keys from Journey on failed URL format | schneems | 2012-08-28 | 1 | -0/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Many named routes have keys that are required to successfully resolve. If a key is left off like this: <%= link_to 'user', user_path %> This will produce an error like this: No route matches {:action=>"show", :controller=>"users"} Since we know that the :id is missing, we can add extra debugging information to the error message. No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id] This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url. While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious. This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message. Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421 | |||||
| * | Raise ActionController::BadRequest for malformed parameter hashes. | Andrew White | 2012-05-20 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | Currently Rack raises a TypeError when it encounters a malformed or ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this through to the application this commit captures the exception and re-raises it using a new ActionController::BadRequest exception. The new ActionController::BadRequest exception returns a 400 error instead of the 500 error that would've been returned by the original TypeError. This allows exception notification libraries to ignore these errors if so desired. Closes #3051 | |||||
| * | Removed unused assigns from ActionView::Template::Error | brainopia | 2012-01-20 | 1 | -1/+1 | |
| | | | | | | They existed since initial rails commit by DHH but lost use a long time ago | |||||
| * | Remove other old compatibility constants | Carlos Antonio da Silva | 2012-01-17 | 1 | -2/+2 | |
| | | ||||||
| * | Warning removed "warning: (...) interpreted as grouped expression" | Arun Agrawal | 2011-12-16 | 1 | -1/+1 | |
| | | ||||||
| * | Close the response body on cascade pass, closes #3975. | José Valim | 2011-12-14 | 1 | -3/+22 | |
| | | ||||||
| * | log exception backtrace when all backtrace lines silenced | Sergey Nartimov | 2011-12-13 | 1 | -0/+13 | |
| | | ||||||
| * | Fix failing cascade exception. | José Valim | 2011-12-03 | 1 | -0/+9 | |
| | | ||||||
| * | Split and improve show and debug exceptions middlewares. | José Valim | 2011-12-01 | 1 | -0/+116 | |
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |