Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Deprecate passing hash as first parameter into ActionController::Head | Mehmet Emin İNAÇ | 2015-06-15 | 3 | -10/+31 |
| | |||||
* | Fix flakyness. | Kasper Timm Hansen | 2015-06-15 | 1 | -0/+1 |
| | | | | Brought on by my own stupidity :) | ||||
* | Return 204 if render is not called in API controllers | Jorge Bejar | 2015-06-11 | 1 | -0/+15 |
| | |||||
* | Add test coverage for implicit render in empty actions | Jorge Bejar | 2015-06-11 | 1 | -0/+14 |
| | |||||
* | Include ParamsWrapper in AC::API | Jorge Bejar | 2015-06-11 | 1 | -0/+26 |
| | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it. | ||||
* | Rename test methods in api conditional get controller tests | Jorge Bejar | 2015-06-11 | 1 | -2/+2 |
| | |||||
* | Use new hash syntax | Santiago Pastorino | 2015-06-11 | 2 | -7/+7 |
| | |||||
* | Use nex hash syntax on tests | Santiago Pastorino | 2015-06-11 | 1 | -5/+5 |
| | |||||
* | Move Model test class inside RenderersApiController namespace | Santiago Pastorino | 2015-06-11 | 1 | -8/+8 |
| | |||||
* | Add ActionController API functionality | Santiago Pastorino | 2015-06-11 | 6 | -0/+180 |
| | |||||
* | Merge pull request #19094 from phoet/have_bearer_be_valid_as_well | Rafael Mendonça França | 2015-06-01 | 1 | -1/+8 |
|\ | | | | | Have Bearer be valid as well | ||||
| * | allow `Bearer` as well as `Token` | phoet | 2015-06-01 | 1 | -0/+7 |
| | | |||||
| * | actually test what the name says | phoet | 2015-06-01 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #20138 from tgxworld/deprecated_assert_template | Rafael Mendonça França | 2015-06-01 | 9 | -381/+100 |
|\ \ | | | | | | | Deprecate `assert_template` and `assigns()`. | ||||
| * | | Remove `assigns` and `assert_template`. | Guo Xiang Tan | 2015-05-30 | 9 | -381/+100 |
| |/ | |||||
* | | Merge pull request #20284 from kaspth/fix-caching-test | Rafael Mendonça França | 2015-06-01 | 1 | -3/+7 |
|\ \ | |/ |/| | Move expectation to instance level. | ||||
| * | Replace expectation with state check. | Kasper Timm Hansen | 2015-05-30 | 1 | -3/+7 |
| | | | | | | | | The tests would still pass if the cache call in the rendered templates were removed. | ||||
* | | Fix warning about ambiguous first argument | Arun Agrawal | 2015-05-29 | 1 | -1/+1 |
| | | |||||
* | | Deprecate `:nothing` option for render method | Mehmet Emin İNAÇ | 2015-05-28 | 7 | -12/+22 |
| | | | | | | | | `head` method works similar to `render` method with `:nothing` option | ||||
* | | Merge pull request #19808 from byroot/action-parameter | Rafael Mendonça França | 2015-05-27 | 1 | -0/+20 |
|\ \ | | | | | | | [PoC] Stop shadowing parameters named `action` | ||||
| * | | Allow to parameters named `action` or `controller` from AC::TestCase helpers | Jean Boussier | 2015-04-18 | 1 | -0/+20 |
| | | | |||||
* | | | Merge pull request #17788 from sivagollapalli/master | Arthur Nogueira Neves | 2015-05-20 | 1 | -0/+5 |
|\ \ \ | |_|/ |/| | | Issue#17703 Test case for tempfile attribute | ||||
| * | | Issue#17703 Test case for tempfile attribute | Siva Gollapalli | 2015-04-16 | 1 | -0/+5 |
| |/ | | | | | | | | | | | | | | | | | | | + To avoid regression I am adding this test case on action pack Changed to assert from assert_equal + Added msg to assertion Modified msg | ||||
* | | Give authentication methods the ability to customize response message. | Keenan Brock | 2015-05-03 | 2 | -6/+6 |
| | | | | | | | | Digest allowed the messages. Add the same feature to basic and token | ||||
* | | Removed unused code from request_forgery_protection tests | Prathamesh Sonpatki | 2015-04-26 | 1 | -17/+0 |
| | | |||||
* | | Why do we add a top-level constant here? | Akira Matsuda | 2015-04-25 | 1 | -5/+3 |
| | | |||||
* | | Remove unused WorkshopsController class in redirect_test. | Bryce Boe | 2015-04-23 | 1 | -3/+0 |
|/ | |||||
* | Merge pull request #19736 from kmcphillips/master | Rafael Mendonça França | 2015-04-14 | 1 | -0/+17 |
|\ | | | | | Set default form builder for a controller | ||||
| * | Override default form builder for a controller | Kevin McPhillips | 2015-04-13 | 1 | -0/+17 |
| | | |||||
* | | Revert "Merge pull request #19682 from ↵ | Santiago Pastorino | 2015-04-12 | 1 | -25/+0 |
|/ | | | | | | | supercaracal/fix_force_ssl_redirection_flash_error" This reverts commit d215620340be7cb29e2aa87aab22da5ec9e6e6a7, reversing changes made to bbbbfe1ac02162ecb5e9a7b560134a3221f129f3. | ||||
* | fix a wrong feature test method name | Taishi Kasuga | 2015-04-11 | 1 | -1/+1 |
| | |||||
* | fix fails to force_ssl_redirection if session_store is disabled | Taishi Kasuga | 2015-04-09 | 1 | -0/+25 |
| | |||||
* | Fix ActionPack tests after changes to missing template logger | eileencodes | 2015-04-06 | 1 | -0/+1 |
| | | | | | | | | | After merging #19377 ActionPack tests were missing a require for `ActiveSupport::LogSubscriber::TestHelper` and change didn't take into account that logger could be nil. Added the require and only log to info if logger exists. This wasn't caught earlier because these tests only run after a merge. | ||||
* | head no_content when there is no template or action performed | Stephen Bussey | 2015-04-05 | 1 | -6/+16 |
| | |||||
* | Return super in ActionController::Parameters.const_missing | Shuhei Kagawa | 2015-03-28 | 1 | -1/+8 |
| | | | | | | | | | | | | | | | | | | | | | The current implementation of ActionController::Parameters.const_missing returns `ActionController::Parameters.always_permitted_parameters` even if its `super` returns a constant without raising error. This prevents its subclass in a autoloading module/class from taking advantage of autoloading constants. class SomeParameters < ActionController::Parameters def do_something DefinedSomewhere.do_something end end In the code above, `DefinedSomewhere` is to be autoloaded with `Module.const_missing` but `ActionController::Parameters.const_missing` returns `always_permitted_parameters` instead of the autoloaded constant. This pull request fixes the issue respecting `const_missing`'s `super`. | ||||
* | Fix failing tests for #19474 | Andrew White | 2015-03-23 | 1 | -2/+2 |
| | |||||
* | remove old unavailable link with relevant fix | Gaurav Sharma | 2015-03-23 | 1 | -2/+2 |
| | |||||
* | Fix kwargs warning in `test_get_xml` | eileencodes | 2015-03-20 | 1 | -1/+1 |
| | | | | | | ActionDispatch::IntegrationTest HTTP request methods will accept only certain kwargs in the future. This test caused a deprecation warning when running ActionPack tests. Added `params` and `headers` to fix. | ||||
* | Fix test messages use directly true, false and nil instead of their symbol | Akshay Vishnoi | 2015-03-19 | 1 | -3/+3 |
| | |||||
* | Compare content_type with Mime::XML instead of regexp | Boris Peterbarg | 2015-03-16 | 1 | -0/+17 |
| | | | | | Regexp is broken for both content types including charsets and for integration tests, where the content_type is a Mime::Type and not String | ||||
* | Merge pull request #19291 from hired/return-truthy-value-from-head | Rafael Mendonça França | 2015-03-13 | 1 | -0/+11 |
|\ | | | | | Return truthy value from head method | ||||
| * | Return true from head method | Joel Hayhurst | 2015-03-12 | 1 | -0/+11 |
| | | | | | | | | | | | | It was returning false in normal circumstances. This broke the `head :ok and return if` construct. Add appropriate test. | ||||
* | | Use request.session.id instead of request.session_options[:id] | Brian John | 2015-03-12 | 1 | -8/+0 |
|/ | | | | | | | | | As of the upgrade to Rack 1.5, request.session_options[:id] is no longer populated. Reflect this change in the tests by using request.session.id instead. Related change in Rack: https://github.com/rack/rack/commit/83a270d6 | ||||
* | Call super last in before_setup | eileencodes | 2015-03-09 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | This fixes the reasons 4cf3b8a, 303567e, and fa63448 needed to be reverted in 7142059. The revert has been reverted and this fixes the issues caused previously. If we call `super` first we will end up nuking the session settings in the application tests that do `setup do` - so any session login or cookie settings will not be persisted thoughout the test sessions. Calling `super` last prevents `@integration_session` from getting nuked and set to nil if it's already set. Test added to prevent regression of this behavior in the future. | ||||
* | pass a config to the route set | Aaron Patterson | 2015-03-05 | 1 | -6/+10 |
| | | | | | This way we can get the relative_url_root from the application without setting another global value | ||||
* | Merge pull request #18775 from yasyf/issue_5122 | Rafael Mendonça França | 2015-03-03 | 1 | -0/+10 |
|\ | | | | | | | Fallback to RAILS_RELATIVE_URL_ROOT in `url_for` | ||||
| * | Fallback to RAILS_RELATIVE_URL_ROOT in `url_for`. | Yasyf Mohamedali | 2015-02-24 | 1 | -0/+10 |
| | | | | | | | | | | | | Fixed an issue where the `RAILS_RELATIVE_URL_ROOT` environment variable is not prepended to the path when `url_for` is called. If `SCRIPT_NAME` (used by Rack) is set, it takes precedence. | ||||
* | | Skip the failing tests on Rubinius for now | Robin Dupret | 2015-03-02 | 1 | -0/+2 |
| | | |||||
* | | fix NameError in `skip_filter`. callback doesn't exist. | yuuji.yaginuma | 2015-02-27 | 1 | -0/+8 |
| | | |||||
* | | Fix default headers in test responses | Jeremy Kemper | 2015-02-25 | 2 | -16/+64 |
| | | | | | | | | | | | | | | Fixes regression in #18423. Merge default headers for new responses, but don't merge when creating a response from the last session request. hat tip @senny :heart: |