Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #15545 from zuhao/refactor_actionpack_assert_select_test | Yves Senn | 2014-06-08 | 1 | -1/+4 |
|\ | | | | | Restore test deliveries for ActionMailer. | ||||
| * | Restore test deliveries for ActionMailer. | Zuhao Wan | 2014-06-07 | 1 | -1/+4 |
| | | |||||
* | | Handle client disconnect during live streaming | Matthew Draper | 2014-06-08 | 1 | -0/+89 |
| | | | | | | | | .. even when the producer is blocked for a write. | ||||
* | | adds some details to the rationale of converted_arrays [ci skip] | Xavier Noria | 2014-06-07 | 1 | -1/+1 |
| | | |||||
* | | adds a regression test for the strong params converted arrays cache | Xavier Noria | 2014-06-07 | 1 | -1/+18 |
| | | | | | | | | This is a regression test for 29844dd. | ||||
* | | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded" | Xavier Noria | 2014-06-07 | 1 | -1/+1 |
|/ | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b. | ||||
* | Mime::PNG is already defined. | Zuhao Wan | 2014-06-05 | 1 | -6/+0 |
| | |||||
* | Merge pull request #15498 from zenspider/fix_memory_leak | Guillermo Iguaran | 2014-06-03 | 1 | -1/+1 |
|\ | | | | | Convert StrongParameters cache to a hash. This fixes an unbounded memory leak | ||||
| * | Convert StrongParameters cache to a hash. This fixes an unbounded | Ryan Davis | 2014-06-03 | 1 | -1/+1 |
| | | | | | | | | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html | ||||
* | | add tests for nested lambda constraints | Aaron Patterson | 2014-06-03 | 1 | -0/+27 |
|/ | |||||
* | Merge pull request #15384 from zuhao/refactor_actionpack_params_wrapper_test | Yves Senn | 2014-05-29 | 1 | -7/+19 |
|\ | | | | | Clear inflections after test. | ||||
| * | Clear inflections after test. | Zuhao Wan | 2014-05-28 | 1 | -7/+19 |
| | | |||||
* | | Merge pull request #15386 from ↵ | Santiago Pastorino | 2014-05-28 | 1 | -3/+6 |
|\ \ | | | | | | | | | | | | | zuhao/refactor_actionpack_request_forgery_protection_test Avoid hardcoded `request_forgery_protection_token` value in teardown. | ||||
| * | | Avoid hardcoded value in teardown. | Zuhao Wan | 2014-05-28 | 1 | -3/+6 |
| | | | |||||
* | | | Merge pull request #15388 from zuhao/refactor_actionpack_send_file_test | Santiago Pastorino | 2014-05-28 | 1 | -2/+6 |
|\ \ \ | | | | | | | | | Unregister Mime::Type in teardown. | ||||
| * | | | Unregister Mime::Type in teardown. | Zuhao Wan | 2014-05-28 | 1 | -2/+6 |
| |/ / | |||||
* | | | Merge pull request #15385 from zuhao/refactor_actionpack_render_other_test | Santiago Pastorino | 2014-05-28 | 1 | -4/+7 |
|\ \ \ | |/ / |/| | | Add and remove renderer inside the test to prevent leak. | ||||
| * | | Add and remove renderer inside the test to prevent leak. | Zuhao Wan | 2014-05-28 | 1 | -4/+7 |
| |/ | |||||
* | | Merge pull request #15383 from ↵ | Yves Senn | 2014-05-28 | 1 | -10/+8 |
|\ \ | |/ |/| | | | | | zuhao/refactor_actionpack_localized_templates_test Move I18n.locale setting into setup and teardown. | ||||
| * | Move I18n.locale setting into setup and teardown. | Zuhao Wan | 2014-05-28 | 1 | -10/+8 |
| | | |||||
* | | Add with_default_charset helper. | Zuhao Wan | 2014-05-28 | 1 | -12/+20 |
|/ | |||||
* | Deprecate all *_filter callbacks in favor of *_action callbacks | Rafael Mendonça França | 2014-05-27 | 2 | -191/+191 |
| | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c | ||||
* | PARAMETERS_KEY is only used in the request, so move the constant there | Aaron Patterson | 2014-05-27 | 1 | -5/+5 |
| | |||||
* | The correct status to test should be :switching_protocols. | Zuhao Wan | 2014-05-25 | 1 | -2/+2 |
| | |||||
* | use symbol keys for path_parameters | Aaron Patterson | 2014-05-22 | 1 | -5/+5 |
| | |||||
* | Merge pull request #11346 from tomykaira/fix_10257 | Rafael Mendonça França | 2014-05-20 | 1 | -0/+7 |
|\ | | | | | Check authentication scheme in Basic auth | ||||
| * | Check authentication scheme in Basic auth | tomykaira | 2013-07-07 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257. | ||||
* | | Merge pull request #15182 from zuhao/refactor_actionpack_respond_with_test_2 | Yves Senn | 2014-05-20 | 1 | -4/+10 |
|\ \ | | | | | | | Un-define :to_json for Customer class after stubbing. | ||||
| * | | Add using_resouce_with_json to controller. | Zuhao Wan | 2014-05-20 | 1 | -4/+10 |
| | | | |||||
* | | | Merge pull request #15178 from zuhao/refactor_actionpack_respond_with_test | Yves Senn | 2014-05-20 | 1 | -0/+19 |
|\ \ \ | | | | | | | | | Deregister csv renderer after test to prevent leak. | ||||
| * | | | Add ActionController::Renderers.remove. | Zuhao Wan | 2014-05-20 | 1 | -0/+19 |
| |/ / | |||||
* / / | Revert "Rewrite journey routes formatter for performance" | Aaron Patterson | 2014-05-19 | 1 | -0/+20 |
|/ / | | | | | | | | | | | | | | | | | | | This reverts commit 5c224de9e110763ec7a0f01f5b604bcf81f40bfb. Conflicts: actionpack/lib/action_dispatch/journey/visitors.rb 5c224de9e110763ec7a0f01f5b604bcf81f40bfb introduced a bug in the formatter. This commit includes a regression test. | ||||
* | | fixes stack level too deep exception on action named 'status' returning ↵ | Christiaan Van den Poel | 2014-05-15 | 1 | -0/+31 |
| | | | | | | | | 'head :ok' | ||||
* | | Merge pull request #14137 from dasch/better-fragment-cache-instrumentation | Rafael Mendonça França | 2014-05-14 | 1 | -0/+16 |
|\ \ | | | | | | | | | | | | | | | | | | | Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md | ||||
| * | | Add controller and action name to the instrumentation payload | Daniel Schierbeck | 2014-05-10 | 1 | -0/+16 |
| | | | |||||
* | | | Merge pull request #15070 from ayamomiji/sse-patch | Aaron Patterson | 2014-05-14 | 1 | -0/+16 |
|\ \ \ | | | | | | | | | Add multiple lines message support for SSE module | ||||
| * | | | Add multiple lines message support for SSE module | ayaya | 2014-05-12 | 1 | -0/+16 |
| | | | | |||||
* | | | | Fix regression on `assert_redirected_to`. | Arthur Neves | 2014-05-13 | 1 | -0/+6 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691] | ||||
* | | | Remove redundant tests method. | Guo Xiang Tan | 2014-05-11 | 1 | -2/+0 |
| | | | |||||
* | | | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵ | Guilherme Cavalcanti | 2014-05-11 | 1 | -0/+12 |
| | | | | | | | | | | | | relative URL. | ||||
* | | | just call the method and assert the return value | Aaron Patterson | 2014-05-09 | 1 | -8/+1 |
| | | | | | | | | | | | | do not test internals | ||||
* | | | Merge pull request #14945 from tomkadwill/form_authenticity_param_refactor | Rafael Mendonça França | 2014-05-06 | 1 | -5/+26 |
|\ \ \ | | | | | | | | | Moved 'params[request_forgery_protection_token]' into its own method and... | ||||
| * | | | Moved 'params[request_forgery_protection_token]' into its own method and ↵ | Tom Kadwill | 2014-05-06 | 1 | -5/+26 |
| | | | | | | | | | | | | | | | | improved tests. | ||||
* | | | | Only accept actions without File::SEPARATOR in the name. | Rafael Mendonça França | 2014-05-06 | 1 | -1/+16 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid directory traversal in implicit render. Fixes: CVE-2014-0130 Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
* / / | Remove tests method for test cases when controller can be inferred. | Guo Xiang | 2014-05-03 | 5 | -21/+1 |
|/ / | |||||
* | | Remove wrapper div for inputs in button_to | Rafael Mendonça França | 2014-04-17 | 1 | -1/+1 |
| | | | | | | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2 | ||||
* | | Update Request forgery tests to remove input wrappign div | Rafael Mendonça França | 2014-04-17 | 1 | -5/+5 |
| | | | | | | | | This was changed at cbb917455f306cf5818644b162f22be09f77d4b2 | ||||
* | | Merge pull request #14728 from stomar/assertion-msg | Yves Senn | 2014-04-15 | 1 | -11/+13 |
|\ \ | | | | | | | Remove surplus period from assertion messages | ||||
| * | | Refine tests for assert_select failure messages | Marcus Stollsteimer | 2014-04-14 | 1 | -11/+13 |
| | | | |||||
* | | | Return null type format when format is not know | Rafael Mendonça França | 2014-04-14 | 1 | -0/+5 |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When requesting a controller with the following code with a unknown format: def my_action respond_to do |format| format.json { head :ok } format.any { render text: 'Default response' } end end we should render the default response instead of raising ActionController::UnknownFormat Fixes #14462 Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/mime/respond_with_test.rb Conflicts: actionpack/CHANGELOG.md |