Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Silence test deprecation warnings | Carlhuda | 2010-02-26 | 1 | -16/+55 | |
| | ||||||
* | Rename named_url_helpers to url_helpers and url_helpers to url_for | Carlhuda | 2010-02-26 | 4 | -9/+9 | |
| | ||||||
* | Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 ↵ | José Valim | 2010-02-26 | 1 | -0/+9 | |
| | | | | status:resolved] | |||||
* | Rename metaclass to singleton_class | Carlhuda | 2010-02-25 | 3 | -4/+4 | |
| | ||||||
* | Get URL helpers working again in integration tests. | Carlhuda | 2010-02-25 | 1 | -17/+7 | |
| | ||||||
* | Continued effort to deglobalize the router | Carlhuda | 2010-02-25 | 2 | -27/+8 | |
| | ||||||
* | Fix all of AP's tests with the non global router | Carlhuda | 2010-02-25 | 1 | -2/+4 | |
| | ||||||
* | Merge branch 'master' of github.com:rails/rails | Carlhuda | 2010-02-25 | 1 | -1/+1 | |
| | ||||||
* | WIP: Remove the global router | Carlhuda | 2010-02-25 | 8 | -35/+48 | |
| | ||||||
* | Cleanup render callstack and make render(:json => {}, :status => 401) work ↵ | José Valim | 2010-02-24 | 1 | -0/+10 | |
| | | | | again. | |||||
* | Remove ActionController::Base.resources_path_names | Carl Lerche | 2010-02-24 | 1 | -9/+10 | |
| | ||||||
* | Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. ↵ | Yehuda Katz | 2010-02-23 | 1 | -0/+9 | |
| | | | | Closes #8994 | |||||
* | Revert "Fix test load paths for those not using bundler" | Carlhuda | 2010-02-23 | 1 | -3/+0 | |
| | | | | | | This reverts commit eec2d301d4ce9df9c71c1a5aa63053eb970b6818. This commit broke tests. You cannot have a file called "bundler" on the load path. | |||||
* | Makes send_file work again by deferring to Rack::Sendfile. | Carlhuda | 2010-02-23 | 2 | -25/+2 | |
| | | | | | | | | | | * Add the Rack::Sendfile middleware * Make the header to use configurable via config.action_dispatch.x_sendfile_header (default to "X-Sendfile"). * Add Railties tests to confirm that these work * Remove the :stream, :buffer_size, and :x_senfile default options to send_file * Change the log subscriber to always say "Sent file" * Add deprecation warnings for options that are now no-ops Note that servers can configure this by setting X-Sendfile-Type. Hosting companies and those creating packages of servers specially designed for Rails applications are encouraged to specify this header so that this can work transparently. | |||||
* | Fix streaming by having it create a File object, which can be handled by ↵ | Carlhuda | 2010-02-23 | 1 | -3/+11 | |
| | | | | Rack servers as appropriate | |||||
* | Use ActionDispatch::Routing everywhere | Martin Schürrer | 2010-02-21 | 4 | -9/+9 | |
| | ||||||
* | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 2 | -11/+11 | |
| | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | |||||
* | AMo #key is now #to_key and CI is probably happy | snusnu | 2010-02-20 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch. | |||||
* | Fix a bunch of pending tests by providing an introspection mode for the ↵ | Carlhuda | 2010-02-19 | 1 | -2/+1 | |
| | | | | Response object that does up-front parsing of the headers to populate things like @etag | |||||
* | Reinstate pending tests that were supposed to be fixed before the | Joshua Peek | 2010-02-19 | 1 | -13/+11 | |
| | | | | | | beta. Shout louder this time so they actually get fixed. | |||||
* | Merge master. | José Valim | 2010-02-17 | 1 | -0/+3 | |
|\ | ||||||
| * | Fix test load paths for those not using bundler | Joshua Peek | 2010-02-15 | 1 | -0/+3 | |
| | | ||||||
* | | Make Railties tests green again. | José Valim | 2010-02-17 | 1 | -1/+1 | |
| | | ||||||
* | | Ensure render :text => resource first tries to invoke :to_text on it | José Valim | 2010-02-16 | 1 | -0/+9 | |
| | | ||||||
* | | Rename Rails::Subscriber to Rails::LogSubscriber | Prem Sichanugrist | 2010-02-16 | 1 | -9/+9 | |
|/ | ||||||
* | Updates subscriber test for new output | Yehuda Katz | 2010-02-05 | 1 | -1/+1 | |
| | ||||||
* | Test that csrf meta content is html-escaped, too | Jeremy Kemper | 2010-02-04 | 1 | -1/+2 | |
| | ||||||
* | Revert dumb test | Jeremy Kemper | 2010-02-04 | 1 | -2/+2 | |
| | ||||||
* | HTML-escape csrf meta contents | Jeremy Kemper | 2010-02-04 | 1 | -2/+2 | |
| | ||||||
* | Expose CSRF param name also | Jeremy Kemper | 2010-02-04 | 1 | -1/+1 | |
| | ||||||
* | Expose CSRF tag for UJS adapters | Jeremy Kemper | 2010-02-04 | 1 | -1/+15 | |
| | ||||||
* | Convert to class_attribute | Jeremy Kemper | 2010-02-01 | 1 | -2/+2 | |
| | ||||||
* | Add support for compile-time <%= raw %> | Yehuda Katz | 2010-01-31 | 1 | -22/+34 | |
| | ||||||
* | For performance reasons, you can no longer call html_safe! on Strings. ↵ | Yehuda Katz | 2010-01-31 | 2 | -3/+3 | |
| | | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe. | |||||
* | deOMGifying Railties, Active Support, and Action Pack | Mikel Lindsaar | 2010-01-31 | 5 | -31/+31 | |
| | ||||||
* | Improve missing template error messages a little bit. | José Valim | 2010-01-31 | 1 | -1/+1 | |
| | ||||||
* | Move form_remote_tag and remote_form_for into prototype_legacy_helper | Joshua Peek | 2010-01-30 | 1 | -27/+18 | |
| | ||||||
* | Bring helpers_dir deprecation back. | José Valim | 2010-01-30 | 1 | -11/+10 | |
| | ||||||
* | Get rid of AM warnings in AP test suite. | José Valim | 2010-01-29 | 1 | -2/+2 | |
| | ||||||
* | ActionMailer should depend just on AbstractController. | José Valim | 2010-01-29 | 1 | -0/+272 | |
| | ||||||
* | Fix t('.helper'). | José Valim | 2010-01-26 | 1 | -10/+11 | |
| | ||||||
* | Add a deprecation for helpers_dir. | José Valim | 2010-01-25 | 1 | -2/+13 | |
| | ||||||
* | Fix failing tests after merge. | José Valim | 2010-01-24 | 1 | -2/+2 | |
| | ||||||
* | Make filter parameters based on request, so they can be modified for ↵ | José Valim | 2010-01-21 | 2 | -6/+20 | |
| | | | | anything in the middleware stack. | |||||
* | Default to sync instrumentation. | José Valim | 2010-01-21 | 1 | -15/+3 | |
| | ||||||
* | Tidy up new filter_parameters implementation. | José Valim | 2010-01-21 | 1 | -1/+4 | |
| | ||||||
* | Add deprecation warning for calling filter_parameter_logging ↵ | Prem Sichanugrist | 2010-01-21 | 1 | -51/+0 | |
| | | | | | | ActionController::Base, and allow it to be configured in config.filter_parameters Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Move ActionController::Translation to AbstractController::Translation. | José Valim | 2010-01-20 | 1 | -26/+0 | |
| | ||||||
* | Stop overriding LoadError.new to return a MissingSourceError (and sometimes ↵ | Yehuda Katz | 2010-01-19 | 1 | -1/+1 | |
| | | | | nil!) | |||||
* | Move parameters to the top on logging. | José Valim | 2010-01-19 | 1 | -24/+30 | |
| |