Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | only call methods that are on the superclass | Aaron Patterson | 2015-07-14 | 2 | -3/+3 |
| | | | | | | We want to treat the response object as if it's a real response object (not a test object), so we should only call methods that are on the superclass. | ||||
* | only have one TestResponse class | Aaron Patterson | 2015-07-13 | 1 | -1/+1 |
| | |||||
* | use `Rack::Test::UploadedFile` when uploading files | Aaron Patterson | 2015-07-09 | 1 | -2/+2 |
| | | | | | We should use rack-test's upload file objects on the test side so that we will be able to correctly generate mime blob posts in the future | ||||
* | set parameters as a query string | Aaron Patterson | 2015-07-09 | 1 | -1/+1 |
| | | | | | | We should convert request parameters to a query string, then let the request object parse that query string. This should give us results that are more similar to the real-world | ||||
* | use JSON to communicate between the controller and the tests | Aaron Patterson | 2015-07-09 | 1 | -12/+12 |
| | |||||
* | build and assign parameters rather than rely on mutations | Aaron Patterson | 2015-07-08 | 1 | -3/+3 |
| | | | | | We should assign parameters to the request object rather than mutate the hash that is returned by `query_parameters` or `request_parameters` | ||||
* | request objects are no longer recycled | Aaron Patterson | 2015-07-08 | 1 | -6/+0 |
| | | | | | | Instead of trying to manually clear out a request object, lets just allocate a new one. The rack ENV is reused and cleaned (still), but the request object is not. | ||||
* | pass the variant as a parameter to more reflect real world apps | Aaron Patterson | 2015-07-08 | 1 | -3/+3 |
| | |||||
* | remove call to build_request | Aaron Patterson | 2015-07-08 | 1 | -1/+0 |
| | |||||
* | let the superclass build the request and response | Aaron Patterson | 2015-07-08 | 10 | -47/+13 |
| | | | | | We should leverage the request / response objects that the superclass has already allocated for us. | ||||
* | pass variants in rather than mutating the request. | Aaron Patterson | 2015-07-07 | 1 | -48/+31 |
| | | | | | | Variants are typically set in the controller based on some attribute of the request that the browser sent. We should make our tests more in line with reality by doing the same and not mutating the request object. | ||||
* | Fix the random caching test failure. | Kasper Timm Hansen | 2015-07-05 | 1 | -0/+1 |
| | |||||
* | Override default_render's behavior with a block | Dave Copeland | 2015-06-20 | 1 | -0/+21 |
| | | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`. | ||||
* | Deprecate passing hash as first parameter into ActionController::Head | Mehmet Emin İNAÇ | 2015-06-15 | 3 | -10/+31 |
| | |||||
* | Fix flakyness. | Kasper Timm Hansen | 2015-06-15 | 1 | -0/+1 |
| | | | | Brought on by my own stupidity :) | ||||
* | Return 204 if render is not called in API controllers | Jorge Bejar | 2015-06-11 | 1 | -0/+15 |
| | |||||
* | Add test coverage for implicit render in empty actions | Jorge Bejar | 2015-06-11 | 1 | -0/+14 |
| | |||||
* | Include ParamsWrapper in AC::API | Jorge Bejar | 2015-06-11 | 1 | -0/+26 |
| | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it. | ||||
* | Rename test methods in api conditional get controller tests | Jorge Bejar | 2015-06-11 | 1 | -2/+2 |
| | |||||
* | Use new hash syntax | Santiago Pastorino | 2015-06-11 | 2 | -7/+7 |
| | |||||
* | Use nex hash syntax on tests | Santiago Pastorino | 2015-06-11 | 1 | -5/+5 |
| | |||||
* | Move Model test class inside RenderersApiController namespace | Santiago Pastorino | 2015-06-11 | 1 | -8/+8 |
| | |||||
* | Add ActionController API functionality | Santiago Pastorino | 2015-06-11 | 6 | -0/+180 |
| | |||||
* | Merge pull request #19094 from phoet/have_bearer_be_valid_as_well | Rafael Mendonça França | 2015-06-01 | 1 | -1/+8 |
|\ | | | | | Have Bearer be valid as well | ||||
| * | allow `Bearer` as well as `Token` | phoet | 2015-06-01 | 1 | -0/+7 |
| | | |||||
| * | actually test what the name says | phoet | 2015-06-01 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #20138 from tgxworld/deprecated_assert_template | Rafael Mendonça França | 2015-06-01 | 9 | -381/+100 |
|\ \ | | | | | | | Deprecate `assert_template` and `assigns()`. | ||||
| * | | Remove `assigns` and `assert_template`. | Guo Xiang Tan | 2015-05-30 | 9 | -381/+100 |
| |/ | |||||
* | | Merge pull request #20284 from kaspth/fix-caching-test | Rafael Mendonça França | 2015-06-01 | 1 | -3/+7 |
|\ \ | |/ |/| | Move expectation to instance level. | ||||
| * | Replace expectation with state check. | Kasper Timm Hansen | 2015-05-30 | 1 | -3/+7 |
| | | | | | | | | The tests would still pass if the cache call in the rendered templates were removed. | ||||
* | | Fix warning about ambiguous first argument | Arun Agrawal | 2015-05-29 | 1 | -1/+1 |
| | | |||||
* | | Deprecate `:nothing` option for render method | Mehmet Emin İNAÇ | 2015-05-28 | 7 | -12/+22 |
| | | | | | | | | `head` method works similar to `render` method with `:nothing` option | ||||
* | | Merge pull request #19808 from byroot/action-parameter | Rafael Mendonça França | 2015-05-27 | 1 | -0/+20 |
|\ \ | | | | | | | [PoC] Stop shadowing parameters named `action` | ||||
| * | | Allow to parameters named `action` or `controller` from AC::TestCase helpers | Jean Boussier | 2015-04-18 | 1 | -0/+20 |
| | | | |||||
* | | | Merge pull request #17788 from sivagollapalli/master | Arthur Nogueira Neves | 2015-05-20 | 1 | -0/+5 |
|\ \ \ | |_|/ |/| | | Issue#17703 Test case for tempfile attribute | ||||
| * | | Issue#17703 Test case for tempfile attribute | Siva Gollapalli | 2015-04-16 | 1 | -0/+5 |
| |/ | | | | | | | | | | | | | | | | | | | + To avoid regression I am adding this test case on action pack Changed to assert from assert_equal + Added msg to assertion Modified msg | ||||
* | | Give authentication methods the ability to customize response message. | Keenan Brock | 2015-05-03 | 2 | -6/+6 |
| | | | | | | | | Digest allowed the messages. Add the same feature to basic and token | ||||
* | | Removed unused code from request_forgery_protection tests | Prathamesh Sonpatki | 2015-04-26 | 1 | -17/+0 |
| | | |||||
* | | Why do we add a top-level constant here? | Akira Matsuda | 2015-04-25 | 1 | -5/+3 |
| | | |||||
* | | Remove unused WorkshopsController class in redirect_test. | Bryce Boe | 2015-04-23 | 1 | -3/+0 |
|/ | |||||
* | Merge pull request #19736 from kmcphillips/master | Rafael Mendonça França | 2015-04-14 | 1 | -0/+17 |
|\ | | | | | Set default form builder for a controller | ||||
| * | Override default form builder for a controller | Kevin McPhillips | 2015-04-13 | 1 | -0/+17 |
| | | |||||
* | | Revert "Merge pull request #19682 from ↵ | Santiago Pastorino | 2015-04-12 | 1 | -25/+0 |
|/ | | | | | | | supercaracal/fix_force_ssl_redirection_flash_error" This reverts commit d215620340be7cb29e2aa87aab22da5ec9e6e6a7, reversing changes made to bbbbfe1ac02162ecb5e9a7b560134a3221f129f3. | ||||
* | fix a wrong feature test method name | Taishi Kasuga | 2015-04-11 | 1 | -1/+1 |
| | |||||
* | fix fails to force_ssl_redirection if session_store is disabled | Taishi Kasuga | 2015-04-09 | 1 | -0/+25 |
| | |||||
* | Fix ActionPack tests after changes to missing template logger | eileencodes | 2015-04-06 | 1 | -0/+1 |
| | | | | | | | | | After merging #19377 ActionPack tests were missing a require for `ActiveSupport::LogSubscriber::TestHelper` and change didn't take into account that logger could be nil. Added the require and only log to info if logger exists. This wasn't caught earlier because these tests only run after a merge. | ||||
* | head no_content when there is no template or action performed | Stephen Bussey | 2015-04-05 | 1 | -6/+16 |
| | |||||
* | Return super in ActionController::Parameters.const_missing | Shuhei Kagawa | 2015-03-28 | 1 | -1/+8 |
| | | | | | | | | | | | | | | | | | | | | | The current implementation of ActionController::Parameters.const_missing returns `ActionController::Parameters.always_permitted_parameters` even if its `super` returns a constant without raising error. This prevents its subclass in a autoloading module/class from taking advantage of autoloading constants. class SomeParameters < ActionController::Parameters def do_something DefinedSomewhere.do_something end end In the code above, `DefinedSomewhere` is to be autoloaded with `Module.const_missing` but `ActionController::Parameters.const_missing` returns `always_permitted_parameters` instead of the autoloaded constant. This pull request fixes the issue respecting `const_missing`'s `super`. | ||||
* | Fix failing tests for #19474 | Andrew White | 2015-03-23 | 1 | -2/+2 |
| | |||||
* | remove old unavailable link with relevant fix | Gaurav Sharma | 2015-03-23 | 1 | -2/+2 |
| |