| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | execute a request and check the path_parameters | Aaron Patterson | 2014-07-15 | 1 | -17/+59 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | This actually runs a request through the system, using the actual routing methods as we would use in production, then tests the path_parameters set on the request object. The `recognize_path` method isn't actually used in production, so testing what it returns isn't useful. | |||||
| | * | | set `set` in the setup method | Aaron Patterson | 2014-07-15 | 1 | -2/+5 | |
| | | | | ||||||
| | * | | remove useless ivar set | Aaron Patterson | 2014-07-15 | 1 | -1/+0 | |
| | | | | ||||||
| | * | | Fix typos like `a html` to `an html` and 'an mail' to 'an email'. [ci skip] | Santosh Wadghule | 2014-07-14 | 1 | -2/+2 | |
| | | | | ||||||
| | * | | Removed single space padding from empty response body. | Godfrey Chan | 2014-07-10 | 4 | -16/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `render nothing: true` or rendering a `nil` body no longer add a single space to the response body. The old behavior was added as a workaround for a bug in an early version of Safari, where the HTTP headers are not returned correctly if the response body has a 0-length. This is been fixed since and the workaround is no longer necessary. Use `render body: ' '` if the old behavior is desired. | |||||
| * | | | We don't need loofah for the assertions | Rafael Mendonça França | 2014-07-15 | 1 | -3/+3 | |
| | | | | | | | | | | | | | We can just use nokogiri | |||||
| * | | | Merge pull request #11218 from kaspth/loofah-integration | Rafael Mendonça França | 2014-07-10 | 6 | -1175/+5 | |
| |\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md | |||||
| | * | | Remove unneeded comment in test. | Timm | 2014-06-16 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | Nokogiri leaves '<' unescaped, so the assert_select looking for '<' will ↵ | Timm | 2014-06-16 | 1 | -2/+3 | |
| | | | | | | | | | | | | | never work. Switched to assert_matching the reponse body. | |||||
| | * | | Removed require's for html-scanner. | Timm | 2014-06-16 | 2 | -2/+0 | |
| | | | | ||||||
| | * | | Moved Dom and Selector assertions from ActionDispatch to ActionView. | Timm | 2014-06-16 | 1 | -350/+0 | |
| | | | | ||||||
| | * | | Fixed: assert_select_encoded finds the right content. No longer uses a ↵ | Timm | 2014-06-16 | 1 | -9/+2 | |
| | | | | | | | | | | | | | <encoded> wrapper. Updated tests to reflect this. | |||||
| | * | | Fixed: test_nested_assert_select selects from elements instead of ↵ | Timm | 2014-06-16 | 1 | -2/+2 | |
| | | | | | | | | | | | | | elements[0] and elements[1]. | |||||
| | * | | Changed xml_namespace test to correct syntax. However, Nokogiri won't ↵ | Timm | 2014-06-16 | 1 | -2/+3 | |
| | | | | | | | | | | | | | recognize the namespace. | |||||
| | * | | Changed test methods to use new substitution syntax more in line with css ↵ | Timm | 2014-06-16 | 1 | -3/+3 | |
| | | | | | | | | | | | | | selectors. | |||||
| | * | | Fixed typo in method name. Fixed Nokogiri::CSS::SyntaxError. | Timm | 2014-06-15 | 1 | -2/+2 | |
| | | | | ||||||
| | * | | Changed tests to assert_kind_of Loofah::HTML::Document. | Timm | 2014-06-15 | 1 | -3/+3 | |
| | | | | ||||||
| | * | | Removed selector_test.rb since HTML::Selector will be removed. Soon. | Timm | 2014-06-15 | 1 | -629/+0 | |
| | | | | ||||||
| | * | | Fixed Nokogiri::CSS::SyntaxErrors. | Timm | 2014-06-15 | 1 | -2/+2 | |
| | | | | | | | | | | | | | Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters. | |||||
| | * | | Removed tag.rb since it has been deprecated. | Timm | 2014-06-15 | 2 | -184/+0 | |
| | | | | ||||||
| * | | | Address CVE-2014-4671 (JSONP Flash exploit) | Greg Campbell | 2014-07-09 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | Adds a comment before JSONP callbacks. See http://miki.it/blog/2014/7/8/abusing-jsonp-with-rosetta-flash/ for more details on the exploit in question. | |||||
| * | | | Merge pull request #16013 from tgxworld/remove_symbolized_path_parameters | Rafael Mendonça França | 2014-07-04 | 1 | -3/+3 | |
| |\ \ \ | | | | | | | | | Remove symbolized_path_parameters. | |||||
| | * | | | Remove symbolized_path_parameters. | Guo Xiang Tan | 2014-07-02 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | This pull request is a continuation of https://github.com/rails/rails/commit/925bd975 and https://github.com/rails/rails/commit/8d8ebe3d. | |||||
| * | | | | Merge pull request #16011 from xjlu/token_and_options | Rafael Mendonça França | 2014-07-04 | 1 | -2/+22 | |
| |\ \ \ \ | | | | | | | | | | | Improve token_and_options regex and test | |||||
| | * | | | | Improve token_and_options regex and test | Xinjiang Lu | 2014-07-01 | 1 | -2/+22 | |
| | |/ / / | | | | | | | | | | | | | add a test case to test the regex for the helper method raw_params | |||||
| * / / / | Change the JSON renderer to enforce the 'JS' Content Type | Lucas Mazza | 2014-07-02 | 1 | -0/+13 | |
| |/ / / | | | | | | | | | | | | | | | | | | | The controller can set the response format as 'JSON' before the renderer code be evaluated, so we must replace it when necessary. Fixes #15081 | |||||
| * | | | Merge pull request #15933 from rafael/master | Rafael Mendonça França | 2014-06-27 | 1 | -0/+29 | |
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | Add always permitted parameters as a configurable option. [Rafael Mendonça França + Gary S. Weaver] | |||||
| | * | | | Improvements per code review. | Rafael Chacón | 2014-06-27 | 1 | -0/+29 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | * General style fixes. * Add changes to configuration guide. * Add missing tests. | |||||
| * | | | | Merge pull request #15537 from tgxworld/fix_state_leak | Matthew Draper | 2014-06-20 | 3 | -4/+5 | |
| |\ \ \ \ | | | | | | | | | | | Fix state leak. | |||||
| | * | | | | Remove redundant code. | Guo Xiang Tan | 2014-06-05 | 1 | -4/+0 | |
| | | | | | | ||||||
| | * | | | | Prevent state leak. | Guo Xiang Tan | 2014-06-05 | 3 | -0/+5 | |
| | | | | | | ||||||
| * | | | | | Merge pull request #15692 from sromano/falseClass | Matthew Draper | 2014-06-14 | 1 | -1/+17 | |
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | ActionController::Parameters#require now accepts FalseClass values | |||||
| | * | | | | | ActionController::Parameters#require now accepts FalseClass values | Sergio Romano | 2014-06-13 | 1 | -1/+17 | |
| |/ / / / / | | | | | | | | | | | | | | | | Fixes #15685. | |||||
| * | | | | | Fix parsed token value with header `Authorization token=`. | Larry Lv | 2014-06-13 | 1 | -6/+23 | |
| | | | | | | ||||||
| * | | | | | use Ruby for mocking | Aaron Patterson | 2014-06-12 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | remove warnings | Kuldeep Aggarwal | 2014-06-12 | 1 | -1/+0 | |
| | |_|/ / |/| | | | | | | | | | | | warning: assigned but unused variable - scope_called, path and strexp | |||||
| * | | | | Merge pull request #15545 from zuhao/refactor_actionpack_assert_select_test | Yves Senn | 2014-06-08 | 1 | -1/+4 | |
| |\ \ \ \ | | | | | | | | | | | Restore test deliveries for ActionMailer. | |||||
| | * | | | | Restore test deliveries for ActionMailer. | Zuhao Wan | 2014-06-07 | 1 | -1/+4 | |
| | |/ / / | ||||||
| * | | | | Handle client disconnect during live streaming | Matthew Draper | 2014-06-08 | 1 | -0/+89 | |
| | | | | | | | | | | | | | | | | | .. even when the producer is blocked for a write. | |||||
| * | | | | adds some details to the rationale of converted_arrays [ci skip] | Xavier Noria | 2014-06-07 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | adds a regression test for the strong params converted arrays cache | Xavier Noria | 2014-06-07 | 1 | -1/+18 | |
| | | | | | | | | | | | | | | | | | This is a regression test for 29844dd. | |||||
| * | | | | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded" | Xavier Noria | 2014-06-07 | 1 | -1/+1 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b. | |||||
| * | | | Mime::PNG is already defined. | Zuhao Wan | 2014-06-05 | 1 | -6/+0 | |
| | | | | ||||||
| * | | | Merge pull request #15498 from zenspider/fix_memory_leak | Guillermo Iguaran | 2014-06-03 | 1 | -1/+1 | |
| |\ \ \ | | | | | | | | | Convert StrongParameters cache to a hash. This fixes an unbounded memory leak | |||||
| | * | | | Convert StrongParameters cache to a hash. This fixes an unbounded | Ryan Davis | 2014-06-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html | |||||
| * | | | | add tests for nested lambda constraints | Aaron Patterson | 2014-06-03 | 1 | -0/+27 | |
| |/ / / | ||||||
| * | | | Merge pull request #15384 from zuhao/refactor_actionpack_params_wrapper_test | Yves Senn | 2014-05-29 | 1 | -7/+19 | |
| |\ \ \ | | | | | | | | | Clear inflections after test. | |||||
| | * | | | Clear inflections after test. | Zuhao Wan | 2014-05-28 | 1 | -7/+19 | |
| | | | | | ||||||
| * | | | | Merge pull request #15386 from ↵ | Santiago Pastorino | 2014-05-28 | 1 | -3/+6 | |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_actionpack_request_forgery_protection_test Avoid hardcoded `request_forgery_protection_token` value in teardown. | |||||
| | * | | | | Avoid hardcoded value in teardown. | Zuhao Wan | 2014-05-28 | 1 | -3/+6 | |
| | | | | | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Eilertsens Kodeknekkeri |
| aboutsummaryrefslogtreecommitdiffstats |