Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Moved encoding work in progress to a feature branch. | Jeremy Kemper | 2010-05-16 | 3 | -5/+5 |
| | | | | This reverts commits af0d1a88157942c6e6398dbf73891cff1e152405 and 64d109e3539ad600f58536d3ecabd2f87b67fd1c. | ||||
* | Significantly improved internal encoding heuristics and support. | wycats | 2010-05-16 | 3 | -5/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Default Encoding.default_internal to UTF-8 * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file * Read templates as BINARY, use default_external or template-wide magic comments inside the Template to set the initial encoding * This means that template handlers in Ruby 1.9 will receive Strings encoded in default_internal (UTF-8 by default) * Create a better Exception for encoding issues, and use it when the template source has bytes that are not compatible with the specified encoding * Allow template handlers to opt-into handling BINARY. If they do so, they need to do some of their own manual encoding work * Added a "Configuration Gotchas" section to the intro Rails Guide instructing users to use UTF-8 for everything * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid $KCODE value is used Also: * Fixed a few tests that were assert() rather than assert_equal() and were caught by Minitest requiring a String for the message * Fixed a test where an assert_select was misformed, also caught by Minitest being more restrictive * Fixed a test where a Rack response was returning a String rather than an Enumerable | ||||
* | Check blocks are not incorrectly detected when compiling erubis templates ↵ | Simon Jefford | 2010-05-16 | 1 | -0/+5 |
| | | | | | | [#4575 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited] | rohit | 2010-05-16 | 2 | -5/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | partial counters with :as [#2804 state:resolved] | Jeff Kreeftmeijer | 2010-05-15 | 1 | -0/+9 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add tests for convenience methods #notice and #alert to flash.now [#4369 ↵ | Anil Wadghule | 2010-05-15 | 1 | -0/+20 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fix assert_select messages to its declaration behaviour | Paco Guzman | 2010-05-15 | 1 | -3/+13 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | move assert_template tests to their own test case [#4501 state:resolved] | David Chelimsky | 2010-05-03 | 1 | -41/+46 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Eliminate false positives when passing symbols to assert_template | David Chelimsky | 2010-05-03 | 1 | -4/+25 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | move FixtureResolver to a file that is accessible outside Rails' own tests | David Chelimsky | 2010-05-02 | 1 | -2/+0 |
| | | | | | | [#4522 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | RouteSet does not raise ActionController::RoutingError when no routes match ↵ | Carl Lerche | 2010-04-30 | 1 | -2/+4 |
| | | | | anymore. Instead, it follows the X-Cascade convention. ShowExceptions checks for X-Cascade so that the routing error page can still be displayed. | ||||
* | add HTTP Token Authorization support to complement Basic and Digest ↵ | rick | 2010-04-30 | 1 | -0/+113 |
| | | | | Authorization. | ||||
* | ActionCachingTestController rescues from all exceptions. Making sure that ↵ | Neeraj Singh | 2010-04-29 | 1 | -0/+31 |
| | | | | | | all the tests check for valid response. [#4468 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use Config::CONFIG['host_os'] instead of RUBY_PLATFORM [#4477 state:resolved] | Anil Wadghule | 2010-04-26 | 1 | -1/+2 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Action Pack: fix tests with -K*, work around Ruby 1.9.1 constant lookup. | Cezary Baginski | 2010-04-25 | 1 | -2/+2 |
| | | | | | | [#4473 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Missed commit: explicit source encoding | Jeremy Kemper | 2010-04-24 | 1 | -1/+1 |
| | |||||
* | Fix render :xml test (ht Simo Niemelä) | José Valim | 2010-04-24 | 1 | -2/+2 |
| | |||||
* | Make ActionDispatch url_for use HWIA symbolize_keys | Santiago Pastorino | 2010-04-22 | 1 | -3/+7 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Ensure that url_for uses symbolized keys in the controller. [#4391] | J Smith | 2010-04-22 | 1 | -0/+10 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Always downstream given options in :json, :xml and :js renderers and add ↵ | José Valim | 2010-04-22 | 2 | -7/+35 |
| | | | | tests for it. | ||||
* | access assigns as a method or hash, with strings or symbols [#4431 ↵ | David Chelimsky | 2010-04-17 | 1 | -0/+16 |
| | | | | state:resolved] | ||||
* | Added missing require | Santiago Pastorino | 2010-04-16 | 1 | -0/+1 |
| | |||||
* | Added test get to js should have a header with content-type text/javascript | Santiago Pastorino | 2010-04-16 | 1 | -1/+8 |
| | |||||
* | Tidy up a bit this test file | Santiago Pastorino | 2010-04-16 | 1 | -7/+2 |
| | |||||
* | Revert "Add test case which check content type when rendering rjs" partial ↵ | Santiago Pastorino | 2010-04-16 | 1 | -9/+1 |
| | | | | | | in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag This reverts commit dc251389d1ab4303b80a22642f4241940b73cbe7. | ||||
* | Make perform_caching work again, with the tests passing and backward compatible | Santiago Pastorino and Carl Lerche | 2010-04-15 | 2 | -14/+14 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | wycats | 2010-04-13 | 1 | -1/+1 |
|\ | |||||
| * | Use correct RUBY_PLATFORM regex for Windows env [#4385 state:resolved] | Anil Wadghule | 2010-04-13 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Add test case which check content type when rendering rjs partial in html ↵ | Stanko Alexander | 2010-04-13 | 1 | -1/+9 |
|/ | | | | | | template Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Move verification to a plugin as well: http://github.com/rails/verification.git | José Valim | 2010-04-10 | 1 | -270/+0 |
| | |||||
* | Fixed that default locale templates should be used if the current locale ↵ | Carl Lerche | 2010-04-08 | 1 | -0/+22 |
| | | | | template is missing [DHH] | ||||
* | Add accessors for request and response so tests don't have to mess with ↵ | Michael Koziarski | 2010-04-09 | 1 | -0/+6 |
| | | | | internal ivars | ||||
* | Fix cookie access in integration tests with other host names | Joshua Peek | 2010-04-05 | 1 | -0/+45 |
| | |||||
* | Rename config.cookie_secret to config.secret_token and pass it as ↵ | José Valim | 2010-04-05 | 2 | -5/+3 |
| | | | | configuration in request.env. This is another step forward removing global configuration. | ||||
* | * Change the object used in routing constraints to be an instance of | wycats | 2010-04-03 | 2 | -2/+2 |
| | | | | | | | | | | | ActionDispatch::Request rather than Rack::Request. * Changed ActionDispatch::Request#method to return a String, to be compatible with the Rack::Request superclass. * Changed ActionDispatch::Request#method to return the original method in the case of methodoverride and #request_method not to, to be compatible with Rack::Request | ||||
* | Deprecate cookie_verifier_secret in favor of config.cookie_secret allowing ↵ | José Valim | 2010-03-31 | 1 | -1/+1 |
| | | | | signed cookies to work again. | ||||
* | Consistent routing language | Joshua Peek | 2010-03-30 | 5 | -29/+29 |
| | |||||
* | Fix stack overflow bug in integration test router helpers | Joshua Peek | 2010-03-30 | 1 | -0/+47 |
| | |||||
* | Tests method_missing to raise NameError. [#2522 state:resolved] | Rizwan Reza | 2010-03-27 | 1 | -0/+16 |
| | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | open_session can just return the a dup of the current context. | wycats | 2010-03-22 | 1 | -5/+3 |
| | | | | | At this point, its entire purpose in the open_session {} case was to delegate back to the IntegrationTest anyway. | ||||
* | Current url helpers become actions in controller. Added a failing test case ↵ | José Valim | 2010-03-22 | 1 | -6/+17 |
| | | | | for it. | ||||
* | Fixed a bunch of tests that failed in 1.9 because they assumed that a Rack ↵ | wycats | 2010-03-19 | 4 | -7/+12 |
| | | | | response was a String. | ||||
* | Improve performance of the rendering stack by freezing formats as a sign ↵ | José Valim | 2010-03-19 | 1 | -2/+13 |
| | | | | that they shouldn't be further modified. | ||||
* | remove duplicated self.view_paths assingment on controller tests [#4206 ↵ | Santiago Pastorino | 2010-03-18 | 1 | -2/+2 |
| | | | | | | state:commited] Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Return a valid Rack response from bare ActionController::Metal | Carlhuda | 2010-03-18 | 1 | -0/+27 |
| | |||||
* | Make render :partial, :layout consistent between AC and AV | Carlhuda | 2010-03-18 | 1 | -11/+1 |
| | |||||
* | All tests pass without memoizing view_context | Carlhuda | 2010-03-18 | 2 | -3/+13 |
| | |||||
* | Deleting and setting a cookie in the same request was broken | Mathias Biilmann Christensen | 2010-03-17 | 1 | -0/+11 |
| | | | | | | | | Made sure to remove a cookie from @deleted_cookies when set [#4211 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Modify assert_template to use notifications. Also, remove ↵ | Carlhuda | 2010-03-17 | 4 | -16/+18 |
| | | | | ActionController::Base#template since it is no longer needed. | ||||
* | Remove unneeded AV::Base and AV::Template monkey-patches | Carlhuda | 2010-03-17 | 1 | -3/+2 |
| |