| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | AMo #key is now #to_key and CI is probably happy | snusnu | 2010-02-20 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch. | |||||
| * | Fix a bunch of pending tests by providing an introspection mode for the ↵ | Carlhuda | 2010-02-19 | 1 | -2/+1 | |
| | | | | | Response object that does up-front parsing of the headers to populate things like @etag | |||||
| * | Reinstate pending tests that were supposed to be fixed before the | Joshua Peek | 2010-02-19 | 1 | -13/+11 | |
| | | | | | | | beta. Shout louder this time so they actually get fixed. | |||||
| * | Merge master. | José Valim | 2010-02-17 | 1 | -0/+3 | |
| |\ | ||||||
| | * | Fix test load paths for those not using bundler | Joshua Peek | 2010-02-15 | 1 | -0/+3 | |
| | | | ||||||
| * | | Make Railties tests green again. | José Valim | 2010-02-17 | 1 | -1/+1 | |
| | | | ||||||
| * | | Ensure render :text => resource first tries to invoke :to_text on it | José Valim | 2010-02-16 | 1 | -0/+9 | |
| | | | ||||||
| * | | Rename Rails::Subscriber to Rails::LogSubscriber | Prem Sichanugrist | 2010-02-16 | 1 | -9/+9 | |
| |/ | ||||||
| * | Updates subscriber test for new output | Yehuda Katz | 2010-02-05 | 1 | -1/+1 | |
| | | ||||||
| * | Test that csrf meta content is html-escaped, too | Jeremy Kemper | 2010-02-04 | 1 | -1/+2 | |
| | | ||||||
| * | Revert dumb test | Jeremy Kemper | 2010-02-04 | 1 | -2/+2 | |
| | | ||||||
| * | HTML-escape csrf meta contents | Jeremy Kemper | 2010-02-04 | 1 | -2/+2 | |
| | | ||||||
| * | Expose CSRF param name also | Jeremy Kemper | 2010-02-04 | 1 | -1/+1 | |
| | | ||||||
| * | Expose CSRF tag for UJS adapters | Jeremy Kemper | 2010-02-04 | 1 | -1/+15 | |
| | | ||||||
| * | Convert to class_attribute | Jeremy Kemper | 2010-02-01 | 1 | -2/+2 | |
| | | ||||||
| * | Add support for compile-time <%= raw %> | Yehuda Katz | 2010-01-31 | 1 | -22/+34 | |
| | | ||||||
| * | For performance reasons, you can no longer call html_safe! on Strings. ↵ | Yehuda Katz | 2010-01-31 | 2 | -3/+3 | |
| | | | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe. | |||||
| * | deOMGifying Railties, Active Support, and Action Pack | Mikel Lindsaar | 2010-01-31 | 5 | -31/+31 | |
| | | ||||||
| * | Improve missing template error messages a little bit. | José Valim | 2010-01-31 | 1 | -1/+1 | |
| | | ||||||
| * | Move form_remote_tag and remote_form_for into prototype_legacy_helper | Joshua Peek | 2010-01-30 | 1 | -27/+18 | |
| | | ||||||
| * | Bring helpers_dir deprecation back. | José Valim | 2010-01-30 | 1 | -11/+10 | |
| | | ||||||
| * | Get rid of AM warnings in AP test suite. | José Valim | 2010-01-29 | 1 | -2/+2 | |
| | | ||||||
| * | ActionMailer should depend just on AbstractController. | José Valim | 2010-01-29 | 1 | -0/+272 | |
| | | ||||||
| * | Fix t('.helper'). | José Valim | 2010-01-26 | 1 | -10/+11 | |
| | | ||||||
| * | Add a deprecation for helpers_dir. | José Valim | 2010-01-25 | 1 | -2/+13 | |
| | | ||||||
| * | Fix failing tests after merge. | José Valim | 2010-01-24 | 1 | -2/+2 | |
| | | ||||||
| * | Make filter parameters based on request, so they can be modified for ↵ | José Valim | 2010-01-21 | 2 | -6/+20 | |
| | | | | | anything in the middleware stack. | |||||
| * | Default to sync instrumentation. | José Valim | 2010-01-21 | 1 | -15/+3 | |
| | | ||||||
| * | Tidy up new filter_parameters implementation. | José Valim | 2010-01-21 | 1 | -1/+4 | |
| | | ||||||
| * | Add deprecation warning for calling filter_parameter_logging ↵ | Prem Sichanugrist | 2010-01-21 | 1 | -51/+0 | |
| | | | | | | | ActionController::Base, and allow it to be configured in config.filter_parameters Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | Move ActionController::Translation to AbstractController::Translation. | José Valim | 2010-01-20 | 1 | -26/+0 | |
| | | ||||||
| * | Stop overriding LoadError.new to return a MissingSourceError (and sometimes ↵ | Yehuda Katz | 2010-01-19 | 1 | -1/+1 | |
| | | | | | nil!) | |||||
| * | Move parameters to the top on logging. | José Valim | 2010-01-19 | 1 | -24/+30 | |
| | | ||||||
| * | Fix failing test. | José Valim | 2010-01-19 | 1 | -2/+2 | |
| | | ||||||
| * | Clear out AS callback method pollution in AC::Base.action_methods | Joshua Peek | 2010-01-17 | 1 | -1/+27 | |
| | | ||||||
| * | Accessing nonexistant cookies through the signed jar should not raise an | Joshua Peek | 2010-01-17 | 1 | -0/+5 | |
| | | | | | exception | |||||
| * | Module lookup issue on flash_test using ruby 1.9 solved [#3716 status:resolved] | Sam Elliott and Santiago Pastorino | 2010-01-17 | 1 | -1/+1 | |
| | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | Add ActionDispatch::Railties::Subscriber and finish tidying up the logging. | José Valim | 2010-01-17 | 1 | -28/+14 | |
| | | ||||||
| * | Clean up filter parameter logging tests. | José Valim | 2010-01-17 | 1 | -27/+0 | |
| | | ||||||
| * | Cookies middleware | Joshua Peek | 2010-01-16 | 1 | -27/+5 | |
| | | ||||||
| * | Move Flash into middleware | Joshua Peek | 2010-01-15 | 1 | -2/+40 | |
| | | ||||||
| * | Make HEAD method masquerade as GET so requests are routed correctly | Joshua Peek | 2010-01-15 | 1 | -0/+13 | |
| | | ||||||
| * | Small tweaks in ActionController subscriber messages format. | José Valim | 2010-01-15 | 1 | -1/+8 | |
| | | ||||||
| * | Move Dispatcher setup to Railties and add instrumentation hook. | José Valim | 2010-01-15 | 1 | -47/+33 | |
| | | ||||||
| * | Respect resources_path_names and :path_names options in new dsl | Joshua Peek | 2010-01-13 | 1 | -21/+21 | |
| | | ||||||
| * | optimise_named_routes is unnecessary | Joshua Peek | 2010-01-13 | 2 | -14/+0 | |
| | | ||||||
| * | Tidy up ActiveRecord and Views runtime information on process action logger. | José Valim | 2010-01-14 | 1 | -7/+7 | |
| | | ||||||
| * | ControllerRuntime tests also use Rails::Subscriber::TestHelper. | José Valim | 2010-01-13 | 1 | -5/+0 | |
| | | ||||||
| * | Test fragment/page cache and send data/file notifications. | José Valim | 2010-01-13 | 1 | -11/+93 | |
| | | ||||||
| * | Add subscriber for ActionPack and move all logging inside it. | José Valim | 2010-01-13 | 4 | -107/+108 | |
| | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |