Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Skip Rack applications and redirects when generating urls | Andrew White | 2013-07-16 | 1 | -3/+3 |
| | | | | | | | | | | When generating an unnamed url (i.e. using `url_for` with an options hash) we should skip anything other than standard Rails routes otherwise it will match the first mounted application or redirect and generate a url with query parameters rather than raising an error if the options hash doesn't match any defined routes. Fixes #8018 | ||||
* | Remove `page_cache_extension` deprecated method | Francesco Rodriguez | 2013-07-01 | 1 | -15/+0 |
| | |||||
* | Re-remove deprecated API. | kennyj | 2013-06-28 | 1 | -7/+0 |
| | |||||
* | Merge pull request #11000 from sbeckeriv/accept_header | Carlos Antonio da Silva | 2013-06-25 | 1 | -0/+6 |
|\ | | | | | | | Fix undefined method `ref' for nil:NilClass for bad accept headers | ||||
| * | Fix undefined method `ref' for nil:NilClass for bad accept headers | Stephen Becker IV | 2013-06-19 | 1 | -0/+6 |
| | | |||||
* | | Remove unneeded files | Piotr Sarnacki | 2013-06-20 | 1 | -1/+0 |
|/ | |||||
* | Remove ActionController::RecordIdentifier was deprecated. | kennyj | 2013-06-01 | 2 | -63/+3 |
| | |||||
* | Revert "Integration tests support the OPTIONS http method" | Rafael Mendonça França | 2013-05-16 | 1 | -17/+1 |
| | | | | | | | | | | | | | | This reverts commit ad46884af567d6f8d6d8d777f372c39e81a560ba. Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/testing/integration.rb actionpack/test/controller/integration_test.rb Reason: It will conflict with a lot of test cases. Better to call `process` directly since this is a very uncommon HTTP method. Fixes #10638. | ||||
* | Revert "Add the options method to action_controller testcase." | Rafael Mendonça França | 2013-05-16 | 1 | -5/+0 |
| | | | | | | | | | | | | This reverts commit 0303c2325fab253adf5e4a0b738cb469c048f008. Conflicts: actionpack/lib/action_controller/test_case.rb REASON: It will conflict with a lot of test cases. Better to call `process` directly since this is a very uncommon HTTP method. Fixes #10638. | ||||
* | Merge pull request #10591 from acapilleri/cond_callback_test | Aaron Patterson | 2013-05-15 | 1 | -0/+13 |
|\ | | | | | add test for skip_before_filter with condition | ||||
| * | add test for skip_before_filter with condition | Angelo capilleri | 2013-05-13 | 1 | -0/+13 |
| | | |||||
* | | use public api for testing rather than grabbing instance variables | Aaron Patterson | 2013-05-14 | 1 | -1/+1 |
|/ | |||||
* | Fix that JSON and XML exception responses should give the HTTP error message ↵ | Jeremy Kemper | 2013-05-08 | 1 | -2/+2 |
| | | | | for their status, by default, not the message from the underlying exception | ||||
* | Test that #fresh_when accepts an array | Brandon Keepers | 2013-05-07 | 1 | -2/+19 |
| | | | | https://github.com/rails/etagger/pull/3 | ||||
* | Add support for extra options to `force_ssl` | Andrew White | 2013-04-25 | 1 | -14/+106 |
| | | | | | | | | This commit adds support for passing additional url options along with a :status option and any of the flash-related options to `redirect_to` (i.e. :flash, :alert & :notice). Closes #7570. | ||||
* | Use `request.fullpath` to build redirect url in `force_ssl` | Andrew White | 2013-04-25 | 1 | -0/+63 |
| | | | | | | | | | | | The `force_ssl` command now builds the redirect url from `request.fullpath`. This ensures that the format is maintained and it doesn't redirect to a route that has the same parameters but is defined earlier in `routes.rb`. Also any optional segments are maintained. Fixes #7528. Fixes #9061. Fixes #10305. | ||||
* | Passing subdomain: '' to url_for removes the subdomain (instead of adding a ↵ | Derek Watson | 2013-04-18 | 1 | -0/+7 |
| | | | | | | leading .) Adding a boolean route constraint checks for presence/absence of request property | ||||
* | Merge pull request #9604 from sgrif/live_streaming_exceptions | Rafael Mendonça França | 2013-04-08 | 1 | -1/+75 |
|\ | | | | | Exceptions raised when using ActionController::Live cause server crash | ||||
| * | Exception handling for controllers using ActionController::Live | Sean Griffin | 2013-03-18 | 1 | -1/+75 |
| | | | | | | | | | | | | | | | | | | Any exceptions that occured at the view or controller level for a controller using ActionController::Live would cause the server to either hang with an open socket indefinitely, or immediately crash (depending on whether the server was launched with rails s or directly). Changed the behavior of exceptions to act the same as streaming templates for html requests, and allow for an on_error callback if needed. | ||||
* | | Remove comments about removing LegacyKeyGenerator in 4.1 | Trevor Turk | 2013-04-03 | 2 | -2/+0 |
| | | |||||
* | | Rename DummyKeyGenerator -> LegacyKeyGenerator | Trevor Turk | 2013-04-02 | 2 | -4/+4 |
| | | |||||
* | | fix request methods test | Vipul A M | 2013-03-31 | 1 | -6/+2 |
| | | |||||
* | | Fix typos in AP: "overriden" => "overridden" | Carlos Antonio da Silva | 2013-03-30 | 3 | -31/+31 |
| | | |||||
* | | Refactored to remove unused variable | Anupam Choudhury | 2013-03-28 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #8458 from ↵ | Rafael Mendonça França | 2013-03-27 | 1 | -0/+24 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | lucisferre/improve-layout-override-fallback-behavior Provides standard layout lookup behavior for method and proc cases Conflicts: actionpack/CHANGELOG.md | ||||
| * | | Provides standard layout lookup behavior for method and proc cases | Chris Nicola | 2013-03-27 | 1 | -0/+24 |
| | | | | | | | | | | | | | | | | | | | | | When setting the layout either by referencing a method or supplying a Proc there is no way to fall back to the default lookup behavior if desired. This patch allows fallback to the layout lookup behavior when returning nil from the proc or method. | ||||
* | | | Update tests for #9704, named route collisions | Jeremy Kemper | 2013-03-24 | 1 | -5/+6 |
| | | | | | | | | | | | | | | | * Fix named route collision in mount test fixture * Update controller named route precedence test | ||||
* | | | Fix broken ActionController#action_missing | Janko Luin | 2013-03-20 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | A recent change introduced the assumption that all controller actions are known beforehand, which is not true when using action_missing. | ||||
* | | | Digest auth should not 500 when given a basic header. | Brad Dunbar | 2013-03-18 | 1 | -0/+8 |
| |/ |/| | |||||
* | | Merge pull request #9753 from jbarreneche/bug/render-locale-fallbacks | Carlos Antonio da Silva | 2013-03-18 | 1 | -0/+9 |
|\ \ | | | | | | | i18n locale fallback for localized views | ||||
| * | | Include I18n fallbacks in :locale lookup context | Juan Barreneche | 2013-03-16 | 1 | -0/+9 |
| | | | |||||
* | | | remove ancient TODOs [ci skip]. | Yves Senn | 2013-03-18 | 1 | -2/+0 |
| | | | |||||
* | | | Fix rake test warnings in actionpack | Mack Earnhardt | 2013-03-17 | 1 | -1/+1 |
|/ / | |||||
* | | `Http::Headers` directly modifies the passed environment. | Yves Senn | 2013-03-15 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | | | The env hash passed to `Http::Headers#new` must be in env format. Also be aware that the passed hash is modified directly. docs and test-cases for setting headers/env in functional tests. Follow up to #9700. | ||||
* | | Handle conditional get in live requests - this will prevent error when using ↵ | Bernard Potocki | 2013-03-14 | 1 | -0/+15 |
| | | | | | | | | stale on live streams(issue #9636) | ||||
* | | allow headers and env to be passed in `IntegrationTest`. | Yves Senn | 2013-03-13 | 1 | -0/+15 |
| | | | | | | | | Closes #6513. | ||||
* | | Fix warnings | Carlos Antonio da Silva | 2013-03-07 | 1 | -2/+2 |
| | | |||||
* | | Allow use of assert_template with the :file option. | Justin Coyne | 2013-03-01 | 1 | -0/+35 |
| | | | | | | | | This worked in Rails 3.2, but was a regression in 4.0.0.beta1 | ||||
* | | Add tests for #9441 | Francesco Rodriguez | 2013-02-26 | 1 | -0/+16 |
|/ | |||||
* | fix respond_to without blocks not working if one of the blocks is all | grosser | 2013-02-24 | 1 | -0/+21 |
| | |||||
* | Rack::Test::UploadedFile is a permitted scalar | Fabio Kreusch | 2013-02-21 | 1 | -1/+2 |
| | |||||
* | Remove XML Parser from ActionDispatch | Prem Sichanugrist | 2013-02-20 | 1 | -131/+15 |
| | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem. | ||||
* | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | Andrey Chernih | 2013-02-08 | 1 | -0/+35 |
| | |||||
* | Missing or unneeded require extract_options | Akira Matsuda | 2013-02-01 | 2 | -0/+2 |
| | |||||
* | Remove yaml Proc param parser test | Brendon Murphy | 2013-01-28 | 1 | -13/+0 |
| | | | | | | | | I don't believe this test is exercising any explicit params_parser behavior that the other two Proc tests aren't already doing. Given that we now know it's a bad idea to load user input via YAML.load, somebody reading this test might get a dangerous idea about building out a YAML params parser. | ||||
* | Merge pull request #9032 from firmhouse/head-breaks-csrf | Santiago Pastorino | 2013-01-28 | 1 | -0/+4 |
|\ | | | | | Make HEAD work / convert to GET once more | ||||
| * | Added a test that shows that a HEAD request does not normally pass CSRF ↵ | Michiel Sikkes | 2013-01-22 | 1 | -0/+4 |
| | | | | | | | | protection | ||||
* | | ActionDispatch::Http::UploadedFile is a permitted scalar [Closes #9051] | Xavier Noria | 2013-01-23 | 1 | -1/+2 |
|/ | |||||
* | Lets kepp using Ruby 1.9 syntax | Rafael Mendonça França | 2013-01-22 | 2 | -37/+37 |
| | |||||
* | Restore I18n.locale after running tests | Akira Matsuda | 2013-01-22 | 1 | -1/+7 |
| |