aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller
Commit message (Collapse)AuthorAgeFilesLines
* Makes send_file work again by deferring to Rack::Sendfile. Carlhuda2010-02-232-25/+2
| | | | | | | | | | * Add the Rack::Sendfile middleware * Make the header to use configurable via config.action_dispatch.x_sendfile_header (default to "X-Sendfile"). * Add Railties tests to confirm that these work * Remove the :stream, :buffer_size, and :x_senfile default options to send_file * Change the log subscriber to always say "Sent file" * Add deprecation warnings for options that are now no-ops Note that servers can configure this by setting X-Sendfile-Type. Hosting companies and those creating packages of servers specially designed for Rails applications are encouraged to specify this header so that this can work transparently.
* Fix streaming by having it create a File object, which can be handled by ↵Carlhuda2010-02-231-3/+11
| | | | Rack servers as appropriate
* Use ActionDispatch::Routing everywhereMartin Schürrer2010-02-214-9/+9
|
* Require persisted? in ActiveModel::Lint and remove new_record? and ↵José Valim2010-02-212-11/+11
| | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
* AMo #key is now #to_key and CI is probably happysnusnu2010-02-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
* Fix a bunch of pending tests by providing an introspection mode for the ↵Carlhuda2010-02-191-2/+1
| | | | Response object that does up-front parsing of the headers to populate things like @etag
* Reinstate pending tests that were supposed to be fixed before theJoshua Peek2010-02-191-13/+11
| | | | | | beta. Shout louder this time so they actually get fixed.
* Merge master.José Valim2010-02-171-0/+3
|\
| * Fix test load paths for those not using bundlerJoshua Peek2010-02-151-0/+3
| |
* | Make Railties tests green again.José Valim2010-02-171-1/+1
| |
* | Ensure render :text => resource first tries to invoke :to_text on itJosé Valim2010-02-161-0/+9
| |
* | Rename Rails::Subscriber to Rails::LogSubscriberPrem Sichanugrist2010-02-161-9/+9
|/
* Updates subscriber test for new outputYehuda Katz2010-02-051-1/+1
|
* Test that csrf meta content is html-escaped, tooJeremy Kemper2010-02-041-1/+2
|
* Revert dumb testJeremy Kemper2010-02-041-2/+2
|
* HTML-escape csrf meta contentsJeremy Kemper2010-02-041-2/+2
|
* Expose CSRF param name alsoJeremy Kemper2010-02-041-1/+1
|
* Expose CSRF tag for UJS adaptersJeremy Kemper2010-02-041-1/+15
|
* Convert to class_attributeJeremy Kemper2010-02-011-2/+2
|
* Add support for compile-time <%= raw %>Yehuda Katz2010-01-311-22/+34
|
* For performance reasons, you can no longer call html_safe! on Strings. ↵Yehuda Katz2010-01-312-3/+3
| | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe.
* deOMGifying Railties, Active Support, and Action PackMikel Lindsaar2010-01-315-31/+31
|
* Improve missing template error messages a little bit.José Valim2010-01-311-1/+1
|
* Move form_remote_tag and remote_form_for into prototype_legacy_helperJoshua Peek2010-01-301-27/+18
|
* Bring helpers_dir deprecation back.José Valim2010-01-301-11/+10
|
* Get rid of AM warnings in AP test suite.José Valim2010-01-291-2/+2
|
* ActionMailer should depend just on AbstractController.José Valim2010-01-291-0/+272
|
* Fix t('.helper').José Valim2010-01-261-10/+11
|
* Add a deprecation for helpers_dir.José Valim2010-01-251-2/+13
|
* Fix failing tests after merge.José Valim2010-01-241-2/+2
|
* Make filter parameters based on request, so they can be modified for ↵José Valim2010-01-212-6/+20
| | | | anything in the middleware stack.
* Default to sync instrumentation.José Valim2010-01-211-15/+3
|
* Tidy up new filter_parameters implementation.José Valim2010-01-211-1/+4
|
* Add deprecation warning for calling filter_parameter_logging ↵Prem Sichanugrist2010-01-211-51/+0
| | | | | | ActionController::Base, and allow it to be configured in config.filter_parameters Signed-off-by: José Valim <jose.valim@gmail.com>
* Move ActionController::Translation to AbstractController::Translation.José Valim2010-01-201-26/+0
|
* Stop overriding LoadError.new to return a MissingSourceError (and sometimes ↵Yehuda Katz2010-01-191-1/+1
| | | | nil!)
* Move parameters to the top on logging.José Valim2010-01-191-24/+30
|
* Fix failing test.José Valim2010-01-191-2/+2
|
* Clear out AS callback method pollution in AC::Base.action_methodsJoshua Peek2010-01-171-1/+27
|
* Accessing nonexistant cookies through the signed jar should not raise anJoshua Peek2010-01-171-0/+5
| | | | exception
* Module lookup issue on flash_test using ruby 1.9 solved [#3716 status:resolved]Sam Elliott and Santiago Pastorino2010-01-171-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add ActionDispatch::Railties::Subscriber and finish tidying up the logging.José Valim2010-01-171-28/+14
|
* Clean up filter parameter logging tests.José Valim2010-01-171-27/+0
|
* Cookies middlewareJoshua Peek2010-01-161-27/+5
|
* Move Flash into middlewareJoshua Peek2010-01-151-2/+40
|
* Make HEAD method masquerade as GET so requests are routed correctlyJoshua Peek2010-01-151-0/+13
|
* Small tweaks in ActionController subscriber messages format.José Valim2010-01-151-1/+8
|
* Move Dispatcher setup to Railties and add instrumentation hook.José Valim2010-01-151-47/+33
|
* Respect resources_path_names and :path_names options in new dslJoshua Peek2010-01-131-21/+21
|
* optimise_named_routes is unnecessaryJoshua Peek2010-01-132-14/+0
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-15 04:15:46 +0000