aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller
Commit message (Collapse)AuthorAgeFilesLines
...
* build and assign parameters rather than rely on mutationsAaron Patterson2015-07-081-3/+3
| | | | | We should assign parameters to the request object rather than mutate the hash that is returned by `query_parameters` or `request_parameters`
* request objects are no longer recycledAaron Patterson2015-07-081-6/+0
| | | | | | Instead of trying to manually clear out a request object, lets just allocate a new one. The rack ENV is reused and cleaned (still), but the request object is not.
* pass the variant as a parameter to more reflect real world appsAaron Patterson2015-07-081-3/+3
|
* remove call to build_requestAaron Patterson2015-07-081-1/+0
|
* let the superclass build the request and responseAaron Patterson2015-07-0810-47/+13
| | | | | We should leverage the request / response objects that the superclass has already allocated for us.
* pass variants in rather than mutating the request.Aaron Patterson2015-07-071-48/+31
| | | | | | Variants are typically set in the controller based on some attribute of the request that the browser sent. We should make our tests more in line with reality by doing the same and not mutating the request object.
* Fix the random caching test failure.Kasper Timm Hansen2015-07-051-0/+1
|
* Override default_render's behavior with a blockDave Copeland2015-06-201-0/+21
| | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`.
* Deprecate passing hash as first parameter into ActionController::HeadMehmet Emin İNAÇ2015-06-153-10/+31
|
* Fix flakyness.Kasper Timm Hansen2015-06-151-0/+1
| | | | Brought on by my own stupidity :)
* Return 204 if render is not called in API controllersJorge Bejar2015-06-111-0/+15
|
* Add test coverage for implicit render in empty actionsJorge Bejar2015-06-111-0/+14
|
* Include ParamsWrapper in AC::APIJorge Bejar2015-06-111-0/+26
| | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it.
* Rename test methods in api conditional get controller testsJorge Bejar2015-06-111-2/+2
|
* Use new hash syntaxSantiago Pastorino2015-06-112-7/+7
|
* Use nex hash syntax on testsSantiago Pastorino2015-06-111-5/+5
|
* Move Model test class inside RenderersApiController namespaceSantiago Pastorino2015-06-111-8/+8
|
* Add ActionController API functionalitySantiago Pastorino2015-06-116-0/+180
|
* Merge pull request #19094 from phoet/have_bearer_be_valid_as_wellRafael Mendonça França2015-06-011-1/+8
|\ | | | | Have Bearer be valid as well
| * allow `Bearer` as well as `Token`phoet2015-06-011-0/+7
| |
| * actually test what the name saysphoet2015-06-011-1/+1
| |
* | Merge pull request #20138 from tgxworld/deprecated_assert_templateRafael Mendonça França2015-06-019-381/+100
|\ \ | | | | | | Deprecate `assert_template` and `assigns()`.
| * | Remove `assigns` and `assert_template`.Guo Xiang Tan2015-05-309-381/+100
| |/
* | Merge pull request #20284 from kaspth/fix-caching-testRafael Mendonça França2015-06-011-3/+7
|\ \ | |/ |/| Move expectation to instance level.
| * Replace expectation with state check.Kasper Timm Hansen2015-05-301-3/+7
| | | | | | | | The tests would still pass if the cache call in the rendered templates were removed.
* | Fix warning about ambiguous first argumentArun Agrawal2015-05-291-1/+1
| |
* | Deprecate `:nothing` option for render methodMehmet Emin İNAÇ2015-05-287-12/+22
| | | | | | | | `head` method works similar to `render` method with `:nothing` option
* | Merge pull request #19808 from byroot/action-parameterRafael Mendonça França2015-05-271-0/+20
|\ \ | | | | | | [PoC] Stop shadowing parameters named `action`
| * | Allow to parameters named `action` or `controller` from AC::TestCase helpersJean Boussier2015-04-181-0/+20
| | |
* | | Merge pull request #17788 from sivagollapalli/masterArthur Nogueira Neves2015-05-201-0/+5
|\ \ \ | |_|/ |/| | Issue#17703 Test case for tempfile attribute
| * | Issue#17703 Test case for tempfile attributeSiva Gollapalli2015-04-161-0/+5
| |/ | | | | | | | | | | | | | | | | | | + To avoid regression I am adding this test case on action pack Changed to assert from assert_equal + Added msg to assertion Modified msg
* | Give authentication methods the ability to customize response message.Keenan Brock2015-05-032-6/+6
| | | | | | | | Digest allowed the messages. Add the same feature to basic and token
* | Removed unused code from request_forgery_protection testsPrathamesh Sonpatki2015-04-261-17/+0
| |
* | Why do we add a top-level constant here?Akira Matsuda2015-04-251-5/+3
| |
* | Remove unused WorkshopsController class in redirect_test.Bryce Boe2015-04-231-3/+0
|/
* Merge pull request #19736 from kmcphillips/masterRafael Mendonça França2015-04-141-0/+17
|\ | | | | Set default form builder for a controller
| * Override default form builder for a controllerKevin McPhillips2015-04-131-0/+17
| |
* | Revert "Merge pull request #19682 from ↵Santiago Pastorino2015-04-121-25/+0
|/ | | | | | | supercaracal/fix_force_ssl_redirection_flash_error" This reverts commit d215620340be7cb29e2aa87aab22da5ec9e6e6a7, reversing changes made to bbbbfe1ac02162ecb5e9a7b560134a3221f129f3.
* fix a wrong feature test method nameTaishi Kasuga2015-04-111-1/+1
|
* fix fails to force_ssl_redirection if session_store is disabledTaishi Kasuga2015-04-091-0/+25
|
* Fix ActionPack tests after changes to missing template loggereileencodes2015-04-061-0/+1
| | | | | | | | | After merging #19377 ActionPack tests were missing a require for `ActiveSupport::LogSubscriber::TestHelper` and change didn't take into account that logger could be nil. Added the require and only log to info if logger exists. This wasn't caught earlier because these tests only run after a merge.
* head no_content when there is no template or action performedStephen Bussey2015-04-051-6/+16
|
* Return super in ActionController::Parameters.const_missingShuhei Kagawa2015-03-281-1/+8
| | | | | | | | | | | | | | | | | | | | | The current implementation of ActionController::Parameters.const_missing returns `ActionController::Parameters.always_permitted_parameters` even if its `super` returns a constant without raising error. This prevents its subclass in a autoloading module/class from taking advantage of autoloading constants. class SomeParameters < ActionController::Parameters def do_something DefinedSomewhere.do_something end end In the code above, `DefinedSomewhere` is to be autoloaded with `Module.const_missing` but `ActionController::Parameters.const_missing` returns `always_permitted_parameters` instead of the autoloaded constant. This pull request fixes the issue respecting `const_missing`'s `super`.
* Fix failing tests for #19474Andrew White2015-03-231-2/+2
|
* remove old unavailable link with relevant fixGaurav Sharma2015-03-231-2/+2
|
* Fix kwargs warning in `test_get_xml`eileencodes2015-03-201-1/+1
| | | | | | ActionDispatch::IntegrationTest HTTP request methods will accept only certain kwargs in the future. This test caused a deprecation warning when running ActionPack tests. Added `params` and `headers` to fix.
* Fix test messages use directly true, false and nil instead of their symbolAkshay Vishnoi2015-03-191-3/+3
|
* Compare content_type with Mime::XML instead of regexpBoris Peterbarg2015-03-161-0/+17
| | | | | Regexp is broken for both content types including charsets and for integration tests, where the content_type is a Mime::Type and not String
* Merge pull request #19291 from hired/return-truthy-value-from-headRafael Mendonça França2015-03-131-0/+11
|\ | | | | Return truthy value from head method
| * Return true from head methodJoel Hayhurst2015-03-121-0/+11
| | | | | | | | | | | | It was returning false in normal circumstances. This broke the `head :ok and return if` construct. Add appropriate test.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 23:45:48 +0000