Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | skip_relative_url_root url_for option is dead | Joshua Peek | 2010-03-09 | 1 | -1/+1 |
| | |||||
* | RouteSet#rewrite => url_for | Joshua Peek | 2010-03-09 | 2 | -3/+3 |
| | |||||
* | Move AC::UrlRewriter onto route set | Joshua Peek | 2010-03-09 | 2 | -7/+3 |
| | |||||
* | Reinstate dom_id in controllers. | Justin Ko | 2010-03-09 | 1 | -0/+8 |
| | | | | | | | [#3040 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Get rid of the instance-level URL rewriter | wycats | 2010-03-09 | 2 | -30/+16 |
| | |||||
* | Reinstate default_url_options and remove url_options= writer | Jeremy Kemper | 2010-03-08 | 1 | -23/+19 |
| | |||||
* | Clean LookupContext API. | José Valim | 2010-03-08 | 1 | -3/+3 |
| | |||||
* | Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added ↵ | Carlhuda | 2010-03-04 | 1 | -2/+2 |
| | | | | a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request. | ||||
* | Refactor cache_store to use ActionController config | Carlhuda | 2010-03-04 | 2 | -9/+15 |
| | |||||
* | Deprecated ActionController::Base.session_options= and ↵ | Carlhuda | 2010-03-04 | 1 | -2/+3 |
| | | | | ActionController::Base.session_store= in favor of a config.session_store method (which takes params) and a config.cookie_secret variable, which is used in various secret scenarios. The old AC::Base options will continue to work with deprecation warnings. | ||||
* | Clarify cookie jar test | Jeremy Kemper | 2010-03-04 | 1 | -6/+1 |
| | |||||
* | Fixes test ordering bug (ht: evan) | wycats | 2010-03-04 | 1 | -0/+3 |
| | |||||
* | Merge branch 'configuration_refactor' | Carl Lerche | 2010-03-03 | 7 | -43/+23 |
|\ | |||||
| * | ActionController::Base.use_accept_header is not actually used anymore, so ↵ | Carl Lerche | 2010-03-03 | 3 | -19/+0 |
| | | | | | | | | let's deprecate it. | ||||
| * | ActionDispatch::Request deprecates #request_uri | Carl Lerche | 2010-03-03 | 2 | -2/+2 |
| | | | | | | | | * Refactored ActionPatch to use fullpath instead | ||||
| * | Fix tests for the request refactor | Carl Lerche | 2010-03-03 | 2 | -3/+6 |
| | | |||||
| * | Tweak the semantic of various URL related methods of ActionDispatch::Request | Carlhuda | 2010-03-03 | 2 | -6/+8 |
| | | |||||
| * | Work on deprecating ActionController::Base.relative_url_root | Carlhuda | 2010-03-03 | 1 | -11/+4 |
| | | |||||
| * | Move session_store and session_options to the AC configuration object | Carlhuda | 2010-03-03 | 1 | -2/+3 |
| | | |||||
* | | don't depend on the order of cookies (Hash ordering bug) | Yehuda Katz | 2010-03-03 | 1 | -1/+1 |
|/ | |||||
* | Fix failing Action Pack tests | Carlhuda | 2010-03-02 | 1 | -1/+2 |
| | |||||
* | No longer add missing leading / on path args to assert_redirected_to. ↵ | Jeremy Kemper | 2010-03-02 | 1 | -2/+4 |
| | | | | Deprecated in 2.3.6. | ||||
* | Action Mailer setup obviated by test bundle | Jeremy Kemper | 2010-03-02 | 1 | -12/+1 |
| | |||||
* | Remove implicit controller namespacing from new dsl | Joshua Peek | 2010-02-28 | 2 | -4/+8 |
| | |||||
* | 1.9 seems to have a bug involving cloned classes and super. Fix it by not ↵ | Carlhuda | 2010-02-26 | 1 | -8/+12 |
| | | | | cloning (and instead creating classes on demand). The 1.9 bug should be investigated. | ||||
* | If IntegrationSession is initialized with an objects that responds to ↵ | Carlhuda | 2010-02-26 | 3 | -6/+2 |
| | | | | #routes, automatically extend the URL helpers from the RouteSet onto it | ||||
* | Setting UrlFor in with_routing is no longer needed now that it's not global | Carlhuda | 2010-02-26 | 1 | -4/+5 |
| | |||||
* | Silence test deprecation warnings | Carlhuda | 2010-02-26 | 1 | -16/+55 |
| | |||||
* | Rename named_url_helpers to url_helpers and url_helpers to url_for | Carlhuda | 2010-02-26 | 4 | -9/+9 |
| | |||||
* | Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 ↵ | José Valim | 2010-02-26 | 1 | -0/+9 |
| | | | | status:resolved] | ||||
* | Rename metaclass to singleton_class | Carlhuda | 2010-02-25 | 3 | -4/+4 |
| | |||||
* | Get URL helpers working again in integration tests. | Carlhuda | 2010-02-25 | 1 | -17/+7 |
| | |||||
* | Continued effort to deglobalize the router | Carlhuda | 2010-02-25 | 2 | -27/+8 |
| | |||||
* | Fix all of AP's tests with the non global router | Carlhuda | 2010-02-25 | 1 | -2/+4 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | Carlhuda | 2010-02-25 | 1 | -1/+1 |
| | |||||
* | WIP: Remove the global router | Carlhuda | 2010-02-25 | 8 | -35/+48 |
| | |||||
* | Cleanup render callstack and make render(:json => {}, :status => 401) work ↵ | José Valim | 2010-02-24 | 1 | -0/+10 |
| | | | | again. | ||||
* | Remove ActionController::Base.resources_path_names | Carl Lerche | 2010-02-24 | 1 | -9/+10 |
| | |||||
* | Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. ↵ | Yehuda Katz | 2010-02-23 | 1 | -0/+9 |
| | | | | Closes #8994 | ||||
* | Revert "Fix test load paths for those not using bundler" | Carlhuda | 2010-02-23 | 1 | -3/+0 |
| | | | | | | This reverts commit eec2d301d4ce9df9c71c1a5aa63053eb970b6818. This commit broke tests. You cannot have a file called "bundler" on the load path. | ||||
* | Makes send_file work again by deferring to Rack::Sendfile. | Carlhuda | 2010-02-23 | 2 | -25/+2 |
| | | | | | | | | | | * Add the Rack::Sendfile middleware * Make the header to use configurable via config.action_dispatch.x_sendfile_header (default to "X-Sendfile"). * Add Railties tests to confirm that these work * Remove the :stream, :buffer_size, and :x_senfile default options to send_file * Change the log subscriber to always say "Sent file" * Add deprecation warnings for options that are now no-ops Note that servers can configure this by setting X-Sendfile-Type. Hosting companies and those creating packages of servers specially designed for Rails applications are encouraged to specify this header so that this can work transparently. | ||||
* | Fix streaming by having it create a File object, which can be handled by ↵ | Carlhuda | 2010-02-23 | 1 | -3/+11 |
| | | | | Rack servers as appropriate | ||||
* | Use ActionDispatch::Routing everywhere | Martin Schürrer | 2010-02-21 | 4 | -9/+9 |
| | |||||
* | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 2 | -11/+11 |
| | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | ||||
* | AMo #key is now #to_key and CI is probably happy | snusnu | 2010-02-20 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch. | ||||
* | Fix a bunch of pending tests by providing an introspection mode for the ↵ | Carlhuda | 2010-02-19 | 1 | -2/+1 |
| | | | | Response object that does up-front parsing of the headers to populate things like @etag | ||||
* | Reinstate pending tests that were supposed to be fixed before the | Joshua Peek | 2010-02-19 | 1 | -13/+11 |
| | | | | | | beta. Shout louder this time so they actually get fixed. | ||||
* | Merge master. | José Valim | 2010-02-17 | 1 | -0/+3 |
|\ | |||||
| * | Fix test load paths for those not using bundler | Joshua Peek | 2010-02-15 | 1 | -0/+3 |
| | | |||||
* | | Make Railties tests green again. | José Valim | 2010-02-17 | 1 | -1/+1 |
| | |