aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/url_rewriter_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the futureRyuta Kamizono2017-12-141-1/+1
| | | | Follow up of #31432.
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Add three new rubocop rulesRafael Mendonça França2016-08-161-1/+1
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-1/+0
|
* remove redundant curlies from hash argumentsXavier Noria2016-08-061-3/+3
|
* modernizes hash syntax in actionpackXavier Noria2016-08-061-14/+14
|
* applies new string literal convention in actionpack/testXavier Noria2016-08-061-25/+25
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Deprecate :controller and :action path parametersAndrew White2016-03-011-1/+3
| | | | | | | | Allowing :controller and :action values to be specified via the path in config/routes.rb has been an underlying cause of a number of issues in Rails that have resulted in security releases. In light of this it's better that controllers and actions are explicitly whitelisted rather than trying to blacklist or sanitize 'bad' values.
* remove call to build_requestAaron Patterson2015-07-081-1/+0
|
* let the superclass build the request and responseAaron Patterson2015-07-081-2/+2
| | | | | We should leverage the request / response objects that the superclass has already allocated for us.
* this test is not a controller test, so switch to AS::TCAaron Patterson2012-07-281-1/+1
|
* Remove default match without specified methodJose and Yehuda2012-04-241-1/+1
| | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964
* / is allowed in URI fragmentsJeremy Kemper2011-10-131-2/+2
|
* Removed deprecated RouteSet API, still many tests failPiotr Sarnacki2010-09-051-0/+5
|
* Consistent routing languageJoshua Peek2010-03-301-14/+14
|
* RouteSet#rewrite => url_forJoshua Peek2010-03-091-1/+1
|
* Move AC::UrlRewriter onto route setJoshua Peek2010-03-091-4/+1
|
* Get rid of the instance-level URL rewriterwycats2010-03-091-29/+15
|
* WIP: Remove the global routerCarlhuda2010-02-251-16/+16
|
* Remove duplicated url_for code and move methods shared between ActionMailer ↵José Valim2010-01-071-265/+0
| | | | and ActionController up to AbstractController.
* Remove deprecated formatted named routesJosé Valim2010-01-041-18/+0
|
* More test portingJoshua Peek2009-12-081-3/+3
|
* Use new routing dsl in testsJoshua Peek2009-12-081-2/+2
|
* Start rewriting some internal tests to use the new routing dslJoshua Peek2009-10-201-5/+3
|
* Fix brittle query string comparisonsJoshua Peek2009-10-171-5/+5
|
* Add fake controllers for url rewriter testsJoshua Peek2009-09-061-0/+1
|
* UrlRewriter#rewrite_url should call #to_param on the value given in :anchor ↵Jeffrey Hardy2009-08-261-0/+26
| | | | | | | | option, just as #url_for does [#2746 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Cleanup route reloading in tests. Prefer with_routing over using ↵Joshua Peek2009-08-161-70/+71
| | | | ActionController::Routing::Routes directly
* Deprecate router generation "best match" sortingJoshua Peek2009-08-091-3/+3
|
* Ruby 1.9 compat: rename deprecated assert_raises to assert_raise.Jeremy Kemper2009-03-081-1/+1
| | | | [#1617 state:resolved]
* Ensure that when UrlWriter is included in multiple classes, the ↵Nathan de Vries2009-01-281-1/+16
| | | | | | default_url_options of one don't affect the other. [#1277 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix routing test and add changelog note about draw no longer clearing the ↵David Heinemeier Hansson2008-11-261-0/+1
| | | | route set
* Added optimal formatted routes to rails, deprecating the formatted_* ↵Aaron Batalion2008-11-261-0/+35
| | | | | | methods, and reducing routes creation by 50% [#1359 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
* Move controller assertions from base TestCase to AC:: and AV::TestCaseJeremy Kemper2008-11-071-3/+2
|
* AbstractRequest.relative_url_root is no longer automatically configured by a ↵Joshua Peek2008-07-241-28/+27
| | | | HTTP header. It can now be set in your configuration environment with config.action_controller.relative_url_root
* Add :trailing_slash option to UrlWriter. Closes #9117 [juanjo.bazan]Michael Koziarski2008-02-181-0/+34
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* UrlWriter respects relative_url_root. Closes #10748.Jeremy Kemper2008-01-101-4/+34
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-051-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix url_for, redirect_to, etc. with :controller => :symbol instead of ↵Jeremy Kemper2007-10-071-0/+4
| | | | | | 'string'. Closes #8562, #9525. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Disable optimisation code for UrlWriter as request.host doesn't make sense ↵Michael Koziarski2007-09-171-0/+4
| | | | | | | | | there. Don't try to use the .to_query method when the route has no dynamic segments. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7501 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make :trailing_slash work with query parameters for url_for. Closes #4004 [nov]Michael Koziarski2007-07-141-0/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improve UrlRewriter tests. Improve helper test coverage. Closes #7207, ↵Jeremy Kemper2007-06-131-0/+10
| | | | | | #7208, #7212. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Update UrlWriter to accept :anchor parameter. Closes #6771.Nicholas Seckar2007-05-021-0/+13
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6648 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Adjust test for unsorted Array#to_query. References #7756.Jeremy Kemper2007-03-111-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allow array and hash query parameters. Array route parameters are ↵Jeremy Kemper2007-03-061-10/+51
| | | | | | converted/to/a/path as before. References #6765, #7462. Closes #7047. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added URL escaping of user and password when used through the UrlWriterDavid Heinemeier Hansson2007-03-041-1/+8
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added user/password options for url_for to add http authentication in a URL ↵David Heinemeier Hansson2007-03-031-0/+7
| | | | | | [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added :port and :host handling to UrlRewriter (which unified url_for usage, ↵David Heinemeier Hansson2007-02-251-0/+26
| | | | | | regardless of whether it's called in view or controller) #7616 [alancfrancis] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de