Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Expectations first | Akira Matsuda | 2014-08-18 | 1 | -15/+15 |
| | |||||
* | helper methods are public, so we can just call them | Aaron Patterson | 2014-07-17 | 1 | -4/+4 |
| | | | | | also if you want a path from a named helper, you should call helper_path, not helper_url(:only_path => true). | ||||
* | use Ruby for mocking | Aaron Patterson | 2014-06-12 | 1 | -1/+1 |
| | |||||
* | Revert "Rewrite journey routes formatter for performance" | Aaron Patterson | 2014-05-19 | 1 | -0/+20 |
| | | | | | | | | | | This reverts commit 5c224de9e110763ec7a0f01f5b604bcf81f40bfb. Conflicts: actionpack/lib/action_dispatch/journey/visitors.rb 5c224de9e110763ec7a0f01f5b604bcf81f40bfb introduced a bug in the formatter. This commit includes a regression test. | ||||
* | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵ | Guilherme Cavalcanti | 2014-05-11 | 1 | -0/+12 |
| | | | | relative URL. | ||||
* | Remove outdated TODO from url_for test, this test was fixed in 900a2d30 | Zachary Scott | 2014-02-09 | 1 | -3/+0 |
| | |||||
* | Take Hash with options inside Array in #url_for | Andrey Ognevsky | 2013-11-15 | 1 | -0/+18 |
| | |||||
* | Passing subdomain: '' to url_for removes the subdomain (instead of adding a ↵ | Derek Watson | 2013-04-18 | 1 | -0/+7 |
| | | | | | | leading .) Adding a boolean route constraint checks for presence/absence of request property | ||||
* | Namespace HashWithIndifferentAccess | Akira Matsuda | 2013-01-07 | 1 | -3/+2 |
| | |||||
* | Remove warning renaming the test classes to use the test convention | Rafael Mendonça França | 2012-07-29 | 1 | -1/+1 |
| | |||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -8/+8 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Revert "Merge pull request #5750 from ahoward/master" | Santiago Pastorino | 2012-04-08 | 1 | -18/+0 |
| | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement. | ||||
* | Make url_for work when option is nil and default_url_options has | Rafael Mendonça França | 2012-04-05 | 1 | -0/+9 |
| | | | | stringified keys | ||||
* | carefully and quickly merge url_for options | ara.t.howard | 2012-04-04 | 1 | -0/+9 |
| | |||||
* | Add test for default_url_options[:port] | Aaron Suggs | 2012-03-28 | 1 | -0/+12 |
| | |||||
* | Fix url_for options[:subdomain] to allow objects as values | choonkeat | 2011-12-14 | 1 | -0/+8 |
| | | | | * e.g. blog_url(subdomain: current_user) instead of blog_url(subdomain: current_user.to_param) | ||||
* | Fix trouble using :subdomain in development environment when using ↵ | Bradford Folkens | 2011-11-08 | 1 | -0/+11 |
| | | | | | | | | | | | | | | | | numeric addresses. See-also pull request #3561 from 3-1-stable Otherwise the following occurs: TypeError: can't convert nil into String /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:75:in host_or_subdomain_and_domain' /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:37:in url_for' /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/routing/url_for.rb:147:in test_subdomain_may_be_accepted_with_numeric_host' /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in run' /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:426:in send' /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:81:in run' | ||||
* | :subdomain can now be specified with a value of false in url_for, allowing ↵ | Kamil Sobieraj | 2011-10-04 | 1 | -0/+14 |
| | | | | for subdomain(s) removal from the host during link generation. Closes #2025 | ||||
* | expected message should come first | Neeraj Singh | 2011-06-11 | 1 | -2/+2 |
| | |||||
* | Filter params that return nil for to_param and allow through false values | Andrew White | 2011-03-09 | 1 | -0/+8 |
| | |||||
* | Protocol-relative URL support. | Stephen Celis | 2011-02-02 | 1 | -1/+14 |
| | | | | | | [#5774 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | :subdomain, :domain and :tld_length options can now be used in url_for, ↵ | Josh Kalderimis | 2010-11-23 | 1 | -1/+22 |
| | | | | | | allowing for easy manipulation of the host during link generation. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use parentheses when using assert_match followed by a regexp to avoid warnings. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Fixed url_for test | Łukasz Strzałkowski | 2010-09-05 | 1 | -1/+1 |
| | | | | Added route which matches all: controller, action, id and format | ||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -4/+4 |
| | |||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | URL fragments should not have safe characters escaped. Ref: Appendix A, ↵ | Andrew White | 2010-06-25 | 1 | -3/+9 |
| | | | | | | | | http://tools.ietf.org/rfc/rfc3986.txt [#4762 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Make ActionDispatch url_for use HWIA symbolize_keys | Santiago Pastorino | 2010-04-22 | 1 | -3/+7 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Ensure that url_for uses symbolized keys in the controller. [#4391] | J Smith | 2010-04-22 | 1 | -0/+10 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added ↵ | Carlhuda | 2010-03-04 | 1 | -2/+2 |
| | | | | a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request. | ||||
* | Work on deprecating ActionController::Base.relative_url_root | Carlhuda | 2010-03-03 | 1 | -11/+4 |
| | |||||
* | Setting UrlFor in with_routing is no longer needed now that it's not global | Carlhuda | 2010-02-26 | 1 | -4/+5 |
| | |||||
* | WIP: Remove the global router | Carlhuda | 2010-02-25 | 1 | -1/+1 |
| | |||||
* | ActionMailer should depend just on AbstractController. | José Valim | 2010-01-29 | 1 | -0/+272 |